diff --git a/src/librustc/middle/resolve.rs b/src/librustc/middle/resolve.rs index ed2f1db2aa8..0c8697d31f3 100644 --- a/src/librustc/middle/resolve.rs +++ b/src/librustc/middle/resolve.rs @@ -2822,9 +2822,10 @@ impl<'a> Resolver<'a> { .contains_key(&name) { match import_resolution.type_target { Some(ref target) if !target.shadowable => { - self.session.span_err(import_span, - "import conflicts with imported \ - crate in this module"); + let msg = format!("import `{}` conflicts with imported \ + crate in this module", + token::get_name(name).get()); + self.session.span_err(import_span, msg.as_slice()); } Some(_) | None => {} } @@ -2845,9 +2846,10 @@ impl<'a> Resolver<'a> { match *name_bindings.value_def.borrow() { None => {} Some(ref value) => { - self.session.span_err(import_span, - "import conflicts with value \ - in this module"); + let msg = format!("import `{}` conflicts with value \ + in this module", + token::get_name(name).get()); + self.session.span_err(import_span, msg.as_slice()); match value.value_span { None => {} Some(span) => { @@ -2867,9 +2869,10 @@ impl<'a> Resolver<'a> { match *name_bindings.type_def.borrow() { None => {} Some(ref ty) => { - self.session.span_err(import_span, - "import conflicts with type in \ - this module"); + let msg = format!("import `{}` conflicts with type in \ + this module", + token::get_name(name).get()); + self.session.span_err(import_span, msg.as_slice()); match ty.type_span { None => {} Some(span) => { diff --git a/src/test/compile-fail/resolve-conflict-import-vs-extern-crate.rs b/src/test/compile-fail/resolve-conflict-import-vs-extern-crate.rs index d13503b23fb..f27b11d5411 100644 --- a/src/test/compile-fail/resolve-conflict-import-vs-extern-crate.rs +++ b/src/test/compile-fail/resolve-conflict-import-vs-extern-crate.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -use std::slice as std; //~ ERROR import conflicts with imported crate +use std::slice as std; //~ ERROR import `std` conflicts with imported crate fn main() { } diff --git a/src/test/compile-fail/resolve-conflict-item-vs-import.rs b/src/test/compile-fail/resolve-conflict-item-vs-import.rs index 3834007f5ff..96800918351 100644 --- a/src/test/compile-fail/resolve-conflict-item-vs-import.rs +++ b/src/test/compile-fail/resolve-conflict-item-vs-import.rs @@ -9,7 +9,7 @@ // except according to those terms. use std::mem::transmute; -//~^ ERROR import conflicts with value in this module +//~^ ERROR import `transmute` conflicts with value in this module fn transmute() {} diff --git a/src/test/compile-fail/resolve-conflict-type-vs-import.rs b/src/test/compile-fail/resolve-conflict-type-vs-import.rs new file mode 100644 index 00000000000..fa072fa62ab --- /dev/null +++ b/src/test/compile-fail/resolve-conflict-type-vs-import.rs @@ -0,0 +1,18 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +use std::slice::Items; +//~^ ERROR import `Items` conflicts with type in this module + +struct Items; + +fn main() { +} +