diff --git a/src/doc/complement-cheatsheet.md b/src/doc/complement-cheatsheet.md index 804d878398b..5cd555cad8e 100644 --- a/src/doc/complement-cheatsheet.md +++ b/src/doc/complement-cheatsheet.md @@ -60,7 +60,7 @@ To return an Owned String (~str) use the str helper function [`from_utf8_owned`] ~~~ use std::str; -let x: Option<~str> = str::from_utf8_owned(~[104u8,105u8]); +let x: Result<~str,~[u8]> = str::from_utf8_owned(~[104u8,105u8]); let y: ~str = x.unwrap(); ~~~ diff --git a/src/libstd/str.rs b/src/libstd/str.rs index fa4cf8e4427..5f117ca0821 100644 --- a/src/libstd/str.rs +++ b/src/libstd/str.rs @@ -87,6 +87,7 @@ use iter::{Iterator, range, AdditiveIterator}; use mem::transmute; use mem; use option::{None, Option, Some}; +use result::{Result, Ok, Err}; use slice::Vector; use slice::{ImmutableVector, MutableVector, CloneableVector}; use strbuf::StrBuf; @@ -105,12 +106,14 @@ Section: Creating a string */ /// Consumes a vector of bytes to create a new utf-8 string. -/// Returns None if the vector contains invalid UTF-8. -pub fn from_utf8_owned(vv: ~[u8]) -> Option<~str> { +/// +/// Returns `Err` with the original vector if the vector contains invalid +/// UTF-8. +pub fn from_utf8_owned(vv: ~[u8]) -> Result<~str, ~[u8]> { if is_utf8(vv) { - Some(unsafe { raw::from_utf8_owned(vv) }) + Ok(unsafe { raw::from_utf8_owned(vv) }) } else { - None + Err(vv) } } @@ -2115,13 +2118,13 @@ mod tests { #[test] fn test_str_from_utf8_owned() { let xs = bytes!("hello").to_owned(); - assert_eq!(from_utf8_owned(xs), Some("hello".to_owned())); + assert_eq!(from_utf8_owned(xs), Ok("hello".to_owned())); let xs = bytes!("ศไทย中华Việt Nam").to_owned(); - assert_eq!(from_utf8_owned(xs), Some("ศไทย中华Việt Nam".to_owned())); + assert_eq!(from_utf8_owned(xs), Ok("ศไทย中华Việt Nam".to_owned())); let xs = bytes!("hello", 0xff).to_owned(); - assert_eq!(from_utf8_owned(xs), None); + assert_eq!(from_utf8_owned(xs), Err(bytes!("hello", 0xff).to_owned())); } #[test]