From d65fee28d356bf4ca8e95e9ced43db28b6db7246 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 27 Mar 2015 13:22:26 -0700 Subject: [PATCH] Test fixes and rebase conflicts, round 2 --- src/compiletest/compiletest.rs | 1 - src/compiletest/procsrv.rs | 10 ++++------ src/librustc/lib.rs | 1 - src/librustdoc/lib.rs | 5 +---- src/librustdoc/plugins.rs | 6 +++--- src/libstd/dynamic_lib.rs | 2 -- 6 files changed, 8 insertions(+), 17 deletions(-) diff --git a/src/compiletest/compiletest.rs b/src/compiletest/compiletest.rs index 6511bbd8475..f0aacc1460b 100644 --- a/src/compiletest/compiletest.rs +++ b/src/compiletest/compiletest.rs @@ -13,7 +13,6 @@ #![feature(box_syntax)] #![feature(collections)] #![feature(old_io)] -#![feature(old_path)] #![feature(rustc_private)] #![feature(unboxed_closures)] #![feature(std_misc)] diff --git a/src/compiletest/procsrv.rs b/src/compiletest/procsrv.rs index ceed88b6236..b30efaa6c29 100644 --- a/src/compiletest/procsrv.rs +++ b/src/compiletest/procsrv.rs @@ -8,11 +8,9 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -#![allow(deprecated)] // for old path, for dynamic_lib - use std::dynamic_lib::DynamicLibrary; use std::io::prelude::*; -use std::old_path::Path; +use std::path::PathBuf; use std::process::{ExitStatus, Command, Child, Output, Stdio}; fn add_target_env(cmd: &mut Command, lib_path: &str, aux_path: Option<&str>) { @@ -20,15 +18,15 @@ fn add_target_env(cmd: &mut Command, lib_path: &str, aux_path: Option<&str>) { // search path for the child. let mut path = DynamicLibrary::search_path(); match aux_path { - Some(p) => path.insert(0, Path::new(p)), + Some(p) => path.insert(0, PathBuf::from(p)), None => {} } - path.insert(0, Path::new(lib_path)); + path.insert(0, PathBuf::from(lib_path)); // Add the new dylib search path var let var = DynamicLibrary::envvar(); let newpath = DynamicLibrary::create_path(&path); - let newpath = String::from_utf8(newpath).unwrap(); + let newpath = newpath.to_str().unwrap().to_string(); cmd.env(var, &newpath); } diff --git a/src/librustc/lib.rs b/src/librustc/lib.rs index 1a6199292c0..4d8ed601235 100644 --- a/src/librustc/lib.rs +++ b/src/librustc/lib.rs @@ -31,7 +31,6 @@ #![feature(core)] #![feature(hash)] #![feature(libc)] -#![feature(old_path)] #![feature(quote)] #![feature(rustc_diagnostic_macros)] #![feature(rustc_private)] diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index 236ffa9884a..3cf402ae113 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -27,7 +27,6 @@ #![feature(exit_status)] #![feature(set_stdio)] #![feature(libc)] -#![feature(old_path)] #![feature(rustc_private)] #![feature(staged_api)] #![feature(std_misc)] @@ -65,8 +64,6 @@ use std::path::PathBuf; use std::rc::Rc; use std::sync::mpsc::channel; -#[allow(deprecated)] use std::old_path::Path; - use externalfiles::ExternalHtml; use serialize::Decodable; use serialize::json::{self, Json}; @@ -434,7 +431,7 @@ fn rust_input(cratefile: &str, externs: core::Externs, matches: &getopts::Matche // Load all plugins/passes into a PluginManager let path = matches.opt_str("plugin-path") .unwrap_or("/tmp/rustdoc/plugins".to_string()); - let mut pm = plugins::PluginManager::new(Path::new(path)); + let mut pm = plugins::PluginManager::new(PathBuf::from(path)); for pass in &passes { let plugin = match PASSES.iter() .position(|&(p, _, _)| { diff --git a/src/librustdoc/plugins.rs b/src/librustdoc/plugins.rs index fac8f2e2a9c..d4d214f449d 100644 --- a/src/librustdoc/plugins.rs +++ b/src/librustdoc/plugins.rs @@ -16,7 +16,7 @@ use std::dynamic_lib as dl; use serialize::json; use std::mem; use std::string::String; -use std::old_path::{Path, GenericPath}; +use std::path::PathBuf; pub type PluginJson = Option<(String, json::Json)>; pub type PluginResult = (clean::Crate, PluginJson); @@ -27,12 +27,12 @@ pub struct PluginManager { dylibs: Vec , callbacks: Vec , /// The directory plugins will be loaded from - pub prefix: Path, + pub prefix: PathBuf, } impl PluginManager { /// Create a new plugin manager - pub fn new(prefix: Path) -> PluginManager { + pub fn new(prefix: PathBuf) -> PluginManager { PluginManager { dylibs: Vec::new(), callbacks: Vec::new(), diff --git a/src/libstd/dynamic_lib.rs b/src/libstd/dynamic_lib.rs index a7329ce4e29..185a9b3ec71 100644 --- a/src/libstd/dynamic_lib.rs +++ b/src/libstd/dynamic_lib.rs @@ -21,8 +21,6 @@ use env; use ffi::{AsOsStr, CString, OsString}; use mem; use path::{Path, PathBuf}; -#[cfg(not(target_os = "android"))] use os; -#[cfg(not(target_os = "android"))] use str; pub struct DynamicLibrary { handle: *mut u8