From 1ec7a697328fb10e7135b87557ff0a5ea702dd8d Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Thu, 16 Apr 2015 09:44:05 -0700 Subject: [PATCH] std: Add an unstable method Child::id This commits adds a method to the `std::process` module to get the process identifier of the child as a `u32`. On Windows the underlying identifier is already a `u32`, and on Unix the type is typically defined as `c_int` (`i32` for almost all our supported platforms), but the actually pid is normally a small positive number. Eventually we may add functions to load information about a process based on its identifier or the ability to terminate a process based on its identifier, but for now this function should enable this sort of functionality to exist outside the standard library. --- src/libstd/process.rs | 6 ++++++ src/libstd/sys/unix/process.rs | 4 ++++ src/libstd/sys/windows/c.rs | 1 + src/libstd/sys/windows/process.rs | 6 ++++++ 4 files changed, 17 insertions(+) diff --git a/src/libstd/process.rs b/src/libstd/process.rs index 61398e16ba0..ae9316ddd62 100644 --- a/src/libstd/process.rs +++ b/src/libstd/process.rs @@ -456,6 +456,12 @@ impl Child { unsafe { self.handle.kill() } } + /// Returns the OS-assigned process identifier associated with this child. + #[unstable(feature = "process_id", reason = "api recently added")] + pub fn id(&self) -> u32 { + self.handle.id() + } + /// Waits for the child to exit completely, returning the status that it /// exited with. This function will continue to have the same return value /// after it has been called at least once. diff --git a/src/libstd/sys/unix/process.rs b/src/libstd/sys/unix/process.rs index 290310f4ad9..f4bc5973040 100644 --- a/src/libstd/sys/unix/process.rs +++ b/src/libstd/sys/unix/process.rs @@ -315,6 +315,10 @@ impl Process { fail(&mut output) } + pub fn id(&self) -> u32 { + self.pid as u32 + } + pub fn wait(&self) -> io::Result { let mut status = 0 as c_int; try!(cvt_r(|| unsafe { c::waitpid(self.pid, &mut status, 0) })); diff --git a/src/libstd/sys/windows/c.rs b/src/libstd/sys/windows/c.rs index b07d063de45..e9b850856e1 100644 --- a/src/libstd/sys/windows/c.rs +++ b/src/libstd/sys/windows/c.rs @@ -482,6 +482,7 @@ extern "system" { dwMilliseconds: libc::DWORD) -> libc::DWORD; pub fn SwitchToThread() -> libc::BOOL; pub fn Sleep(dwMilliseconds: libc::DWORD); + pub fn GetProcessId(handle: libc::HANDLE) -> libc::DWORD; } #[link(name = "userenv")] diff --git a/src/libstd/sys/windows/process.rs b/src/libstd/sys/windows/process.rs index 032a349b00e..bc4762c197e 100644 --- a/src/libstd/sys/windows/process.rs +++ b/src/libstd/sys/windows/process.rs @@ -193,6 +193,12 @@ impl Process { Ok(()) } + pub fn id(&self) -> u32 { + unsafe { + c::GetProcessId(self.handle.raw()) as u32 + } + } + pub fn wait(&self) -> io::Result { use libc::{STILL_ACTIVE, INFINITE, WAIT_OBJECT_0}; use libc::{GetExitCodeProcess, WaitForSingleObject};