OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rollup merge of #60902 - sfackler:fix-error-soudness, r=alexcrichton

Browse Source 
Prevent Error::type_id overrides

type_id now takes an argument that can't be named outside of the
std::error module, which prevents any implementations from overriding
it. It's a pretty grody solution, and there's no way we can stabilize
the method with this API, but it avoids the soudness issue!

Closes #60784

r? @alexcrichton
This commit is contained in:
Manish Goregaokar 2019-05-17 11:34:13 -07:00 committed by GitHub
commit f48f37b052
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/libstd/error.rs
View File

@ -201,11 +201,19 @@ pub trait Error: Debug + Display {
#[unstable(feature = "error_type_id", #[unstable(feature = "error_type_id",
reason = "this is memory unsafe to override in user code", reason = "this is memory unsafe to override in user code",
issue = "60784")] issue = "60784")]
fn type_id(&self) -> TypeId where Self: 'static { fn type_id(&self, _: private::Internal) -> TypeId where Self: 'static {
TypeId::of::<Self>() TypeId::of::<Self>()
} }
} }
mod private {
// This is a hack to prevent `type_id` from being overridden by `Error`
// implementations, since that can enable unsound downcasting.
#[unstable(feature = "error_type_id", issue = "60784")]
#[derive(Debug)]
pub struct Internal;
}
#[stable(feature = "rust1", since = "1.0.0")] #[stable(feature = "rust1", since = "1.0.0")]
impl<'a, E: Error + 'a> From<E> for Box<dyn Error + 'a> { impl<'a, E: Error + 'a> From<E> for Box<dyn Error + 'a> {
/// Converts a type of [`Error`] into a box of dyn [`Error`]. /// Converts a type of [`Error`] into a box of dyn [`Error`].
@ -575,7 +583,7 @@ impl dyn Error + 'static {
let t = TypeId::of::<T>(); let t = TypeId::of::<T>();
// Get TypeId of the type in the trait object // Get TypeId of the type in the trait object
let boxed = self.type_id(); let boxed = self.type_id(private::Internal);
// Compare both TypeIds on equality // Compare both TypeIds on equality
t == boxed t == boxed