OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Auto merge of #5097 - phansch:remove_fixme, r=llogiq

Browse Source 
Resolve FIXME: String::new is now a const fn

`const_string_new` is stable since Rust 1.39

changelog: none
This commit is contained in:
bors 2020-01-26 10:50:47 +00:00
commit fa046d2e7f
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/ui/missing_const_for_fn/could_be_const.rs
View File

@ -25,8 +25,7 @@ fn two() -> i32 {
abc abc
} }
// FIXME: This is a false positive in the `is_min_const_fn` function. // Could be const (since Rust 1.39)
// At least until the `const_string_new` feature is stabilzed.
fn string() -> String { fn string() -> String {
String::new() String::new()
} }

10
tests/ui/missing_const_for_fn/could_be_const.stderr
View File

@ -26,7 +26,7 @@ LL | | }
| |_^ | |_^
error: this could be a `const fn` error: this could be a `const fn`
--> $DIR/could_be_const.rs:30:1 --> $DIR/could_be_const.rs:29:1
| |
LL | / fn string() -> String { LL | / fn string() -> String {
LL | | String::new() LL | | String::new()
@ -34,7 +34,7 @@ LL | | }
| |_^ | |_^
error: this could be a `const fn` error: this could be a `const fn`
--> $DIR/could_be_const.rs:35:1 --> $DIR/could_be_const.rs:34:1
| |
LL | / unsafe fn four() -> i32 { LL | / unsafe fn four() -> i32 {
LL | | 4 LL | | 4
@ -42,7 +42,7 @@ LL | | }
| |_^ | |_^
error: this could be a `const fn` error: this could be a `const fn`
--> $DIR/could_be_const.rs:40:1 --> $DIR/could_be_const.rs:39:1
| |
LL | / fn generic<T>(t: T) -> T { LL | / fn generic<T>(t: T) -> T {
LL | | t LL | | t
@ -50,7 +50,7 @@ LL | | }
| |_^ | |_^
error: this could be a `const fn` error: this could be a `const fn`
--> $DIR/could_be_const.rs:44:1 --> $DIR/could_be_const.rs:43:1
| |
LL | / fn sub(x: u32) -> usize { LL | / fn sub(x: u32) -> usize {
LL | | unsafe { transmute(&x) } LL | | unsafe { transmute(&x) }
@ -58,7 +58,7 @@ LL | | }
| |_^ | |_^
error: this could be a `const fn` error: this could be a `const fn`
--> $DIR/could_be_const.rs:63:9 --> $DIR/could_be_const.rs:62:9
| |
LL | / pub fn b(self, a: &A) -> B { LL | / pub fn b(self, a: &A) -> B {
LL | | B LL | | B