OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use a non-existent test path instead of clobbering /dev/null

Browse Source
This commit is contained in:
Josh Stone 2020-05-01 16:50:10 -07:00
parent 7f65393b9a
commit fbd3fbdb24
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/ui/non-ice-error-on-worker-io-fail.rs
View File

@ -4,8 +4,12 @@
// //
// An attempt to `-o` into a directory we cannot write into should indeed // An attempt to `-o` into a directory we cannot write into should indeed
// be an error; but not an ICE. // be an error; but not an ICE.
//
// However, some folks run tests as root, which can write `/dev/` and end
// up clobbering `/dev/null`. Instead we'll use a non-existent path, which
// also used to ICE, but even root can't magically write there.
// compile-flags: -o /dev/null // compile-flags: -o /does-not-exist/output
// The error-pattern check occurs *before* normalization, and the error patterns // The error-pattern check occurs *before* normalization, and the error patterns
// are wildly different between build environments. So this is a cop-out (and we // are wildly different between build environments. So this is a cop-out (and we
@ -15,10 +19,10 @@
// error-pattern: error // error-pattern: error
// On Mac OS X, we get an error like the below // On Mac OS X, we get an error like the below
// normalize-stderr-test "failed to write bytecode to /dev/null.non_ice_error_on_worker_io_fail.*" -> "io error modifying /dev/" // normalize-stderr-test "failed to write bytecode to /does-not-exist/output.non_ice_error_on_worker_io_fail.*" -> "io error modifying /does-not-exist/"
// On Linux, we get an error like the below // On Linux, we get an error like the below
// normalize-stderr-test "couldn't create a temp dir.*" -> "io error modifying /dev/" // normalize-stderr-test "couldn't create a temp dir.*" -> "io error modifying /does-not-exist/"
// ignore-tidy-linelength // ignore-tidy-linelength
// ignore-windows - this is a unix-specific test // ignore-windows - this is a unix-specific test

2
src/test/ui/non-ice-error-on-worker-io-fail.stderr
View File

@ -1,6 +1,6 @@
warning: ignoring --out-dir flag due to -o flag warning: ignoring --out-dir flag due to -o flag
error: io error modifying /dev/ error: io error modifying /does-not-exist/
error: aborting due to previous error; 1 warning emitted error: aborting due to previous error; 1 warning emitted