OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Exclude Fn traits

Browse Source
This commit is contained in:
sinkuu 2017-10-08 18:04:45 +09:00
parent 2be6245179
commit fdc9a649ff
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
clippy_lints/src/needless_pass_by_value.rs
View File

@ -75,8 +75,13 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
_ => return, _ => return,
} }
// Allow `Borrow` or functions to be taken by value
let borrow_trait = need!(get_trait_def_id(cx, &paths::BORROW_TRAIT)); let borrow_trait = need!(get_trait_def_id(cx, &paths::BORROW_TRAIT));
let fn_trait = need!(cx.tcx.lang_items().fn_trait()); let fn_traits = [
need!(cx.tcx.lang_items().fn_trait()),
need!(cx.tcx.lang_items().fn_once_trait()),
need!(cx.tcx.lang_items().fn_mut_trait()),
];
let sized_trait = need!(cx.tcx.lang_items().sized_trait()); let sized_trait = need!(cx.tcx.lang_items().sized_trait());
@ -119,7 +124,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
{ {
// * Exclude a type that is specifically bounded by `Borrow`. // * Exclude a type that is specifically bounded by `Borrow`.
// * Exclude a type whose reference also fulfills its bound. // * Exclude a type whose reference also fulfills its bound.
// (e.g. `std::borrow::Borrow`, `serde::Serialize`) // (e.g. `std::convert::AsRef`, `serde::Serialize`)
let (implements_borrow_trait, all_borrowable_trait) = { let (implements_borrow_trait, all_borrowable_trait) = {
let preds = preds let preds = preds
.iter() .iter()
@ -143,7 +148,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
!is_self(arg), !is_self(arg),
!ty.is_mutable_pointer(), !ty.is_mutable_pointer(),
!is_copy(cx, ty), !is_copy(cx, ty),
!implements_trait(cx, ty, fn_trait, &[]), !fn_traits.iter().any(|&t| implements_trait(cx, ty, t, &[])),
!implements_borrow_trait, !implements_borrow_trait,
!all_borrowable_trait, !all_borrowable_trait,