Commit Graph

107929 Commits

Author SHA1 Message Date
Matthias Krüger
edd3e175d6 Remove redundant patterns when matching ( x @ _ to x) (clippy::redundant_pattern) 2020-03-05 16:30:43 +01:00
Tomasz Miąsko
e54a16cffc Change DIBuilderCreateEnumerator signature to match LLVM 9
No functional changes intended.
2020-03-05 15:34:50 +01:00
bors
c79f5f0647 Auto merge of #69692 - matthiaskrgr:submodule_upd, r=oli-obk
submodules: update clippy from 8b7f7e66 to 74eae9dc

Changes:
````
Rustup to rust-lang/rust#69506
Revive rls integration test
use question mark operator
Add regression test
Use `try_eval_usize` over `eval_usize`
Add path for display trait
Use lang items instead of get_trait_def_id where possible
Update stderr
Don't lint debug formatting in debug impl
Whitelist unused attribute for use items.
add test for #5238
````

Makes clippy tests pass again.

r? @oli-obk
2020-03-05 13:40:57 +00:00
Guillaume Gomez
6b28a8c46f Clean E0382 and E0384 explanations 2020-03-05 13:05:08 +01:00
LeSeulArtichaut
6ed4829c17
Make link to std::str active 2020-03-05 08:52:46 +01:00
Christoph Schmidler
527456e219 Bumped version number for const_eval_limit in active.rs
and renamed 'recursion_limit' in limits.rs to simple 'limit' because it does handle other limits too.
2020-03-05 08:10:39 +01:00
Christoph Schmidler
c94c74e2d9 Opt out of CTFE if the 'const_eval_limit' is set to 0 2020-03-05 08:09:52 +01:00
Christoph Schmidler
288e142737 Add a new test to reach const_limit setting, although with wrong WARNINGs yet
rename feature to const_eval_limit
2020-03-05 08:09:52 +01:00
Christoph Schmidler
ff38babc31 Disable CTFE if const_limit was set to 0, otherwise use the value set, which defaults to 1_000_000 2020-03-05 08:09:52 +01:00
Christoph Schmidler
337af5ef7a Prepare const_limit feature gate and attribute 2020-03-05 08:09:52 +01:00
bors
1e179690f8 Auto merge of #69717 - estebank:correctly-probe, r=varkor
Correctly reject `TraitCandidate` in all cases

Follow up to #69255, addresses #69629.

When `self.select_trait_candidate(trait_ref)` returned `Err(_)`, `result` wasn't being set to `NoMatch`, causing invalid methods to be selected.
2020-03-05 03:44:53 +00:00
Stein Somers
9384cba72e Documentation and slight simplification of BTreeMap's internals 2020-03-04 23:33:30 +01:00
Esteban Küber
8a3272985b Correctly reject TraitCandidate in all cases
Follow up to #69255, fix #69629.
2020-03-04 13:59:51 -08:00
Aaron Hill
e50fd5a3dc
Update stderr 2020-03-04 16:54:16 -05:00
Aaron Hill
66b152cf9f
Fix tabs 2020-03-04 16:43:14 -05:00
Aaron Hill
37c2c38aeb
Extent pretty-print test 2020-03-04 16:43:14 -05:00
Aaron Hill
1b681d6652
Test that cfg-gated if-exprs are not type-checked 2020-03-04 16:43:14 -05:00
Aaron Hill
7f19358c9e
Move if-attr tests to their own directory 2020-03-04 16:43:14 -05:00
Aaron Hill
e11cdfdae4
Add run-pass test suggested by @joshtriplett 2020-03-04 16:43:14 -05:00
Aaron Hill
b00f6745c4
Remove recovery test 2020-03-04 16:43:14 -05:00
Aaron Hill
9a299e4e21
Test trying to cfg-remove an if expression 2020-03-04 16:43:14 -05:00
Aaron Hill
e9ec47bb70
Test that stmt_expr_attrs properly gates if-attrs 2020-03-04 16:43:13 -05:00
Aaron Hill
e912d9d7ec
Test #[allow(unused)] on if expression 2020-03-04 16:43:13 -05:00
Aaron Hill
f63b88c761
Permit attributes on 'if' expressions
Previously, attributes on 'if' expressions (e.g. #[attr] if true {})
were disallowed during parsing. This made it impossible for macros to
perform any custom handling of such attributes (e.g. stripping them
away), since a compilation error would be emitted before they ever had a
chance to run.

This PR permits attributes on 'if' expressions ('if-attrs' from here on).
Both built-in attributes (e.g. `#[allow]`, `#[cfg]`) are supported.

We still do *not* accept attributes on 'other parts' of an if-else
chain. That is, the following code snippet still fails to parse:

```rust
if true {} #[attr] else if false {} else #[attr] if false {} #[attr]
else {}
```
2020-03-04 16:43:13 -05:00
Santiago Pastorino
b11cd0b587
PlaceRef<'a, 'tcx> -> PlaceRef<'tcx> 2020-03-04 18:25:03 -03:00
Santiago Pastorino
2cb2559c18
Make PlaceRef lifetimes of in_projection be both 'tcx 2020-03-04 18:18:15 -03:00
Santiago Pastorino
a5d1e189a1
Make PlaceRef lifetimes of is_prefix_of be both 'tcx 2020-03-04 18:13:47 -03:00
Santiago Pastorino
a32afa33c8
Make PlaceRef lifetimes of classify_drop_access_kind be both 'tcx 2020-03-04 18:10:01 -03:00
Santiago Pastorino
46d85e519b
Make PlaceRef lifetimes of closure_span be both 'tcx 2020-03-04 18:07:33 -03:00
Santiago Pastorino
bd4dad4281
Make PlaceRef lifetimes of move_spans be both 'tcx 2020-03-04 18:05:37 -03:00
Santiago Pastorino
a30f55f4b2
Make PlaceRef lifetimes of borrowed_content_source be both 'tcx 2020-03-04 17:47:00 -03:00
Santiago Pastorino
eb67eca74a
Make PlaceRef lifetimes of describe_field be both 'tcx 2020-03-04 17:22:28 -03:00
Santiago Pastorino
6f23650457
Make PlaceRef lifetimes of add_moved_or_invoked_closure_note be both 'tcx 2020-03-04 17:12:31 -03:00
Santiago Pastorino
c6f1244719
Make PlaceRef lifetimes of is_upvar_field_projection be both 'tcx 2020-03-04 17:00:15 -03:00
Matthias Krüger
80ed505c41 Use single-char patter on {ends,starts}_with and remove clone on copy type.
These were introduced since I last fixed most of these occurences. (clippy::clone_on_copy, clippy::single_char_pattern)
2020-03-04 20:47:05 +01:00
Matthias Krüger
d8d2004c6f Don't use "if let" bindings to only check a value and not actually bind anything.
For example:  `if let Some(_) = foo() {}`	can be reduced to	`if foo().is_some() {}`   (clippy::redundant_pattern_matching)
2020-03-04 20:41:03 +01:00
Matthias Krüger
38f5db7268 Use .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref) 2020-03-04 20:39:22 +01:00
Matthias Krüger
569676b9b0 Use .map() to modify data inside Options instead of using .and_then(|x| Some(y)) (clippy::option_and_then_some) 2020-03-04 20:35:11 +01:00
Matthias Krüger
07168f9cdc Don't use .ok() before unwrapping via .expect() on a Result.
The Result can be expect-unwrapped directly. (clippy::ok_expect)
2020-03-04 20:33:47 +01:00
Penelope Phippen
729d49d7f2
Update macros.rs: fix documentation typo. 2020-03-04 14:18:31 -05:00
Esteban Küber
81f435dd37 On mismatched delimiters, only point at empty blocks that are in the same line 2020-03-04 11:05:17 -08:00
Matthias Krüger
c3bceb1bac submodules: update clippy from 8b7f7e66 to 329923ed
Changes:
````
Apply suggestions from code review
Simplify if_chain.
Move NumericLiteral to its own module.
Included binary and octal cases.
Resolve false positives for hex int cast.
Test for unnecessary_cast of hex int literal.
run-rustfix
Lint `if let Some` in question_mark lint
Add restrictive pat use in full binded struct
Update test case answers to match cargo dev fmt
Ran cargo dev fmt
Rustup to rust-lang/rust#69506
Recommended changes from flip1995
Revive rls integration test
use question mark operator
Add regression test
Use `try_eval_usize` over `eval_usize`
Add path for display trait
Use lang items instead of get_trait_def_id where possible
Update stderr
Don't lint debug formatting in debug impl
Whitelist unused attribute for use items.
Fix one last test issue
Refactor suggested by krishna-veerareddy
Fixed compile error from merging
Changed test output to reflect cargo fmt
Run cargo dev fmt
Finished checking for cases of absolute values
add test for #5238
Some bugfixing
Created floating point abs lint and test, but not yet run
````
2020-03-04 19:56:10 +01:00
Josh Stone
53be0ccbc9 Use subslice patterns in slice methods
For all of the methods that pick off the first or last element, we can
use subslice patterns to implement them directly, rather than relying on
deeper indexing function calls. At a minimum, this means the generated
code will rely less on inlining for performance, but in some cases it
also optimizes better.
2020-03-04 10:34:24 -08:00
bors
75cf41afb4 Auto merge of #69576 - matthiaskrgr:nightly_bootstrap_from_beta, r=Centril
nightly: bootstrap from 1.42.0-beta.5 (4e1c5f0e9 2020-02-28)

This beta snapshot has the llvm miscompilation fix included and is bootstrapped from a stable version that also has it included.
2020-03-04 18:34:21 +00:00
Santiago Pastorino
634a167e05
Make PlaceRef lifetimes of move_path_for_place be both 'tcx 2020-03-04 14:06:20 -03:00
Santiago Pastorino
e32ee55a36
Make PlaceRef lifetimes of move_path_closest_to be both 'tcx 2020-03-04 14:02:11 -03:00
Eric Huss
8ea676ecca Update books 2020-03-04 08:12:24 -08:00
Santiago Pastorino
6200f5c362
Make PlaceRef lifetimes of uninitialized_error_reported be both 'tcx 2020-03-04 13:09:32 -03:00
Santiago Pastorino
f54e8634e1
Make PlaceRef lifetimes of move_error_reported be both 'tcx 2020-03-04 13:00:08 -03:00
Santiago Pastorino
842af36268
Make PlaceRef lifetimes of borrow_conflict_place be both 'tcx 2020-03-04 11:21:01 -03:00