a292ac7177
Fix prefix of debug log
2021-01-31 16:49:33 +09:00
6bc9634de3
Rename function to `suggest_accessing_field_where_appropriate`
2021-01-30 14:25:43 +09:00
2ce2d145c2
Account for union
2021-01-30 14:18:50 +09:00
08d31e0f09
Remove logging iterator
2021-01-30 13:50:44 +09:00
9e4ed337c7
Suggest accessing field when code compiles with it
2021-01-29 06:52:49 +09:00
f8e0e78d75
Rename NLL* to Nll* accordingly to C-CASE
2021-01-28 16:18:25 +09:00
446edd1e1a
Rollup merge of #79951 - LeSeulArtichaut:ty-ir, r=nikomatsakis
...
Refractor a few more types to `rustc_type_ir`
In the continuation of #79169 , ~~blocked on that PR~~.
This PR:
- moves `IntVarValue`, `FloatVarValue`, `InferTy` (and friends) and `Variance`
- creates the `IntTy`, `UintTy` and `FloatTy` enums in `rustc_type_ir`, based on their `ast` and `chalk_ir` equilavents, and uses them for types in the rest of the compiler.
~~I will split up that commit to make this easier to review and to have a better commit history.~~
EDIT: done, I split the PR in commits of 200-ish lines each
r? `````@nikomatsakis````` cc `````@jackh726`````
2021-01-28 15:09:02 +09:00
50e1ae15e9
Use ty::{IntTy,UintTy,FloatTy} in rustc
2021-01-18 21:09:30 +01:00
db95b5ca9b
Add suggestion for impl_candidates with E0283
...
Update compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
2021-01-18 21:57:15 +09:00
dcad9f1893
More review comments
2021-01-16 18:56:37 -05:00
3dea68de1d
Review changes
2021-01-16 18:56:37 -05:00
476bd53058
Cleanup
2021-01-16 18:50:34 -05:00
e76476afe4
Cleanup
2021-01-16 18:40:47 -05:00
4cd6f85a07
Remove PredicateKind
2021-01-16 18:40:47 -05:00
8278314a8b
Remove PredicateKind::Atom
2021-01-16 18:40:47 -05:00
a56bffb4f9
Use Option::map_or instead of `.map(..).unwrap_or(..)`
2021-01-14 19:23:59 +01:00
fc93e4719c
Auto merge of #80960 - Dylan-DPC:rollup-89tri8x, r=Dylan-DPC
...
Rollup of 10 pull requests
Successful merges:
- #78901 (diagnostics: Note capturing closures can't be coerced to fns)
- #79588 (Provide more information for HRTB lifetime errors involving closures)
- #80232 (Remove redundant def_id lookups)
- #80662 (Added support for i386-unknown-linux-gnu and i486-unknown-linux-gnu)
- #80736 (use Once instead of Mutex to manage capture resolution)
- #80796 (Update to LLVM 11.0.1)
- #80859 (Fix --pretty=expanded with --remap-path-prefix)
- #80922 (Revert "Auto merge of #76896 - spastorino:codegen-inline-fns2)
- #80924 (Fix rustdoc --test-builder argument parsing)
- #80935 (Rename `rustc_middle::lint::LevelSource` to `LevelAndSource`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-01-13 04:29:45 +00:00
150d1fee04
Auto merge of #79322 - jyn514:refactor-impl, r=estebank
...
Separate out a `hir::Impl` struct
This makes it possible to pass the `Impl` directly to functions, instead
of having to pass each of the many fields one at a time. It also
simplifies matches in many cases.
See `rustc_save_analysis::dump_visitor::process_impl` or `rustdoc::clean::clean_impl` for a good example of how this makes `impl`s easier to work with.
r? `@petrochenkov` maybe?
2021-01-13 01:40:41 +00:00
a8ff647deb
Separate out a `hir::Impl` struct
...
This makes it possible to pass the `Impl` directly to functions, instead
of having to pass each of the many fields one at a time. It also
simplifies matches in many cases.
2021-01-12 20:32:33 -05:00
a8a974245e
Provide more information for HRTB lifetime errors involving closures
2021-01-12 13:53:13 -08:00
d46c3e3411
Tweak `?` inference error messages
2021-01-10 19:48:11 -05:00
62a39ed526
Extract parent def handling for infer failure err
2021-01-10 19:48:11 -05:00
b9d9776fea
Refactor `cannot infer ...` message rendering
2021-01-10 19:48:10 -05:00
0496fdee4f
Note inference failures using `?` conversion
2021-01-10 19:47:57 -05:00
faf8beddef
Rollup merge of #80637 - LingMan:filter, r=oli-obk
...
Use Option::filter instead of open-coding it
`@rustbot` modify labels +C-cleanup +T-compiler
2021-01-05 09:52:42 +09:00
203d5025bb
Use Option::filter instead of open-coding it
2021-01-03 05:53:15 +01:00
8a90626a46
reduce borrowing and (de)referencing around match patterns (clippy::match_ref_pats)
2021-01-02 20:09:17 +01:00
1fc3c4c16d
adjust const generics defaults FIXMEs to the new feature gate
2021-01-01 11:01:01 +01:00
7008911080
FIx ICE on wf check for foreign fns
2020-12-31 11:25:53 +09:00
41fa0dba27
Rollup merge of #80509 - matthiaskrgr:ptr_arg, r=varkor
...
where possible, pass slices instead of &Vec or &String (clippy::ptr_arg)
2020-12-30 22:49:26 +09:00
bdc9291ed9
where possible, pass slices instead of &Vec or &String (clippy::ptr_arg)
2020-12-30 13:11:52 +01:00
a309468a8c
Rollup merge of #80348 - matthiaskrgr:less_clones, r=Dylan-DPC
...
remove redundant clones (clippy::redundant_clone)
2020-12-30 18:15:04 +09:00
c51172f38a
Rollup merge of #80344 - matthiaskrgr:matches, r=Dylan-DPC
...
use matches!() macro in more places
2020-12-28 14:13:12 +01:00
d12a358673
use matches!() macro in more places
2020-12-24 13:35:12 +01:00
6e852cc4ce
remove redundant clones (clippy::redundant_clone)
2020-12-24 12:59:22 +01:00
2e92b13a60
Prevent caching projections in the case of cycles
...
When normalizing a projection which results in a cycle, we would
cache the result of `project_type` without the nested obligations
(because they're not needed for inference). This would result in
the nested obligations only being handled once in fulfill, which
would avoid the cycle error.
Fixes #79714 , a regresion from #79305 caused by the removal of
`get_paranoid_cache_value_obligation`.
2020-12-20 21:47:51 +00:00
b1964e60b7
Auto merge of #80163 - jackh726:binder-refactor-part-3, r=lcnr
...
Make BoundRegion have a kind of BoungRegionKind
Split from #76814
Also includes making `replace_escaping_bound_vars` only return `T`
Going to r? `@lcnr`
Feel free to reassign
2020-12-20 07:01:00 +00:00
0c11b93f5a
Auto merge of #79635 - lcnr:const-eval-idk, r=oli-obk
...
const_evaluatable_checked: fix occurs check
fixes #79615
this is kind of a hack because we use `TypeRelation` for both the `Generalizer` and the `ConstInferUnifier` but i am not sure if there is a useful way to disentangle this without unnecessarily duplicating some code.
The error in the added test is kind of unavoidable until we erase the unused substs of `ConstKind::Unevaluated`. We talked a bit about this in the cg lazy norm meeting (https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/lazy_normalization_consts )
2020-12-20 00:50:46 +00:00
5e7095850c
More rebinds
2020-12-19 04:26:35 -05:00
af3b1cb0b5
Change potentially_qualified to be defined on Binder<PredicateAtom>
2020-12-18 15:57:12 -05:00
328fcee4af
Make BoundRegion have a kind of BoungRegionKind
2020-12-18 15:27:28 -05:00
da89dbb41a
Rollup merge of #80046 - camelid:diag-docs, r=lcnr
...
Add more documentation to `Diagnostic` and `DiagnosticBuilder`
cc `@estebank`
2020-12-18 00:30:20 +01:00
10487cd784
Fix typo in method name
...
unsuccessfull -> unsuccessful
2020-12-16 14:59:12 -08:00
ed80815bf2
Move binder for dyn to each list item
2020-12-11 15:02:46 -05:00
20f8538d1f
simplify if let Some(_) = x to if x.is_some() (clippy::redundant_pattern_matching)
2020-12-08 20:27:49 +01:00
1734f9c291
remove redundant clones
2020-12-05 12:59:54 +01:00
76ff0f408a
The details of higher-rank sub are in the rustc book not a doc module.
2020-12-03 23:38:36 -06:00
806c7281ec
add comment to `visit_ct_substs`
2020-12-02 16:41:01 +01:00
37354ebc97
Revert "Auto merge of #79209 - spastorino:trait-inheritance-self, r=nikomatsakis"
...
This reverts commit 349b3b324db776d1c3e3
2020-12-02 12:19:38 -03:00
71d7550350
const_evaluatable_checked: fix occurs check
2020-12-02 15:31:27 +01:00
ada7c1f429
Return FxIndexSet instead of FxHashSet to avoid order errors on different platforms
2020-11-27 18:45:34 -03:00
28446ef19e
Inline elaborate_trait_refs_that_define_assoc_type into transitive_bounds_that_define_assoc_type
2020-11-27 11:23:52 -03:00
9e0538bd07
Document elaborate_trait_refs_that_define_assoc_type
2020-11-27 11:23:51 -03:00
2ca4964db5
Allow to self reference associated types in where clauses
2020-11-27 11:23:47 -03:00
9b2117d1f6
Rollup merge of #77758 - Stupremee:turbofish-help-for-const, r=varkor
...
suggest turbofish syntax for uninferred const arguments
When not providing a const generic value, and it can not be inferred, the following suggestion is suggested:
Resolves #76737
r? ``@varkor``
2020-11-26 13:39:00 +01:00
ee6f42ba94
Thread `Constness` through selection
2020-11-22 02:13:53 +01:00
f59d03038c
Move `rustc_ty` -> `rustc_ty_utils`
2020-11-19 21:57:29 +01:00
4379a43e46
Suggest turbofish for uninferred const argument
2020-11-18 19:23:22 +01:00
e0ef0fc392
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
...
Introduce `TypeVisitor::BreakTy`
Implements MCP rust-lang/compiler-team#383 .
r? `@ghost`
cc `@lcnr` `@oli-obk`
~~Blocked on FCP in rust-lang/compiler-team#383.~~
2020-11-17 12:24:34 +00:00
a6cbd64dae
words
2020-11-16 22:42:09 +01:00
2bf93bd852
compiler: fold by value
2020-11-16 22:34:57 +01:00
df6e87cc85
Use `TypeVisitor::BreakTy` in `UnresolvedTypeFinder`
2020-11-14 21:20:10 +01:00
e0f3119103
Introduce `TypeVisitor::BreakTy`
2020-11-14 20:25:27 +01:00
0b7a7930b4
Rollup merge of #78463 - varkor:placeholder-const, r=nikomatsakis
...
Add type to `ConstKind::Placeholder`
I simply threaded `<'tcx>` through everything that required it. I'm not sure whether this is the correct thing to do, but it seems to work.
r? `@nikomatsakis`
2020-11-13 15:26:14 +01:00
e24a4b4690
Add type to `ConstKind::Placeholder`
2020-11-12 15:39:55 +00:00
9596e34ad4
Rollup merge of #76765 - guswynn:async_return, r=tmandry
...
Make it more clear what an about async fn's returns when referring to what it returns
see #76547
This is *likely* not the ONLY place that this happens to be unclear, but we can move this fn to rustc_middle or something like that and reuse it if need be, to apply it to more diagnostics
One outstanding question I have is, if the fn returns (), should I make the message more clear (what about `fn f()` vs `fn f() -> ()`, can you tell those apart in the hir?)
R? `@tmandry`
`@rustbot` modify labels +A-diagnostics +T-compiler
2020-11-10 14:45:09 +01:00
bcd2f2df67
fix a couple of clippy warnings:
...
filter_next
manual_strip
redundant_static_lifetimes
single_char_pattern
unnecessary_cast
unused_unit
op_ref
redundant_closure
useless_conversion
2020-11-04 13:48:50 +01:00
9433eb83fe
Remove implicit `Continue` type
2020-10-30 12:27:47 +01:00
4fe735b320
TypeVisitor: use `ControlFlow` in rustc_{infer,lint,trait_selection}
2020-10-30 12:27:34 +01:00
a7a0538802
Rollup merge of #78460 - varkor:turbofish-string-generic, r=lcnr
...
Adjust turbofish help message for const generics
Types are no longer special. (This message arguably only makes sense with `min_const_generics` or more, but we'll be there soon.)
r? @lcnr
2020-10-29 12:08:50 +09:00
a6d01da716
Remove irrelevant FIXME
2020-10-28 10:47:27 +00:00
28f02fbf3e
Suggest calling await on method call and field access
...
When encountering a failing method or field resolution on a `Future`,
look at the `Output` and try the same operation on it. If successful,
suggest calling `.await` on the `Future`.
This had already been introduced in #72784 , but at some point they
stopped working.
2020-10-26 08:11:43 -07:00
463b6cc0e1
Rollup merge of #78268 - JohnTitor:issue-78262, r=estebank
...
Do not try to report on closures to avoid ICE
Fixes #78262
2020-10-26 03:09:11 +01:00
7b4c397b73
Do not try to report on closures to avoid ICE
2020-10-25 11:19:49 +09:00
f5d7443a6b
Suggest semicolon removal and boxing when appropriate
2020-10-23 08:06:41 -07:00
c5485115dc
Add more `.await` suggestions on E0308
2020-10-23 08:06:41 -07:00
62ba365195
Review comments: use newtype instead of `bool`
2020-10-23 08:06:41 -07:00
671d7c4afb
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-23 08:06:13 -07:00
b0059500f6
Reduce diagram mess in 'match arms have incompatible types' error
2020-10-22 16:16:02 -07:00
8752a560b9
Lift: take self by value
2020-10-21 23:59:35 +02:00
88f5e110db
review comments
2020-10-20 09:26:15 -07:00
ae0e3d0511
Tweak "object unsafe" errors
...
Fix #77598 .
2020-10-20 09:26:14 -07:00
c146e8c54f
revert workaround #73027
2020-10-19 21:11:40 +01:00
20e032e650
Make it more clear when complaining about async fn's return types
2020-10-17 15:57:47 -07:00
f6a53b4c69
Review comments
2020-10-16 15:14:38 -04:00
eba10270c6
map_bound_ref -> rebind
2020-10-16 14:29:21 -04:00
dd5c9bf139
Use map_bound(_ref) instead of Binder::bind when possible
2020-10-16 12:58:50 -04:00
9ed2177d86
Remove unused code from rustc_infer
2020-10-14 04:14:32 +02:00
a0fc455d30
Replace absolute paths with relative ones
...
Modern compilers allow reaching external crates
like std or core via relative paths in modules
outside of lib.rs and main.rs.
2020-10-13 14:16:45 +02:00
d4d9e7f67f
Remove unused part of return value from `replace_bound_vars_with_placeholders`
2020-10-06 11:19:30 +01:00
f958e6c246
Separate bounds and predicates for associated/opaque types
2020-10-06 11:19:29 +01:00
0eb87ed55f
Rename projection_predicates to item_bounds
2020-10-06 11:18:45 +01:00
ea7e131435
Auto merge of #77171 - VFLashM:better_sso_structures, r=oli-obk
...
Better sso structures
This change greatly expands interface of MiniSet/MiniMap and renames them because they are no longer "Mini".
2020-10-05 17:18:01 +00:00
c4d8089f00
Revert "Add an unused field of type `Option<DefId>` to `ParamEnv` struct."
...
This reverts commit ab83d372ed
2020-09-26 21:01:09 -07:00
5c224a484d
MiniSet/MiniMap moved and renamed into SsoHashSet/SsoHashMap
...
It is a more descriptive name and with upcoming changes
there will be nothing "mini" about them.
2020-09-26 14:30:05 -05:00
9e02642fb3
Rollup merge of #77211 - est31:remove_unused_allow, r=oli-obk
...
Remove unused #[allow(...)] statements from compiler/
2020-09-26 12:58:34 +02:00
ac8169dc10
Rollup merge of #77093 - lcnr:const-generics-infer-warning, r=varkor
...
merge `need_type_info_err(_const)`
I hoped that this would automatically solve #76737 but it doesn't quite seem like it
fixes #77092
r? @varkor
2020-09-26 12:58:17 +02:00
9a607c0a27
unused into
2020-09-26 10:31:34 +02:00
32195ac8f4
rename functions
2020-09-26 10:28:15 +02:00
12187b7f86
Remove unused #[allow(...)] statements from compiler/
2020-09-26 01:25:55 +02:00
Hirochika Matsumoto
Yuki Okushi
LeSeulArtichaut
Daiki Ihara
Jack Huey
LingMan
bors
Joshua Nelson
Esteban Küber
William Bain
Matthias Krüger
Rémy Rakic
Dylan DPC
Matthew Jasper
Camelid
Benjamin Peterson
Bastian Kauschke
Santiago Pastorino
Jonas Schievink
Justus K
Guillaume Gomez
varkor
David Tolnay
SNCPlay42
Gus Wynn
est31
Dylan MacKenzie
Valerii Lashmanov
Ralf Jung
