Joshua Holmer
b1e4b496e1
Address @ilogiq's nits
2016-02-15 13:36:10 -05:00
mcarton
00b27bf7be
Fix suggestion in COLLAPSIBLE_IF lint
2016-02-15 17:43:16 +01:00
mcarton
d755b1ebe2
Cleanup
2016-02-15 13:25:29 +01:00
Joshua Holmer
7eea67605a
Lint single-character strings as P: Pattern args
...
Fixes #650
2016-02-14 22:40:43 -05:00
mcarton
1b93d71645
Fix ICE in EXPL_IMPL_CLONE_ON_COPY
2016-02-14 20:31:23 +01:00
llogiq
6a624fe77c
Merge pull request #662 from mcarton/#601
...
Fix #601
2016-02-14 12:58:36 +01:00
llogiq
5521a75707
Merge pull request #654 from mcarton/new
...
Lints about `new` methods
2016-02-13 22:19:36 +01:00
mcarton
4562040d6b
Fix false positive in NEEDLESS_RANGE_LOOP
2016-02-13 22:09:17 +01:00
mcarton
49e2501c63
Fix false positive for ifs_same_cond and cfg!
2016-02-13 15:36:57 +01:00
mcarton
e8c2aa2997
Lint about new methods not returning Self
2016-02-13 13:03:28 +01:00
mcarton
edc0d19a3f
Add new to WRONG_SELF_CONVENTION
2016-02-13 01:42:46 +01:00
mcarton
7f567ce1d1
Fix false negative with OK_EXPECT
2016-02-13 01:38:55 +01:00
mcarton
90f1f0d71c
Merge branch 'master' into copies2
2016-02-12 18:56:27 +01:00
Oliver 'ker' Schneider
3f34b65747
fix nightly breakage
2016-02-12 18:35:44 +01:00
mcarton
07228a1041
Fix Hash implementation for Constant
2016-02-12 15:51:55 +01:00
mcarton
f309dc3c0f
Add the MATCH_SAME_ARMS lint
2016-02-12 14:30:52 +01:00
mcarton
cbbc667b1b
Dogfood for future MATCH_SAME_ARMS lint
2016-02-12 14:30:26 +01:00
mcarton
ee830ba55e
Extend IF_SAME_THEN_ELSE to ifs sequences
2016-02-12 14:30:26 +01:00
mcarton
88beb35194
Implement Expr spanless-hashing
2016-02-12 14:30:26 +01:00
llogiq
9ee462625b
Merge pull request #637 from mcarton/debug
...
Lint usage of `Debug`-based formatting
2016-02-12 12:18:15 +01:00
Oliver Schneider
eed9ec15fb
improve the no_effect lint
2016-02-11 13:50:41 +01:00
Manish Goregaokar
1013026f18
Merge branch 'pr-645'
2016-02-10 10:20:23 +05:30
Joshua Holmer
7e06737d6f
Improve testing and suggestion messages on bool_comparison
2016-02-09 15:44:07 -05:00
mcarton
2db6965c81
Lint usage of Debug-based formatting
2016-02-09 21:22:54 +01:00
mcarton
1a8b8cd28f
Don’t use {:?} and use span_suggestion in TOPLEVEL_REF_ARG
2016-02-09 21:22:30 +01:00
mcarton
34812e82d0
Use const_eval in loops
2016-02-09 21:22:30 +01:00
Joshua Holmer
14292674b0
display suggestion separately from lint
2016-02-09 14:44:42 -05:00
Manish Goregaokar
93461afffc
Merge branch 'pr-613'
...
Conflicts:
src/lib.rs
src/types.rs
2016-02-10 01:03:26 +05:30
Joshua Holmer
56b3e7b4c2
lint comparison to bool (e.g. y == true)
...
Addresses #630
2016-02-09 14:10:22 -05:00
llogiq
3b0b9e0e06
Merge remote-tracking branch 'origin/master' into regex_macro
2016-02-08 23:51:30 +01:00
llogiq
6525471214
fix #595
2016-02-08 23:48:04 +01:00
Oliver Schneider
672beb4138
prevent panic in enum glob import lint if a crate's elements are glob imported
...
fixes #639
2016-02-08 11:28:18 +01:00
llogiq
ceb9a8bdd7
regex macro lint
2016-02-07 22:50:54 +01:00
mcarton
cd7a913200
Add - and / to EQ_OP
2016-02-07 13:26:34 +01:00
mcarton
8e22d08129
Improve is_exp_equal
2016-02-07 13:26:34 +01:00
mcarton
d862495d19
Lint ifs with the same then and else blocks
2016-02-07 13:26:34 +01:00
mcarton
fe6f2a22ba
Lint about consecutive ifs with same condition
2016-02-07 13:26:34 +01:00
Manish Goregaokar
9ba5d45509
Merge branch 'pr-581'
...
Conflicts:
README.md
2016-02-07 17:40:48 +05:30
mcarton
d9a2a7ac3c
Fix false negative in TRIVIAL_REGEX
2016-02-06 18:13:19 +01:00
mcarton
a02b8124de
Lint about trivial regexes
2016-02-05 23:10:48 +01:00
mcarton
70124cf591
Fix case conventions
2016-02-05 21:54:29 +01:00
mcarton
0f50b0981d
Check for pattern use in FOR_KV_MAP
2016-02-05 19:14:02 +01:00
mcarton
431c446746
Lint looping on maps ignoring the keys or values
2016-02-05 19:13:14 +01:00
llogiq
2adc906a75
Merge branch 'master' into regex_syntax
2016-02-05 17:34:09 +01:00
llogiq
a14514f7c8
fixed span position and README
2016-02-05 17:29:41 +01:00
Manish Goregaokar
8f7b8524d3
Test for double-ref lint
2016-02-05 16:04:59 +05:30
llogiq
3d85cc24e7
new regex syntax lint, fixes #597
2016-02-05 00:36:06 +01:00
Oliver Schneider
3b8375d90b
warn on useing all variants of an enum
2016-02-03 15:38:23 +01:00
mcarton
fab10c07e8
Fix confusing message for STRING_TO_STRING
2016-02-03 13:52:19 +01:00
scurest
908fb143ef
Extend ABSURD_UNSIGNED_COMPARISONS to handle more types
2016-02-03 05:08:00 -06:00
Manish Goregaokar
5eb884b7b0
Merge branch 'pr-593'
...
Conflicts:
README.md
src/lib.rs
2016-02-03 03:26:51 +05:30
mcarton
db205c82a4
Add a lint about using clone on Copy types
2016-02-02 22:35:01 +01:00
inrustwetrust
bd86922c4f
Add lint to warn for calls to std::mem::drop with a reference argument
2016-02-02 20:24:41 +01:00
llogiq
3a31576d76
fixed #606
2016-02-01 20:37:07 +01:00
llogiq
1dd19fbae3
Merge pull request #609 from oli-obk/prefixed_enum_variants
...
lint against enums where all variants share a prefix/postfix
2016-02-01 20:36:18 +01:00
Oliver Schneider
3b1df8d381
fallout
2016-02-01 13:01:16 +01:00
Seo Sanghyeon
35ec57c116
Skip escape analysis for closure arguments
2016-02-01 20:35:01 +09:00
Oliver 'ker' Schneider
d6c0435c81
lint on single match expressions with a value in the else path
2016-02-01 11:29:03 +01:00
llogiq
a2ad0c6695
fixed #528
2016-01-31 23:25:10 +01:00
scurest
e48fbba864
Add a lint to suggest uint == 0 over uint <= 0
2016-01-29 21:21:12 -06:00
llogiq
5402ef3d27
Merge branch 'devonhollowood-for-loop-over-option'
...
Conflicts:
README.md
2016-01-30 01:34:35 +01:00
Devon Hollowood
405d7c691e
Add for_loop_over_result lint
2016-01-29 15:24:17 -08:00
mcarton
1b9fbd8801
Fix false positive in NEEDLESS_LIFETIMES
2016-01-29 22:31:12 +01:00
mcarton
afb7e67217
Add a lint to warn about &vec![_] if &[_] would do
2016-01-29 17:41:52 +01:00
Devon Hollowood
f5cc94c96a
Add for_loop_over_option lint
2016-01-28 23:39:00 -08:00
Manish Goregaokar
4c14d98c9f
Merge pull request #549 from mcarton/ifs
...
Remove and lint about useless braces in `else { if .. }`
2016-01-29 03:39:27 +05:30
mcarton
da93643357
Add a lint to warn about use of print{,ln}!
2016-01-28 19:34:52 +01:00
llogiq
291b73b8e8
Merge master and re-run update_lints.py
2016-01-27 22:23:21 +01:00
Florian Hartwig
04f9d35f64
Add a lint for casts from char literals to u8
2016-01-27 20:23:59 +01:00
llogiq
a1ac3125de
fixed and extended tests
2016-01-27 20:13:15 +01:00
llogiq
5d5e50d67e
fixed suggestion for iter case
2016-01-27 14:51:30 +01:00
llogiq
d152e5c683
fixed argument check
2016-01-26 23:51:06 +01:00
llogiq
2d97f916eb
added more test, now works with vecs and iter
2016-01-25 19:46:56 +01:00
llogiq
ed96583677
extend_from_slice lint
2016-01-25 14:02:47 +01:00
mcarton
8ef0b86fab
Lint explicit Clone implementations on Copy type
2016-01-24 15:33:23 +01:00
Oliver 'ker' Schneider
2a51f8d2be
lint on items following statements
2016-01-24 10:16:56 +01:00
mcarton
c6c0edb19b
Add a lint about deriving Hash and implementing PartialEq
2016-01-21 19:56:31 +01:00
mcarton
91ff1db5bc
Add a lint for starts_with
2016-01-20 12:57:14 +01:00
mcarton
5ac6659814
Handle Entry types in OR_FUN_CALL lint
2016-01-20 11:42:25 +01:00
Florian Hartwig
01eda52cb5
Add lint for "string literal".as_bytes()
2016-01-19 19:17:50 +01:00
llogiq
5623e9e601
Merge pull request #559 from mcarton/redundant_closure
...
Fix redundant_closure false positive
2016-01-18 19:33:42 +01:00
mcarton
9d5e9cfd97
Fix redundant_closure false positive
2016-01-18 19:28:06 +01:00
mcarton
3713fd3dce
Check types in the CMP_OWNED lint
2016-01-18 15:35:50 +01:00
Manish Goregaokar
5ab5a8801e
Merge pull request #556 from mcarton/or_fun_call
...
New lint, new utility functions and nightly fix
2016-01-18 18:57:35 +05:30
mcarton
8642306f09
Add a test for the OR_FUN_CALL lint
2016-01-18 13:36:58 +01:00
mcarton
21ba315102
Update to rustc 1.7.0-nightly ( d0bac3f14 2016-01-18)
2016-01-18 13:27:42 +01:00
mcarton
b5f65ec699
Improve OR_FUN_CALL to suggest unwrap_or_default
2016-01-18 13:11:07 +01:00
Florian Hartwig
7e85db645e
Fix another false positive in lifetime elision lint
...
The false positive occurred when we have an anonymous input lifetime and a
named output lifetime. This is not elidable, because if we elided the output
lifetime, it would be inferred to be the same as the input.
2016-01-17 17:53:41 +01:00
mcarton
c6604bb281
Add a lint to warn about call to .*or(foo(..))
2016-01-16 18:47:45 +01:00
llogiq
840d87022e
Merge pull request #523 from sanxiyn/escape-arg
...
Extend escape analysis to arguments
2016-01-16 00:03:58 +01:00
llogiq
da8a788b77
Merge pull request #551 from fhartwig/unused-lifetimes-fix
...
Consider lifetime in self parameter in unused_lifetime lint
2016-01-16 00:02:08 +01:00
mcarton
e6b905d925
Add a test for #398
2016-01-14 21:04:56 +01:00
mcarton
387e0991e3
Handle more iterator adapter cases in for loops
2016-01-14 20:58:32 +01:00
Florian Hartwig
7499f3c7a9
Consider lifetime in self paramter in unused_lifetime lint
2016-01-14 19:27:24 +01:00
mcarton
c2444c6043
Lint about else { if .. } with useless braces
2016-01-13 18:32:55 +01:00
mcarton
6fa9bf64d7
Use span_suggestion in ENTRY lint
2016-01-13 17:27:49 +01:00
mcarton
09129c1b41
Add BTreeMap to the HASHMAP_ENTRY rule
...
Fixes #433
2016-01-13 17:27:36 +01:00
mcarton
9f641a1009
Add known enums to SINGLE_MATCH
2016-01-13 01:19:27 +01:00
llogiq
37707b5a34
added semver lint
2016-01-09 02:05:43 +01:00
mcarton
9945bd82a8
Add better error messages for HashMapLint
2016-01-03 17:19:49 +01:00
mcarton
d0bb71e6a2
Finish the HashMapLint
2016-01-03 17:04:08 +01:00
mcarton
0c6e385493
Implement a HashMapLint
2016-01-03 17:04:08 +01:00
Manish Goregaokar
4484448cd1
Merge branch 'pr-538'
...
Conflicts:
README.md
2016-01-03 21:26:04 +05:30
mcarton
bb59717915
Remove x rights on a test file
2016-01-03 14:49:59 +01:00
Guillaume Gomez
abfb1d3ca1
Add new lint on function naming check (the '_')
2016-01-03 14:48:54 +01:00
mcarton
52fbf1989d
Add missing WRONG_PUB_SELF_CONVENTION in lint_array! and corresponding test
2016-01-03 14:42:24 +01:00
Manish Goregaokar
e3ab0fb6e7
Merge pull request #537 from GuillaumeGomez/fields_test
...
Add test for wild fields
2016-01-03 03:55:57 +05:30
Guillaume Gomez
4b9912c2b0
Add test for wild fields
2016-01-02 23:21:59 +01:00
mcarton
542685dad1
Merge branch 'master' of https://github.com/Manishearth/rust-clippy into #471
2016-01-02 19:36:45 +01:00
Manish Goregaokar
d8d3ee907b
Add macro check for box vec ( fixes #529 )
2016-01-02 21:49:53 +05:30
Manish Goregaokar
a745efd566
Add smarter macro check for block_in_if ( fixes #528 )
2016-01-02 21:41:53 +05:30
Manish Goregaokar
1605ef6ed4
Rustup to syntax::errors changes
2016-01-02 16:10:15 +05:30
Devon Hollowood
093582c102
Make MethodsPass lint notes clearer
2015-12-30 01:07:40 -08:00
Devon Hollowood
a6bd2d0622
Add SEARCH_IS_SOME lint
2015-12-30 00:38:03 -08:00
Devon Hollowood
bbd439ec9e
Add FILTER_NEXT lint
2015-12-28 16:56:58 -08:00
Seo Sanghyeon
07830c44af
Extend escape analysis to arguments
2015-12-28 23:12:57 +09:00
mcarton
592ca26e90
Fix #518
2015-12-23 22:37:52 +01:00
mcarton
0fa8481ba3
Put tests in tests folder
2015-12-23 17:48:41 +01:00
mcarton
d01987a40b
Include error message in tests
2015-12-23 11:26:35 +01:00
mcarton
3373ea43c0
Consider literal patterns in MATCH_OVERLAPPING_ARM
2015-12-23 02:42:01 +01:00
mcarton
7216e83189
Implement #471
2015-12-23 02:42:01 +01:00
Florian Hartwig
e4fbeb4947
Don't trigger block_in_if_condition_expr lint if the block is unsafe
2015-12-23 02:12:08 +01:00
mcarton
3abdcd4709
Implement #364
2015-12-21 19:36:58 +01:00
Devon Hollowood
b6766a0dcf
Add RustcEncodable test
2015-12-21 01:40:19 -08:00
Devon Hollowood
b190aa7deb
Implement #507
...
Make `used_underscore_binding` lint compatible with MacroAttributes
expansions. TODO: Add a good test for this.
2015-12-21 01:03:12 -08:00
Manish Goregaokar
4a32445aa7
Add macro check to used_underscore
2015-12-20 04:53:29 +05:30
Manish Goregaokar
9dca15de3e
Merge pull request #499 from devonhollowood/underscore_binding
...
Add used_underscore_binding lint
2015-12-19 19:02:06 +05:30
Devon Hollowood
bd82c082cb
Add test for struct fields
2015-12-18 16:29:22 -08:00
Devon Hollowood
98d21f9fc5
Make compatible with unused_variables lint
2015-12-18 16:04:33 -08:00
Devon Hollowood
c8d78a70b3
Test that we do not lint for multiple underscores
2015-12-18 13:47:12 -08:00
Devon Hollowood
3533d3a223
Add more tests
2015-12-18 00:57:09 -08:00
Manish Goregaokar
b900e88910
Merge pull request #494 from sanxiyn/suggestion-2
...
Use suggestion for needless_return
2015-12-17 22:17:32 +05:30
Devon Hollowood
e620a1d57c
Make suggested changes
2015-12-16 17:28:26 -08:00
Oliver Schneider
902c7d832b
fix cc computation in the presence of diverging calls
...
CFG treats diverging calls as its completely own path out of the function.
While this makes sense, it should also mean that a panic should increase the cyclomatic
complexity. Instead it decreases it.
Minimal example:
```rust
if a {
b
} else {
panic!("cake");
}
d
```
creates the following graph
```dot
digraph G {
"if a" -> "b"
"if a" -> "panic!(\"cake\")"
"b" -> c
}
```
which has a CC of 1 (3 - 4 + 2). A CC of 1 means there is one path through the program.
Obviously that is wrong. There are two paths. One returning normally, and one panicking.
2015-12-14 14:29:20 +01:00
Devon Hollowood
92fba6bd2c
Make clippy tests compatible with new lint
2015-12-12 21:39:10 -08:00
Devon Hollowood
6091112698
Update tests
2015-12-12 21:39:10 -08:00
Devon Hollowood
6482840bc5
Add tests
2015-12-12 21:39:10 -08:00
Seo Sanghyeon
974ab43453
Use suggestion for needless_return
2015-12-11 16:28:05 +09:00
Manish Goregaokar
b9546599e3
Check for unused lifetimes in bounds ( fixes #489 )
2015-12-10 12:02:59 -05:00
Manish Goregaokar
b865e30b49
Upgrade rust to rustc 1.6.0-nightly ( 462ec0576 2015-12-09)
2015-12-09 15:56:49 -05:00
Seo Sanghyeon
35b5c3efdd
Use suggestion for redundant_closure
2015-12-08 15:03:01 +09:00
Manish Goregaokar
c7b87a06d2
Add lint for unused lifetimes ( fixes #459 )
2015-12-07 06:55:14 -05:00
Manish Goregaokar
c4e9982dd7
Merge pull request #481 from fhartwig/lifetime-with-alias
...
Make unneeded_lifetimes lint work properly with type aliases
2015-12-06 09:08:40 +05:30
Florian Hartwig
62db392730
Make lifetimes lint work with type aliases and non-locally-defined structs
2015-12-06 02:04:13 +01:00
Robert Clipsham
978c41584f
Fix clippy with latest Rust nightly.
2015-12-05 12:33:58 +00:00
Manish Goregaokar
18e81c1b59
Rudimentary escape analysis for Box<T>
2015-12-04 20:23:14 +05:30
Oliver Schneider
3d1b7e1957
high-speed-dogfood
2015-12-03 16:41:55 +01:00
Oliver Schneider
617c820e6b
compute cyclomatic complexity (adjusted to not punish Rust's match)
2015-12-03 16:41:55 +01:00
Manish Goregaokar
409c0f0998
Merge pull request #468 from devonhollowood/option-methods
...
Lint `map(f).unwrap_or(a)` and `map(f).unwrap_or_else(g)`
2015-11-26 14:22:27 +05:30
Devon Hollowood
443e4556c2
Add lints suggesting map_or() and map_or_else()
...
In accordance with the latter lint, replace map().unwrap_or_else() in
src/mut_mut.rs with map_or_else()
2015-11-25 23:56:45 -08:00
