Commit Graph

110109 Commits

Author SHA1 Message Date
Mazdak Farrokhzad
7944f39b5f
Rollup merge of #70939 - varkor:const-generics-regression-tests, r=Centril
Add two const generics regression tests

Closes https://github.com/rust-lang/rust/issues/66596.
Closes https://github.com/rust-lang/rust/issues/61522.
2020-04-09 18:17:20 +02:00
Mazdak Farrokhzad
cb68d6e389
Rollup merge of #70902 - flip1995:clippyup, r=eddyb
Update Clippy

Closes #70875
2020-04-09 18:17:19 +02:00
Mazdak Farrokhzad
15a7ad2804
Rollup merge of #70900 - ehuss:update-cargo, r=ehuss
Update cargo

4 commits in 6e07d2dfb7fc87b1c9489de41da4dafa239daf03..390e8f245ef2cd7ac698b8a76abf029f9abcab0d
2020-03-31 03:22:39 +0000 to 2020-04-07 17:46:45 +0000
- Compatibility for rust-lang/rust#69926 (rust-lang/cargo#8080)
- Add note about converting triple case in environment variables (rust-lang/cargo#8079)
- Add support for `-Cembed-bitcode=no` (rust-lang/cargo#8066)
- Add triagebot configuration (rust-lang/cargo#8059)
2020-04-09 18:17:17 +02:00
Mazdak Farrokhzad
eecfd195cb
Rollup merge of #70897 - RalfJung:miri, r=RalfJung
bump Miri

r? @ghost Cc @rust-lang/miri

Fixes https://github.com/rust-lang/rust/issues/70894
2020-04-09 18:17:15 +02:00
Amanieu d'Antras
7060a9e683 Disable try_reserve tests on Android 2020-04-09 15:55:12 +01:00
Oliver Scherer
8a03147f22 Normalize MIR locals' types for generator layout computation. 2020-04-09 16:48:36 +02:00
mark
f2e4709f22 improve comments 2020-04-09 09:31:52 -05:00
Guillaume Gomez
44daa4521a Clean up E0511 explanation 2020-04-09 13:48:11 +02:00
varkor
0f0252260c Add regression test for #61522 2020-04-09 11:53:28 +01:00
varkor
61cc8925b2 Add regression test for #66596 2020-04-09 11:52:52 +01:00
bors
93dc97a853 Auto merge of #70943 - Centril:rollup-eowm2h3, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #67705 (Use unrolled loop for searching NULL in [u16] on Windows)
 - #70367 (save/restore `pessimistic_yield` when entering bodies)
 - #70822 (Don't lint for self-recursion when the function can diverge)
 - #70868 (rustc_codegen_ssa: Refactor construction of linker arguments)
 - #70896 (Implement Chain with Option fuses)
 - #70916 (Support `#[track_caller]` on functions in `extern "Rust" { ... }`)
 - #70918 (rustc_session: forbid lints override regardless of position)

Failed merges:

r? @ghost
2020-04-09 09:57:17 +00:00
mark
e1c838d737 de-abuse TyKind::Error: ice on missing slice type 2020-04-08 23:41:54 -05:00
mark
f9a691faac de-abuse TyKind::Error: handle empty slices in array patterns 2020-04-08 22:54:36 -05:00
Mazdak Farrokhzad
09052a6d35
Rollup merge of #70918 - tobithiel:fix_forbid_override, r=davidtwco
rustc_session: forbid lints override regardless of position

Addresses the regression reported in #70819 for command line arguments, but does not address the source code flag regression.
2020-04-09 05:29:47 +02:00
Mazdak Farrokhzad
4f00396f14
Rollup merge of #70916 - Centril:track-caller-ffi, r=eddyb
Support `#[track_caller]` on functions in `extern "Rust" { ... }`

Fixes https://github.com/rust-lang/rust/issues/70830 which is the follow-up to @eddyb's suggestion in https://github.com/rust-lang/rust/pull/69251#discussion_r380791634 to allow `#[track_caller]` on `fn`s in FFI imports, that is, on functions in `extern "Rust" { ... }` blocks.

This requires that the other side, the FFI export, also have the `#[track_caller]` attribute. Otherwise, undefined behavior is triggered and the blame lies, as usual, with the `unsafe { ... }` block which called the FFI imported function.

After this PR, all forms of `fn` items with the right ABI (`"Rust"`) support `#[track_caller]`.

As a drive-by, the PR also hardens the check rejecting `#[naked] #[track_caller]` such that methods and other forms of `fn` items are also considered.

r? @eddyb
cc @rust-lang/lang
2020-04-09 05:29:45 +02:00
Mazdak Farrokhzad
ecc4e2a647
Rollup merge of #70896 - cuviper:optional-chain, r=scottmcm
Implement Chain with Option fuses

The iterators are now "fused" with `Option` so we don't need separate state to track which part is already exhausted, and we may also get niche layout for `None`. We don't use the real `Fuse` adapter because its specialization for `FusedIterator` unconditionally descends into the iterator, and that could be expensive to keep revisiting stuff like nested chains. It also hurts compiler performance to add more iterator layers to `Chain`.

This change was inspired by the [proposal](https://internals.rust-lang.org/t/proposal-implement-iter-chain-using-fuse/12006) on the internals forum. This is an alternate to #70332, directly employing some of the same `Fuse` optimizations as #70366 and #70750.

r? @scottmcm
2020-04-09 05:29:43 +02:00
Mazdak Farrokhzad
cefee7bd9a
Rollup merge of #70868 - petrochenkov:linkorder, r=nagisa,mati865
rustc_codegen_ssa: Refactor construction of linker arguments

And add comments.

This PR doesn't reorder any linker arguments and therefore shouldn't contain any observable changes.

The next goal here is to
- Factor out order-independent linker arguments in the compiler code and in target specifications and pass them together. Such arguments generally apply to the whole linking session or the produced linking result rather to individual object files or libraries.
- Figure out where exactly among the remaining order-dependent arguments we should place customization points like `-C link-args` and `-Z pre-link-args`.
- Possibly provide command line opt-outs for options that are currently passed unconditionally (like CRT objects or arguments defined by the target spec).
- Document and stabilize the customization points that are not yet stable (https://github.com/rust-lang/rust/pull/70505).
2020-04-09 05:29:42 +02:00
Mazdak Farrokhzad
a209b4f447
Rollup merge of #70822 - jonas-schievink:curse-of-the-recursion, r=ecstatic-morse
Don't lint for self-recursion when the function can diverge

Fixes https://github.com/rust-lang/rust/issues/54444
2020-04-09 05:29:40 +02:00
Mazdak Farrokhzad
ba50bc588e
Rollup merge of #70367 - nikomatsakis:issue-69307, r=Aaron1011
save/restore `pessimistic_yield` when entering bodies

This flag is used to make the execution order around `+=` operators
pessimistic. Failure to save/restore the flag was causing independent
async blocks to effect one another, leading to strange ICEs and failed
assumptions.

Fixes #69307

r? @Zoxc
2020-04-09 05:29:38 +02:00
Mazdak Farrokhzad
e89cb0733a
Rollup merge of #67705 - lzutao:wmemchr, r=wesleywiser
Use unrolled loop for searching NULL in [u16] on Windows
2020-04-09 05:29:36 +02:00
bors
11f6096a9e Auto merge of #70860 - lcnr:has_local_value, r=nikomatsakis
remove `KEEP_IN_LOCAL_TCX` flag

closes #70285

I did not rename `needs_infer` here as this complex enough as is.
Will probably open a followup for that.

r? @eddyb
2020-04-09 03:28:16 +00:00
Mazdak Farrokhzad
45589b52fe track_caller: support on FFI imports 2020-04-09 04:55:05 +02:00
bors
d249d75637 Auto merge of #70936 - Dylan-DPC:rollup-2ng3e5h, r=Dylan-DPC
Rollup of 7 pull requests

Successful merges:

 - #70134 (add basic support of OsStrExt for HermitCore)
 - #70565 (Add inline attributes for functions used in the query system)
 - #70828 (rustdoc: Don't try to load source files from external crates)
 - #70870 (Fix abuses of tykind::err)
 - #70906 (Suggest move for closures and async blocks in more cases.)
 - #70912 (Do not suggest adding type param when `use` is already suggested)
 - #70930 (add tracking issue to `VecDeque::make_contiguous`)

Failed merges:

r? @ghost
2020-04-09 00:11:27 +00:00
Mateusz Mikuła
b9d9689e78 Fix staticlib name for *-pc-windows-gnu targets 2020-04-09 00:33:05 +02:00
Esteban Küber
d605a9d969 Small tweaks to required bound span 2020-04-08 14:40:51 -07:00
Esteban Küber
bd7ea5441e Use PredicateObligations instead of Predicates
Keep more information about trait binding failures.
2020-04-08 14:40:45 -07:00
Bastian Kauschke
fca7d165be do_normalize_predicates: add delay_span_bug 2020-04-08 23:34:09 +02:00
Bastian Kauschke
03d66a06e4 replace has_local_value with needs_infer 2020-04-08 23:34:09 +02:00
Dylan DPC
5848209b64
Rollup merge of #70930 - lcnr:patch-1, r=Dylan-DPC
add tracking issue to `VecDeque::make_contiguous`

The tracking issue is https://github.com/rust-lang/rust/issues/70929
2020-04-08 23:33:48 +02:00
Dylan DPC
268f09f9e6
Rollup merge of #70912 - estebank:reduce-type-param-sugg-verbosity, r=davidtwco
Do not suggest adding type param when `use` is already suggested

Fix #70365, cc #70572.
2020-04-08 23:33:46 +02:00
Dylan DPC
6f8fc4d656
Rollup merge of #70906 - gizmondo:66107, r=estebank
Suggest move for closures and async blocks in more cases.

Fixes #66107, also improves #67577
Related PR https://github.com/rust-lang/rust/pull/65166
2020-04-08 23:33:45 +02:00
Dylan DPC
d0c88396e7
Rollup merge of #70870 - mark-i-m:de-abuse-err, r=eddyb
Fix abuses of tykind::err

r? @eddyb

cc https://github.com/rust-lang/rust/issues/70866
2020-04-08 23:33:43 +02:00
Dylan DPC
1758b7caf6
Rollup merge of #70828 - ollie27:rustdoc_external_macro_src, r=eddyb
rustdoc: Don't try to load source files from external crates

Local items defined in external macros shouldn't generate rendered source files and should link to the external crate's docs instead.

Part of #70757

r? @GuillaumeGomez
cc @eddyb
2020-04-08 23:33:42 +02:00
Dylan DPC
3cae0e479e
Rollup merge of #70565 - Zoxc:inlines-query-system, r=davidtwco
Add inline attributes for functions used in the query system
2020-04-08 23:33:40 +02:00
Dylan DPC
cf0432a5f5
Rollup merge of #70134 - hermitcore:osstrext, r=dtolnay
add basic support of OsStrExt for HermitCore

- this patch increases the compatibility to other operating systems
- in principle `ffi.rs` is derived from `src/libstd/sys/unix/ext/ffi.rs`
2020-04-08 23:33:38 +02:00
Bastian Kauschke
969c145f96 don't set HAS_INFER for fresh types 2020-04-08 23:33:36 +02:00
bors
1edcfc83c6 Auto merge of #70721 - anyska:bless-all-mir-opt, r=oli-obk
--bless all mir-opt tests.

r? @oli-obk
2020-04-08 21:06:49 +00:00
Ana-Maria Mihalache
82d6e07c86 Add ignore-wasm32-bare to mir-opt tests that need it. 2020-04-08 18:58:49 +00:00
bors
485c5fb6e1 Auto merge of #70931 - Dylan-DPC:rollup-f8orcao, r=Dylan-DPC
Rollup of 9 pull requests

Successful merges:

 - #70789 (remove false positives of unused_braces)
 - #70847 (ci: move /var/lib/docker to /mnt on GHA)
 - #70850 (BTreeMap first last proposal tweaks)
 - #70876 (Use a `SmallVec` for `Cache::predecessors`.)
 - #70883 (Clean up E0507 explanation)
 - #70892 (wf: refactor `compute_trait_ref`)
 - #70914 (Corrects a typo in rustdoc documentation.)
 - #70915 (Remove unnecessary TypeFlags::NOMINAL_FLAGS)
 - #70927 (Clean up E0510 explanation)

Failed merges:

r? @ghost
2020-04-08 17:55:45 +00:00
mark
0d9bf52cc8 update rusct-dev-guide 2020-04-08 12:53:12 -05:00
Oliver Middleton
6f96dc221c rustdoc: Don't try to load source files from external crates
Local items defined in external macros shouldn't generate rendered source files and should link to the external crate's docs instead.
2020-04-08 18:35:17 +01:00
Dylan DPC
1498da87c2
Rollup merge of #70927 - GuillaumeGomez:cleanup-e0510, r=Dylan-DPC
Clean up E0510 explanation

r? @Dylan-DPC
2020-04-08 18:37:31 +02:00
Dylan DPC
bad8f0bd97
Rollup merge of #70915 - tsandstr:remove-nominal-flags, r=eddyb
Remove unnecessary TypeFlags::NOMINAL_FLAGS

This was a relic from when we had "nominal flags" and "cached
properties." The latter no longer exists, so nominal flags are no
longer necessary. In fact, every flag is considered a nominal flag. I
went ahead and removed all references to NOMINAL_FLAGS.

Fixes rust-lang#70836
2020-04-08 18:37:30 +02:00
Dylan DPC
9a84771a23
Rollup merge of #70914 - tsandstr:typo1, r=Dylan-DPC
Corrects a typo in rustdoc documentation.

Fixes rust-lang#70856

Sorry, I am just learning git and I think I may have accidentally done some wacky stuff that closed my last PR. Here it is again.
2020-04-08 18:37:28 +02:00
Dylan DPC
e3346e5b95
Rollup merge of #70892 - lcnr:interators_are_nice, r=nikomatsakis
wf: refactor `compute_trait_ref`

moves `extend_cause_with_original_assoc_item_obligation` out of `compute_trait_ref` and
changes `trait_assoc_items` to an iterator. This saves us from building an unnecessary `Vec<_>`

r? @eddyb i guess
2020-04-08 18:37:27 +02:00
Dylan DPC
66966667b5
Rollup merge of #70883 - GuillaumeGomez:cleanup-e0507, r=Dylan-DPC
Clean up E0507 explanation

r? @Dylan-DPC
2020-04-08 18:37:25 +02:00
Dylan DPC
e97a6e7bdc
Rollup merge of #70876 - nnethercote:smallvec-predecessors, r=estebank
Use a `SmallVec` for `Cache::predecessors`.

This is a very small win.
2020-04-08 18:37:24 +02:00
Dylan DPC
b9bb12640e
Rollup merge of #70850 - ssomers:btreemap_first_last, r=Amanieu
BTreeMap first last proposal tweaks

Clean-up and following up on a request in #62924.

Trying the reviewer of the original code #65637...
r? @scottmcm
2020-04-08 18:37:22 +02:00
Dylan DPC
54abd4ffcf
Rollup merge of #70847 - pietroalbini:ci-move-docker-lib, r=Mark-Simulacrum
ci: move /var/lib/docker to /mnt on GHA

There are some builders that are running out of disk space while building the Docker images, such as arm-android. This moves and symlinks `/var/lib/docker` to the `/mnt` partition on Linux GHA.

Example of a build failing because of this: https://github.com/rust-lang-ci/rust/runs/564628621
2020-04-08 18:37:18 +02:00
Dylan DPC
956e50bce1
Rollup merge of #70789 - lcnr:macros, r=varkor
remove false positives of unused_braces

fixes #70717

We could potentially be more aggressive when linting let bindings by checking if there are any explicit `ref`s.
I have been unable to create a snippet which compiles when using braces but has a borrowck error
without them. The closes I've gotten is [the following (playground)](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4a1552ebe9648cb13fcb8dd969189a6c).

r? @eddyb
2020-04-08 18:37:16 +02:00