Commit Graph

92 Commits

Author SHA1 Message Date
Matthew Walinga 9a4287d263
Update CONTRIBUTING.md 2018-01-18 18:05:33 -05:00
kennytm d7488c3089
Update CONTRIBUTING.md now that toolstate.toml is gone. 2017-12-27 00:00:45 +08:00
Ariel Ben-Yehuda f68e11b440 A few small improvements to the contributing docs 2017-12-20 22:18:13 +02:00
Timo 38ef72306f
Update old link
This page currently links to an old wiki page in rust-lang/rust-wiki-backup. There is a more up-to-date page in-tree so I changed the link to point there so new contributors can find it more easily.
2017-12-04 11:35:08 -05:00
Martin Lindhe ece9a57d1b fix some typos 2017-11-21 15:33:45 +01:00
kennytm 578016b8b5 Rollup merge of #45098 - sunjay:breakingrustfmtrls, r=alexcrichton
Documenting the process for when rustfmt/rls break

**DO NOT MERGE YET**

I'm documenting what to do when rustfmt or rls break because of your changes. I'm currently going through this and will keep adding more as I figure out what all the steps are. This first commit is based on @alexcrichton's [comment on my original PR](https://github.com/rust-lang/rust/pull/44766#issuecomment-332653525).

[Rendered](https://github.com/sunjay/rust/blob/breakingrustfmtrls/CONTRIBUTING.md#breaking-tools-built-with-the-compiler)

Reviews are welcome, but as I mentioned, I will be revising this as I go.
2017-10-19 01:59:47 +08:00
Sunjay Varma 790604adad Updating the instructions for when a tool breaks to use the new toolstate feature 2017-10-17 23:05:45 -04:00
Sunjay Varma 3f90c3a2cf Added a section about updating submodules
The process for updating rustfmt is quite involved because of the way everything is configured. This section covers the steps for updating rustfmt and rationale behind them.
2017-10-17 23:05:45 -04:00
Sunjay Varma bd4907d534 Documenting the process for when rustfmt/rls breakk because of your changes 2017-10-17 23:05:45 -04:00
Niko Matsakis 09caa12a51 add some tips to CONTRIBUTING.md to help with debugging this problem 2017-10-16 17:32:22 -04:00
kennytm 856a12d03e Rollup merge of #44997 - SuriyaaKudoIsc:patch-1, r=steveklabnik
Use HTTPS protocol for "chat.mibbit.com"

I changed the `http://` protocol to `https://` for the `chat.mibbit.com` website. 📝

--[**Suriyaa**](https://mozillians.org/de/u/suriyaakudo/) 🦊

(*PS: Is somebody interested to vouch me at https://mozillians.org/de/u/suriyaakudo/?*)
2017-10-05 20:22:35 +08:00
kennytm 3a037f113c Rollup merge of #44935 - vitiral:dependencies, r=steveklabnik
Add links to headers in README and CONTRIBUTING

this also adds dependencies to CONTRIBUTING

I'm just getting started building the rust compiler and noticed this information/ability was missing.

It was also missing the gdb dependency for running tests. I pulled the information out of `appveyor.yml` and recommended later than 7.1 because that is what [apt ships](https://packages.ubuntu.com/search?suite=trusty&keywords=gdb). Feel free to tell me something different!
2017-10-05 20:22:30 +08:00
Suriyaa ✌️️ 2d108ec00b Use HTTPS protocol for `chat.mibbit.com` 2017-10-03 12:36:16 +02:00
Michal Budzynski e6c3c7f2dc Corrected the CONTRIBUTING.md "External Dependencies" section 2017-10-02 00:18:19 +02:00
Garrett Berg daf3ed5651 Add links to headers in README and CONTRIBUTING and dependencies to CONTRIBUTING 2017-09-29 17:44:55 -06:00
Corey Farwell bbd8ac59fa Rollup merge of #44776 - spastorino:add_forge, r=nikomatsakis
Link to Rust forge from CONTRIBUTING.md
2017-09-23 00:29:22 -04:00
Niko Matsakis 9276b8b9b8 expand text, make link to forge more prominent 2017-09-22 16:27:55 -04:00
Santiago Pastorino 84dfade3cc Link to Rust forge from CONTRIBUTING.md 2017-09-22 17:16:03 -03:00
Oliver Schneider d64a067423
Add clippy to `toolstate.toml` 2017-09-19 09:20:35 +02:00
Carol (Nichols || Goulding) 28fc93fc43 Add explanations for undocumented labels 2017-09-10 13:31:08 -04:00
Carol (Nichols || Goulding) 69b949455d Alphabetize current label explanations
So that you can scroll down the list of labels along with these
explanations.
2017-09-10 13:21:37 -04:00
bors 088216fb99 Auto merge of #44194 - QuietMisdreavus:hey-how-do-i-use-this-new-fangled-thing, r=aturon
expand on using rustup custom toolchains in CONTRIBUTING.md

fixes #42484

Should i include more notes about how to use a local build *without* rustup? It can kinda feel like a cop-out otherwise. Other means that come to mind are setting `$RUSTC` directly and fully installing it.

cc @rust-lang/docs
2017-09-04 10:33:53 +00:00
bors 204c0a47e7 Auto merge of #43886 - oli-obk:clippy, r=nrc
Add clippy as a submodule

~~This builds clippy as part of `./x.py build` (locally and in CI).~~

This allows building clippy with `./x.py build src/tools/clippy`

~~Needs https://github.com/nrc/dev-tools-team/issues/18#issuecomment-322456461 to be resolved before it can be merged.~~ Contributers can simply open a PR to clippy and point the submodule at the `pull/$pr_number/head` branch.

This does **not** build clippy or test the clippy test suite at all as per https://github.com/nrc/dev-tools-team/issues/18#issuecomment-321411418

r? @nrc

cc @Manishearth @llogiq @mcarton @alexcrichton
2017-09-02 17:17:14 +00:00
QuietMisdreavus 1615d3502c expand on using rustup custom toolchains in CONTRIBUTING.md
fixes #42484
2017-08-30 17:06:12 -05:00
Corey Farwell c7cd79b58f Fix broken homu link in CONTRIBUTING.md.
Fixes the docs aspect of https://github.com/rust-lang/rust/issues/43898.
2017-08-20 21:24:14 -04:00
Oliver Schneider 93a9183256 Update workflow to git oddities 2017-08-15 18:32:04 +02:00
Oliver Schneider f46777696c Fetch the pull request before checkout 2017-08-15 18:14:16 +02:00
Oliver Schneider 49fca85b19 Document the process of updating external dependencies 2017-08-15 18:06:10 +02:00
bors 0269acbb10 Auto merge of #43820 - sfackler:move-config-template, r=alexcrichton
Move config.toml.example to the root dir

It's way more discoverable here.

r? @alexcrichton
2017-08-12 16:48:31 +00:00
Tej Chajed a746129bdb
Update GitHub pull request documentation link 2017-08-12 12:34:49 +01:00
Steven Fackler 1126a85e87 Move config.toml.example to the root dir
It's way more discoverable here.
2017-08-11 22:24:25 -07:00
Sam Cappleman-Lynes c329311b54 Update merge queue link 2017-07-17 11:57:26 +01:00
Kornel 1297b2d952 Suggest rustup toolchain link 2017-07-06 12:26:34 +01:00
faso bf2e0c2fe1 Typo 2017-05-16 10:56:07 +03:00
lukaramu 7643ccd29c Split paragraph in CONTRIBUTING.md 2017-03-24 21:28:59 +01:00
lukaramu 3b0add459c Update CONTRIBUTING.md
Changed link to documentation issues from A-docs to T-doc as this has just been migrated.
Added a link to the documentation style guidelines.
2017-03-24 21:16:00 +01:00
CrazyMerlyn b5533d2953 Update link to COMPILER_TESTS.md in CONTRIBUTING.md 2017-03-07 23:13:31 +05:30
Josh Driver fb2d763eee Replace ./configure with config.toml in README.md and CONTRIBUTING.md 2017-02-28 21:40:00 +10:30
Glyne J. Gittens b3f61ce538 Removed a typo from CONTRIBUTING.md 2017-02-19 17:30:50 -05:00
Alex Crichton 77c3bfa742 std: Remove cfg(cargobuild) annotations
These are all now no longer needed that we've only got rustbuild in tree.
2017-02-06 08:42:54 -08:00
Seo Sanghyeon 8ed52ed27d Document --test-args for rustbuild 2016-12-14 01:31:48 +09:00
Alex Crichton 0e272de69f mk: Switch rustbuild to the default build system
This commit switches the default build system for Rust from the makefiles to
rustbuild. The rustbuild build system has been in development for almost a year
now and has become quite mature over time. This commit is an implementation of
the proposal on [internals] which slates deletion of the makefiles on
2016-01-02.

[internals]: https://internals.rust-lang.org/t/proposal-for-promoting-rustbuild-to-official-status/4368

This commit also updates various documentation in `README.md`,
`CONTRIBUTING.md`, `src/bootstrap/README.md`, and throughout the source code of
rustbuild itself.

Closes #37858
2016-12-07 00:30:23 -08:00
Cobrand 9d9c029a66 doc: Contributing.md: mention of `make tidy` 2016-09-03 12:51:16 +02:00
Amit Levy 4b6477f062 Minor type in CONTRIBUTING.md
A single missing article
2016-08-21 22:42:33 -04:00
flo-l 4e87986514 add documentation on howto build just rustc without libstd to the build system 2016-06-05 21:03:38 +02:00
Sebastian Thiel eface32e41 Add `make tips` as useful make target
By accident, I found the `make tips` target, which helped me to gain more insight on how to work with the system more quickly.
2016-05-26 10:08:45 +02:00
Florian Berger daa48a294f Fix link in contributing page 2016-04-15 22:28:32 +03:00
Emanuel Czirai e1d2eda7f3 allow RUST_BACKTRACE=0 to act as if unset
/# This is a combination of 16 commits.
/# The first commit's message is:
allow RUST_BACKTRACE=disabled to act as if unset

When RUST_BACKTRACE is set to "disabled" then this acts as if the env.
var is unset.

/# This is the 2nd commit message:

case insensitive "DiSaBLeD" RUST_BACKTRACE value

previously it expected a lowercase "disabled" to treat the env. var as
unset

/# This is the 3rd commit message:

RUST_BACKTRACE=0 acts as if unset

previously RUST_BACKTRACE=disabled was doing the same thing

/# This is the 4th commit message:

RUST_BACKTRACE=0|n|no|off acts as if unset

previously only RUST_BACKTRACE=0 acted as if RUST_BACKTRACE was unset
Now added more options (case-insensitive): 'n','no' and 'off'
eg. RUST_BACKTRACE=oFF

/# This is the 5th commit message:

DRY on the value of 2

DRY=don't repeat yourself
Because having to remember to keep the two places of '2' in sync is not
ideal, even though this is a simple enough case.

/# This is the 6th commit message:

Revert "DRY on the value of 2"

This reverts commit 95a0479d5cf72a2b2d9d21ec0bed2823ed213fef.

Nevermind this DRY on 2, because we already have a RY on 1,
besides the code is less readable this way...

/# This is the 7th commit message:

attempt to document unsetting RUST_BACKTRACE

/# This is the 8th commit message:

curb allocations when checking for RUST_BACKTRACE

this means we don't check for case-insensitivity anymore

/# This is the 9th commit message:

as decided, RUST_BACKTRACE=0 turns off backtrace

/# This is the 10th commit message:

RUST_TEST_NOCAPTURE=0 acts as if unset

(that is, capture is on)

Any other value acts as if nocapture is enabled (that is, capture is off)

/# This is the 11th commit message:

update other RUST_TEST_NOCAPTURE occurrences

apparently only one place needs updating

/# This is the 12th commit message:

update RUST_BACKTRACE in man page

/# This is the 13th commit message:

handle an occurrence of RUST_BACKTRACE

/# This is the 14th commit message:

ensure consistency with new rules for backtrace

/# This is the 15th commit message:

a more concise comment for RUST_TEST_NOCAPTURE

/# This is the 16th commit message:

update RUST_TEST_NOCAPTURE in man page
2016-03-31 23:02:59 +02:00
Florian Berger ccafdae9a1 Remove trailing whitespace at the end of lines 2016-03-22 19:31:39 +02:00
Ryan Thomas df31868cac Update TESTNAME description 2016-02-02 10:58:59 +11:00