Commit Graph

94107 Commits

Author SHA1 Message Date
Mazdak Farrokhzad 460e626a9c
Rollup merge of #61230 - matklad:ub-comment, r=RalfJung
avoid creating Boxes of uninitalized values in RawVec

`RawVec<bool>::into_box` is definitely instant UB, if not all values are initialized.

See https://gankro.github.io/blah/initialize-me-maybe/
2019-05-28 11:48:58 +02:00
Mazdak Farrokhzad c48835ba19
Rollup merge of #61227 - diwic:patch-2, r=Centril
Use .await syntax instead of await!

Tiny doc fix.
2019-05-28 11:48:56 +02:00
Mazdak Farrokhzad 3b5157917a
Rollup merge of #61220 - imbrem:error_explanations, r=estebank
Added error message for E0284

Work on #61137
2019-05-28 11:48:55 +02:00
Mazdak Farrokhzad 08f7724355
Rollup merge of #61084 - blkerby:unreachable_doc, r=KodrAus
Clarify docs for unreachable! macro

Fixes #60754.
2019-05-28 11:48:53 +02:00
Philipp Hansch 96e3fb255b
librustc_errors: Move annotation collection to own impl
Extracted from work on #59346. This moves the annotation collection to
the `FileWithAnnotatedLines` impl to allow re-use in a separate
EmitterWriter.
2019-05-28 08:34:44 +02:00
bors 837b72c805 Auto merge of #60955 - agnxy:rename-assoc, r=oli-obk,Centril
Rename "Associated*" to "Assoc*"

This change is for #60163.

r? @oli-obk
2019-05-28 05:28:13 +00:00
bors 87ed0b421d Auto merge of #61036 - michaelwoerister:pgo-xlto-test, r=alexcrichton
PGO - Add a smoketest for combining PGO with cross-language LTO.

This PR

- Adds a test making sure that PGO can be combined with cross-language LTO.
- Does a little cleanup on how the `pgo-use` flag is handled internally.
- Makes the compiler error if the `pgo-use` file given to `rustc` doesn't actually exist. LLVM only gives a warning and then just doesn't do PGO. Clang, on the other hand, does give an error in this case.
- Makes the build system also build `compiler-rt` when building LLDB. This way the Clang compiler that we get from building LLDB can perform PGO, which is something that the new test case wants to do. CI compile times shouldn't be affected too much.
2019-05-28 01:56:44 +00:00
Kristofer Rye e0f017da75
Fix an sh error
Didn't think it was this particular about things, but I also should
have tested locally.

It makes sense, though---`\` followed by LF would eat it, so we'd have
`sysroot done` instead of `sysroot; done` as it is parsed.  This should
pass now.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
2019-05-27 19:40:11 -05:00
Jad Ghalayini b3480126d4 Incorporated suggested changes 2019-05-27 19:37:20 -04:00
bors b71117947f Auto merge of #61078 - pietroalbini:nightly-next, r=Centril
Bump nightly to 1.37.0

r? @Mark-Simulacrum
2019-05-27 23:04:54 +00:00
Kristofer Rye 57cea25151
Remove now-dead case statement in print-target-list Makefile
Since this case statement no longer has any branches, remove it.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
2019-05-27 16:52:54 -05:00
Kristofer Rye 8de3ddf8d8
Remove *ios* case from print-target-list Makefile
Based on the TODO, this case was added to short-circuit for ios builds,
which is no longer necessary.

The comment in this Makefile mentions rust-lang/rust#29812 as a
dependency, but that issue has been since closed, with a statement that
the ICE of concern was resolved circa 1.12.

Here we remove this case, and just run the same branch for all targets.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
2019-05-27 16:44:16 -05:00
Santiago Pastorino 38ecea4c11 Use Place::local 2019-05-27 23:03:38 +02:00
Santiago Pastorino c3e71f210e Make eval_place iterate instead of recurse 2019-05-27 22:52:03 +02:00
Ralf Jung 645f685e1b Box::into_vec: use Box::into_raw instead of mem::forget 2019-05-27 22:40:28 +02:00
Santiago Pastorino fb4b62b87b Make check_place iterate instead of recurse 2019-05-27 22:17:42 +02:00
Santiago Pastorino b922e8a97d Make dest_needs_borrow iterate instead of recurse 2019-05-27 22:16:39 +02:00
bors e70d5386d7 Auto merge of #61140 - estebank:attr-diagnostics, r=michaelwoerister
Reword malformed attribute input diagnostics

- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser

Split up from https://github.com/rust-lang/rust/pull/61026, where there's prior conversation.
2019-05-27 20:12:14 +00:00
Santiago Pastorino acaf284e55 Remove unused tcx and mir params 2019-05-27 21:46:15 +02:00
Aleksey Kladov fe31ad38cb
Update src/liballoc/boxed.rs
Co-Authored-By: Ralf Jung <post@ralfj.de>
2019-05-27 22:42:50 +03:00
Aleksey Kladov 0653e78ae1 make Box<str>::clone simpler & safer 2019-05-27 21:17:12 +03:00
bors fa40a111ff Auto merge of #60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
2019-05-27 15:36:32 +00:00
Michael Woerister 577ea539dc Only build clang_rt when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set. 2019-05-27 16:40:00 +02:00
Christian b560b9cd36 Updated the Iterator docs with information about overriding methods. 2019-05-27 16:17:39 +02:00
Lzu Tao 06eb412741 Stabilize bufreader_buffer feature 2019-05-27 13:42:21 +00:00
bors 1a56ec4dae Auto merge of #59627 - LooMaclin:issue_57128_improve_miri_error_reporting_in_check_in_alloc, r=RalfJung
Improve miri error reporting in check_in_alloc

Fixes https://github.com/rust-lang/rust/issues/57128

r? @RalfJung @oli-obk
2019-05-27 12:46:12 +00:00
Michael Woerister 48b9896eeb Fix unit test after pgo-use change. 2019-05-27 14:32:03 +02:00
Michael Woerister 1de93a7814 Add a smoketest for combining PGO with xLTO. 2019-05-27 14:32:03 +02:00
Michael Woerister 30a3fad316 rustbuild: Also build compiler-rt when building LLDB. This allows clang-based run-make tests to use PGO. 2019-05-27 14:32:03 +02:00
Michael Woerister eeb7348dc3 PGO: Check that pgo-use file actually exists. LLVM seems to only emit an easy-to-overlook warning otherwise. 2019-05-27 14:32:03 +02:00
Michael Woerister e943426045 Use a PathBuf instead of String for representing the pgo-use path internally. 2019-05-27 14:32:03 +02:00
Ralf Jung fe19ed8737 factor out some common code and make the on-elimination truncation test debug-only 2019-05-27 12:54:05 +02:00
Ralf Jung fe7b6a943d fix truncate and sign_extend for size == 0 2019-05-27 12:53:27 +02:00
Oliver Scherer d6ca34c9d2 Use `Symbol` more in lint APIs 2019-05-27 12:28:54 +02:00
Felix S. Klock II c8887abf20 Tests for external linkage symbol collision check.
Fix #61232
2019-05-27 12:10:58 +02:00
bors 4dbc7f96d6 Auto merge of #60967 - Zoxc:fix-syntax-sync, r=michaelwoerister
Short circuit Send and Sync impls for TokenTree

Workaround to make the parallel compiler build after https://github.com/rust-lang/rust/pull/60444.

r? @nikomatsakis
2019-05-27 09:49:18 +00:00
Felix S. Klock II 4e60f53280 Regression test for issue #59548. 2019-05-27 10:26:02 +02:00
Felix S. Klock II 444f2bae59 Refine the message to at least *mention* the attribute itself.
Update pre-existing test's diagnostic output accordingly.
2019-05-27 10:26:02 +02:00
Felix S. Klock II 64edaec6b3 Always supply span to check_and_apply_linkage, sidestepping need to add `bug!`s to rustc. 2019-05-27 10:26:02 +02:00
Felix S. Klock II 21aa149b0b Move existing `#[linkage]` tests to a subdirectory where I can add more tests. 2019-05-27 10:26:02 +02:00
Aleksey Kladov a23a77fb19 avoid materializing unintialized Boxes in RawVec 2019-05-27 11:15:31 +03:00
John Kåre Alsaker 3ed05613ee Short circuit Send and Sync impls for TokenTree 2019-05-27 08:58:05 +02:00
bors ab7cf71d4c Auto merge of #61035 - nnethercote:avoid-more-symbol-interning, r=petrochenkov
Avoid more symbol interning

r? @petrochenkov
2019-05-27 06:53:53 +00:00
diwic 5c5f08ab93
Use .await syntax instead of await! 2019-05-27 07:27:13 +02:00
Nicholas Nethercote 33a3206dc5 Use `Symbol` equality in `may_begin_with` and `parse_nt`. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote 15789a9773 Use `Symbol` equality in `check_ident_token`. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote 8ae01a9008 Use `Symbol` equality in `is_ident_named`. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote 303bf1509b Avoid some re-interning in `to_lit_token`. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote 21f28448e0 Add `to_symbol` methods. 2019-05-27 14:05:02 +10:00
bors be10e6277b Auto merge of #61215 - paoloteti:armebv7r, r=alexcrichton
Docker: remove environment variable `CC_armebv7r_none_eabi`

`cc-rs` take care of selecting the tool-chain, so this `ENV` variable can be safely removed.
2019-05-27 03:58:56 +00:00