a416c5e0f7
Auto merge of #3545 - Kampfkarren:vec_boxed_sized, r=flip1995
...
Adds lint for Vec<Box<T: Sized>>
This adds, and subsequently closes #3530 . This is the first time I've ever worked with anything remotely close to internal Rust code, so I'm very much unsure about the if_chain! to figure this out!
I can't get rustfmt working on WSL with nightly 2018-12-07:
`error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download`
2018-12-14 12:10:48 +00:00
d866f31678
rustup rust-lang/rust#52994
...
s/trim_left/trim_start/
s/trim_right/trim_end/
2018-12-14 12:35:44 +01:00
df73348354
Merge branch 'master' into fix-3514
2018-12-14 07:16:26 +02:00
985eba08a5
Line length fix
2018-12-13 10:46:21 -08:00
db00c3320f
Remove references to sized for end users
2018-12-13 10:18:17 -08:00
9fc914cf4d
Remove DUMMY_SP
2018-12-13 09:37:00 -08:00
616395f40b
Add suggestion for replacement
2018-12-13 09:34:16 -08:00
ab070508be
Lint for Vec<Box<T: Sized>> - Closes #3530
2018-12-13 07:43:13 -08:00
379c934f3f
Auto merge of #3535 - sinkuu:fixes, r=phansch
...
Fix some problems
Fixes #2892 , #3199 , #2841 , #3476
2018-12-12 19:17:09 +00:00
777c9099e7
Auto merge of #3510 - phansch:fix_doc_markdown_mixed_case, r=flip1995
...
Fix doc_markdown mixed case false positive
Fixes #2343
2018-12-12 18:36:38 +00:00
778723630c
Fix doc_markdown mixed case false positive
2018-12-12 19:25:27 +01:00
7c823cabab
Auto merge of #3450 - phansch:structured_sugg_for_explicit_write, r=flip1995
...
Add suggestion for explicit_write lint
Closes #2083
2018-12-12 18:11:13 +00:00
eba44e1c67
question_mark: Suggest Some(opt?) for if-else
2018-12-12 18:13:21 +09:00
eb54c1a9a0
redundant_field_names: Do not trigger on path with type params
...
Fixes #3476
2018-12-12 17:41:52 +09:00
28635ff04b
question_mark: Lint only early returns
2018-12-12 17:41:51 +09:00
05d07155b7
question_mark: Fix applicability
2018-12-12 17:40:25 +09:00
1cfbadb029
Fix doc_markdown off by one issue
2018-12-12 08:21:13 +01:00
bcbbb4d09b
new_without_default, partialeq_ne_impl: Use span_lint_node
...
Fixes #2892 , fixes #3199
2018-12-12 16:08:05 +09:00
499aad1e04
cargo fmt and remove stabilized feature
2018-12-12 07:31:04 +01:00
752724546a
Make suggestion Applicability::MachineApplicable
2018-12-12 07:31:04 +01:00
9a6216ed05
Address review feedback
...
* Fix typo
* Handle None value instead of using `unwrap()`
* `pop()` instead of `x.truncate(x.len() - 1)`
2018-12-12 07:31:04 +01:00
5f007a88b4
Extract method
2018-12-12 07:31:04 +01:00
7e7a33c726
Check array lengths to prevent OOB access
2018-12-12 07:31:04 +01:00
c4c9d9fc62
Add suggestion for explicit_write lint
2018-12-12 07:31:01 +01:00
ee2abc36a3
Add 'CamelCase' to doc_valid_idents
2018-12-11 19:37:43 +01:00
c6505aa160
Fix write_with_newline escaping false positive
...
Fixes #3514
2018-12-11 08:44:49 +02:00
0fd7fe9a77
Auto merge of #3511 - phansch:remove_allow_doc_markdown, r=phansch
...
Remove allow(doc_markdown) in excessive_precision.rs
Closes #3299
2018-12-10 19:21:25 +00:00
ada0b2b095
Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch
...
Lint redundant clone of fields
Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
2018-12-10 18:55:49 +00:00
e7d18084fb
Only check the assignment found at last
...
If there are more than one such assignment, the last one may be
the one supplied to `clone` method.
Makes `find_stmt_assigns_to` internally reverses the iterator to make
the intent to "iterate statements backward" clear.
2018-12-10 15:59:21 +09:00
fd9f5df36c
Add comment and rename
2018-12-10 15:48:34 +09:00
22f396a1c1
Apply redundant_clone on clippy
2018-12-10 08:48:14 +09:00
109d4b1ab3
Lint redundant clone of projection
2018-12-10 08:48:14 +09:00
273dc82872
run rustfmt
2018-12-09 12:03:10 +01:00
790e611c9c
Cleanup
2018-12-09 19:18:35 +09:00
fe3519e0dd
Swap if branches
2018-12-08 12:09:32 +01:00
d90cad24a1
Fix c_void false positive caused by libc refactoring
...
The path of `libc::c_void` has changes in 5c1a6b8a6d
2018-12-08 12:05:11 +01:00
f13d23de41
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
2018-12-08 12:05:09 +01:00
26602ddff4
Merge pull request #3336 from HMPerson1/clone_on_copy_deref
...
Fix `clone_on_copy` not detecting derefs sometimes
2018-12-08 09:59:02 +01:00
a73d051227
Remove allow(doc_markdown) in excessive_precision.rs
2018-12-07 22:47:12 +01:00
2fed8d9f1d
typo: emum → enum
2018-12-07 12:24:59 +01:00
45cbdf471d
rustup clippy build with latest rustc
...
(breakage due to 08f8faedd0Fixes #3500
2018-12-06 16:44:22 +01:00
c4ef06a9b6
Merge pull request #3497 from daxpedda/master
...
Fix bug in `implicit_return`.
2018-12-06 14:13:20 +01:00
a4ec7be06f
Forgot to remove some debugging code ...
2018-12-06 13:23:42 +01:00
d048e15835
Improved code noted by clippy.
2018-12-06 13:21:04 +01:00
973d676cd1
Fix bug in `implicit_return`.
...
Bug was already covered by test, but test was not checked for.
2018-12-06 12:22:54 +01:00
a8a0b236b5
fix #3482 and add ui test for it
2018-12-06 11:07:10 +01:00
f93591294d
Merge pull request #3494 from daxpedda/master
...
Added `IMPLICIT_RETURN` lint.
2018-12-06 07:12:01 +01:00
b0f3ed2b80
Added additional reasoning to `Why is this bad?`.
...
Added comment to explain usage of MIR.
2018-12-05 15:01:19 +01:00
aed2b986e6
Renamed to `implicit_return`.
...
Covered all other kinds besides `ExprKind::Lit`.
Added check for replacing `break` with `return`.
2018-12-05 14:39:09 +01:00
36ee92780d
Fix ty::TyKind usage
2018-12-05 12:47:19 +01:00
bors
flip1995
Michael Wright
Kampfkarren
Philipp Hansch
Shotaro Yamada
Shotaro Yamada
Matthias Krüger
Philipp A
daxpedda
Felix Kohlgrüber