Go to file
2018-12-28 20:54:29 +01:00
.github
ci tests: fix formatting and update test output 2018-12-27 17:03:53 +01:00
clippy_dev fix a couple of ftrivial typos (NFC). 2018-12-25 18:22:34 +01:00
clippy_dummy rust-lang-nursery/rust-clippy => rust-lang/rust-clippy 2018-11-22 04:40:09 +01:00
clippy_lints Fix suggestion for unnecessary_ref lint 2018-12-28 20:54:29 +01:00
clippy_workspace_tests
etc/relicense Fix some nursery links 2018-12-02 11:45:05 +01:00
mini-macro rust-lang-nursery/rust-clippy => rust-lang/rust-clippy 2018-11-22 04:40:09 +01:00
rustc_tools_util rustc_tools_util: add readme 2018-12-25 17:03:36 +01:00
src update CARGO_CLIPPY_HELP string to suggest tool lints. 2018-12-25 17:11:57 +01:00
tests Fix suggestion for unnecessary_ref lint 2018-12-28 20:54:29 +01:00
util rust-lang-nursery/rust-clippy => rust-lang/rust-clippy 2018-11-22 04:40:09 +01:00
.editorconfig
.gitattributes Enforce LF lineendings for everything 2018-12-02 11:05:39 +01:00
.gitignore
.remarkrc.json
.travis.yml Fix rvm/gpg bug in travis osx build 2018-12-12 15:37:31 +01:00
appveyor.yml ci: when installing rust-toolchain-installer-master, install it in debug mode to save some time in ci. 2018-10-31 11:18:20 +01:00
bors.toml
build.rs Run rustfmt on build.rs 2018-11-27 21:13:26 +01:00
Cargo.toml Use WIP branch for compiletest_rs 2018-12-28 20:53:01 +01:00
CHANGELOG.md Run update_lints after renaming 2018-12-17 14:33:05 +01:00
CODE_OF_CONDUCT.md Add missing code of conduct file 2018-11-01 21:31:05 +01:00
CONTRIBUTING.md Update CONTRIBUTING.md for rustfix tests 2018-12-28 20:53:44 +01:00
COPYRIGHT
LICENSE-APACHE
LICENSE-MIT
pre_publish.sh
publish.files
PUBLISH.md
README.md Auto merge of #3569 - phansch:update_contributing, r=flip1995 2018-12-22 09:18:39 +00:00
rust-toolchain
rustfmt.toml Error on line overflow 2018-11-27 20:46:11 +01:00

Clippy

Build Status Windows Build status Current Version License: MIT/Apache-2.0

A collection of lints to catch common mistakes and improve your Rust code.

There are 291 lints included in this crate!

We have a bunch of lint categories to allow you to choose how much Clippy is supposed to annoy help you:

  • clippy::all (everything that has no false positives)
  • clippy::pedantic (everything)
  • clippy::nursery (new lints that aren't quite ready yet)
  • clippy::style (code that should be written in a more idiomatic way)
  • clippy::complexity (code that does something simple but in a complex way)
  • clippy::perf (code that can be written in a faster way)
  • clippy::cargo (checks against the cargo manifest)
  • clippy::correctness (code that is just outright wrong or very very useless)

More to come, please file an issue if you have ideas!

Only the following of those categories are enabled by default:

  • clippy::style
  • clippy::correctness
  • clippy::complexity
  • clippy::perf

Other categories need to be enabled in order for their lints to be executed.

Table of contents:

Usage

Since this is a tool for helping the developer of a library or application write better code, it is recommended not to include Clippy as a hard dependency. Options include using it as an optional dependency, as a cargo subcommand, or as an included feature during build. These options are detailed below.

As a cargo subcommand (cargo clippy)

One way to use Clippy is by installing Clippy through rustup as a cargo subcommand.

Step 1: Install rustup

You can install rustup on supported platforms. This will help us install Clippy and its dependencies.

If you already have rustup installed, update to ensure you have the latest rustup and compiler:

rustup update

Step 2: Install Clippy

Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:

rustup component add clippy

Now you can run Clippy by invoking cargo clippy.

If it says that it can't find the clippy subcommand, please run rustup self update

Running Clippy from the command line without installing it

To have cargo compile your crate with Clippy without Clippy installation in your code, you can use:

RUSTFLAGS=--sysroot=`rustc --print sysroot` cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml

Note: Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!

Travis CI

You can add Clippy to Travis CI in the same way you use it locally:

language: rust
rust:
  - stable
  - beta
before_script:
  - rustup component add clippy
script:
  - cargo clippy
  # if you want the build job to fail when encountering warnings, use
  - cargo clippy -- -D warnings
  # in order to also check tests and none-default crate features, use
  - cargo clippy --all-targets --all-features -- -D warnings
  - cargo test
  # etc.

It might happen that Clippy is not available for a certain nightly release. In this case you can try to conditionally install Clippy from the git repo.

language: rust
rust:
  - nightly
before_script:
   - rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy
   # etc

Configuration

Some lints can be configured in a TOML file named clippy.toml or .clippy.toml. It contains a basic variable = value mapping eg.

blacklisted-names = ["toto", "tata", "titi"]
cyclomatic-complexity-threshold = 30

See the list of lints for more information about which lints can be configured and the meaning of the variables.

To deactivate the “for further information visit lint-link” message you can define the CLIPPY_DISABLE_DOCS_LINKS environment variable.

Allowing/denying lints

You can add options to your code to allow/warn/deny Clippy lints:

  • the whole set of Warn lints using the clippy lint group (#![deny(clippy::all)])

  • all lints using both the clippy and clippy::pedantic lint groups (#![deny(clippy::all)], #![deny(clippy::pedantic)]). Note that clippy::pedantic contains some very aggressive lints prone to false positives.

  • only some lints (#![deny(clippy::single_match, clippy::box_vec)], etc)

  • allow/warn/deny can be limited to a single function or module using #[allow(...)], etc

Note: deny produces errors instead of warnings.

If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to Clippy during the run: cargo clippy -- -A clippy::lint_name will run Clippy with lint_name disabled and cargo clippy -- -W clippy::lint_name will run it with that enabled. This also works with lint groups. For example you can run Clippy with warnings for all lints enabled: cargo clippy -- -W clippy::pedantic

Contributing

If you want to contribute to Clippy, you can find more information in CONTRIBUTING.md.

License

Copyright 2014-2018 The Rust Project Developers

Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option. All files in the project carrying such notice may not be copied, modified, or distributed except according to those terms.