OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
75ef735d4a
rust/compiler
History
Yuki Okushi 75ef735d4a
Rollup merge of #77855 - davidtwco:pr-77341-follow-up-non-constructable-variants, r=estebank 
resolve: further improvements to "try using the enum's variant" diagnostic

Follow-up on https://github.com/rust-lang/rust/pull/77341#issuecomment-702738281.

This PR improves the diagnostic modified in #77341 to suggest not only those variants which do not have fields, but those with fields (by suggesting with placeholders). In addition, the wording of the tuple-variant-only case is improved slightly.

I've not made further changes to the tuple-variant-only case (e.g. to only suggest variants with the correct number of fields) because I don't think I have enough information to do so reliably (e.g. in the case where there is an attempt to construct a tuple variant, I have no information on how many fields were provided; and in the case of pattern matching, I only have a slice of spans and would need to check for things like `..` in those spans, which doesn't seem worth it).

r? @estebank
2020-10-17 05:36:43 +09:00
..
rustc
rustc_apfloat Backport another LLVM commit to rustc_apfloat 2020-10-04 02:02:25 +02:00
rustc_arena Arena: Copy cold_path and remove rustc_data_structures dependency 2020-10-15 10:56:33 +02:00
rustc_ast Rollup merge of #77739 - est31:remove_unused_code, r=petrochenkov,varkor 2020-10-15 07:32:29 +09:00
rustc_ast_lowering Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_ast_passes Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_ast_pretty Auto merge of #77135 - Aaron1011:pretty-ignore-paren, r=petrochenkov 2020-10-14 00:26:50 +00:00
rustc_attr Move PartialOrd impl out of rustc 2020-10-11 11:11:33 -04:00
rustc_builtin_macros Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_codegen_llvm Auto merge of #77972 - Mark-Simulacrum:side-effect-loop, r=nagisa 2020-10-16 14:06:37 +00:00
rustc_codegen_ssa Auto merge of #77972 - Mark-Simulacrum:side-effect-loop, r=nagisa 2020-10-16 14:06:37 +00:00
rustc_data_structures Remove unused code from remaining compiler crates 2020-10-14 04:14:32 +02:00
rustc_driver Rollup merge of #77493 - hosseind88:ICEs_should_always_print_the_top_of_the_query_stack, r=oli-obk 2020-10-16 02:10:09 +02:00
rustc_error_codes Rollup merge of #76119 - Amjad50:stabilizing-move_ref_pattern, r=nikomatsakis 2020-10-16 02:10:07 +02:00
rustc_errors Remove unused code from remaining compiler crates 2020-10-14 04:14:32 +02:00
rustc_expand Remove unused code from remaining compiler crates 2020-10-14 04:14:32 +02:00
rustc_feature Rollup merge of #76119 - Amjad50:stabilizing-move_ref_pattern, r=nikomatsakis 2020-10-16 02:10:07 +02:00
rustc_fs_util Remove unused code from remaining compiler crates 2020-10-14 04:14:32 +02:00
rustc_graphviz /nightly/nightly-rustc 2020-09-23 21:51:56 +02:00
rustc_hir ensure arguments are included in count mismatch span 2020-10-15 10:22:39 -04:00
rustc_hir_pretty Rollup merge of #77739 - est31:remove_unused_code, r=petrochenkov,varkor 2020-10-15 07:32:29 +09:00
rustc_incremental /nightly/nightly-rustc 2020-09-23 21:51:56 +02:00
rustc_index
rustc_infer Remove unused code from rustc_infer 2020-10-14 04:14:32 +02:00
rustc_interface Rollup merge of #77795 - bjorn3:codegen_backend_interface_refactor, r=oli-obk 2020-10-14 02:30:38 +02:00
rustc_lexer Noticed a potential bug in eat_while(): it doesn't account for number of UTF8 bytes. 2020-10-09 11:12:54 +02:00
rustc_lint Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_llvm Auto merge of #76859 - Aaron1011:fix/llvm-cgu-reuse, r=davidtwco,nikic 2020-10-11 20:50:02 +00:00
rustc_macros Remove unused #[allow(...)] statements from compiler/ 2020-09-26 01:25:55 +02:00
rustc_metadata Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_middle Rollup merge of #77493 - hosseind88:ICEs_should_always_print_the_top_of_the_query_stack, r=oli-obk 2020-10-16 02:10:09 +02:00
rustc_mir Auto merge of #77947 - tmiasko:promoted-scope, r=oli-obk 2020-10-16 02:27:49 +00:00
rustc_mir_build Rollup merge of #76119 - Amjad50:stabilizing-move_ref_pattern, r=nikomatsakis 2020-10-16 02:10:07 +02:00
rustc_parse Rollup merge of #77780 - calebcartwright:cast-expr-attr-span, r=oli-obk 2020-10-16 02:10:22 +02:00
rustc_parse_format /nightly/nightly-rustc 2020-09-23 21:51:56 +02:00
rustc_passes stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union' 2020-10-16 11:33:33 +02:00
rustc_plugin_impl /nightly/nightly-rustc 2020-09-23 21:51:56 +02:00
rustc_privacy Separate bounds and predicates for associated/opaque types 2020-10-06 11:19:29 +01:00
rustc_query_system Remove unused code from rustc_query_system 2020-10-14 04:14:32 +02:00
rustc_resolve Rollup merge of #77855 - davidtwco:pr-77341-follow-up-non-constructable-variants, r=estebank 2020-10-17 05:36:43 +09:00
rustc_save_analysis /nightly/nightly-rustc 2020-09-23 21:51:56 +02:00
rustc_serialize Replace absolute paths with relative ones 2020-10-13 14:16:45 +02:00
rustc_session Remove rustc_session::config::Config 2020-10-15 12:02:24 +02:00
rustc_span Rollup merge of #77739 - est31:remove_unused_code, r=petrochenkov,varkor 2020-10-15 07:32:29 +09:00
rustc_symbol_mangling Rollup merge of #75675 - davidtwco:symbol-mangling-impl-params, r=eddyb 2020-10-16 02:10:02 +02:00
rustc_target Replace target.target with target and target.ptr_width with target.pointer_width 2020-10-15 12:02:24 +02:00
rustc_trait_selection Auto merge of #77873 - sexxi-goose:use_tuple_inference_for_closures, r=nikomatsakis 2020-10-15 04:17:10 +00:00
rustc_traits Address comments 2020-10-14 00:17:42 -04:00
rustc_ty Move item_bounds to typeck::collect 2020-10-06 11:18:45 +01:00
rustc_typeck stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union' 2020-10-16 11:33:33 +02:00