efd6eab366
The broken condition can be replicated with:
``shell
export MYARCH=x86_64-apple-darwin && mkdir -p build/$MYARCH/subdir &&
touch build/$MYARCH/subdir/file && ln -s build/$MYARCH/subdir/file
build/$MYARCH/subdir/symlink
``
`src/bootstrap/clean.rs` has a custom implementation of removing a tree
`fn rm_rf` that used `std::path::Path::{is_file, is_dir, exists}` while
recursively deleting directories and files. Unfortunately, `Path`'s
implementation of `is_file()` and `is_dir()` and `exists()` always
unconditionally follow symlinks, which is the exact opposite of standard
implementations of deleting file trees.
It appears that this custom implementation is being used to workaround a
behavior in Windows where the files often get marked as read-only, which
prevents us from simply using something nice and simple like
`std::fs::remove_dir_all`, which properly deletes links instead of
following them.
So it looks like the fix is to use `.symlink_metadata()` to figure out
whether tree items are files/symlinks/directories. The one corner case
this won't cover is if there is a broken symlink in the "root"
`build/$MYARCH` directory, because those initial entries are run through
`Path::canonicalize()`, which panics with broken symlinks. So lets just
never use symlinks in that one directory. :-)
90 lines
2.9 KiB
Rust
90 lines
2.9 KiB
Rust
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
//! Implementation of `make clean` in rustbuild.
|
|
//!
|
|
//! Responsible for cleaning out a build directory of all old and stale
|
|
//! artifacts to prepare for a fresh build. Currently doesn't remove the
|
|
//! `build/cache` directory (download cache) or the `build/$target/llvm`
|
|
//! directory as we want that cached between builds.
|
|
|
|
use std::fs;
|
|
use std::io::{self, ErrorKind};
|
|
use std::path::Path;
|
|
|
|
use Build;
|
|
|
|
pub fn clean(build: &Build) {
|
|
rm_rf("tmp".as_ref());
|
|
rm_rf(&build.out.join("tmp"));
|
|
rm_rf(&build.out.join("dist"));
|
|
|
|
for host in build.config.host.iter() {
|
|
let entries = match build.out.join(host).read_dir() {
|
|
Ok(iter) => iter,
|
|
Err(_) => continue,
|
|
};
|
|
|
|
for entry in entries {
|
|
let entry = t!(entry);
|
|
if entry.file_name().to_str() == Some("llvm") {
|
|
continue
|
|
}
|
|
let path = t!(entry.path().canonicalize());
|
|
rm_rf(&path);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn rm_rf(path: &Path) {
|
|
match path.symlink_metadata() {
|
|
Err(e) => {
|
|
if e.kind() == ErrorKind::NotFound {
|
|
return;
|
|
}
|
|
panic!("failed to get metadata for file {}: {}", path.display(), e);
|
|
},
|
|
Ok(metadata) => {
|
|
if metadata.file_type().is_file() || metadata.file_type().is_symlink() {
|
|
do_op(path, "remove file", |p| fs::remove_file(p));
|
|
return;
|
|
}
|
|
|
|
for file in t!(fs::read_dir(path)) {
|
|
rm_rf(&t!(file).path());
|
|
}
|
|
do_op(path, "remove dir", |p| fs::remove_dir(p));
|
|
},
|
|
};
|
|
}
|
|
|
|
fn do_op<F>(path: &Path, desc: &str, mut f: F)
|
|
where F: FnMut(&Path) -> io::Result<()>
|
|
{
|
|
match f(path) {
|
|
Ok(()) => {}
|
|
// On windows we can't remove a readonly file, and git will often clone files as readonly.
|
|
// As a result, we have some special logic to remove readonly files on windows.
|
|
// This is also the reason that we can't use things like fs::remove_dir_all().
|
|
Err(ref e) if cfg!(windows) &&
|
|
e.kind() == ErrorKind::PermissionDenied => {
|
|
let mut p = t!(path.symlink_metadata()).permissions();
|
|
p.set_readonly(false);
|
|
t!(fs::set_permissions(path, p));
|
|
f(path).unwrap_or_else(|e| {
|
|
panic!("failed to {} {}: {}", desc, path.display(), e);
|
|
})
|
|
}
|
|
Err(e) => {
|
|
panic!("failed to {} {}: {}", desc, path.display(), e);
|
|
}
|
|
}
|
|
}
|