4fcaab3d62
Move the method checking into a new lint called `redundant_closures_for_method_calls` and put it in the pedantic group. This aspect of the lint seems more controversial than the rest. cc #3942
93 lines
3.4 KiB
Plaintext
93 lines
3.4 KiB
Plaintext
error: redundant closure found
|
|
--> $DIR/eta.rs:21:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo(a));
|
|
| ^^^^^^^^^^ help: remove closure as shown: `foo`
|
|
|
|
|
= note: `-D clippy::redundant-closure` implied by `-D warnings`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:22:10
|
|
|
|
|
LL | meta(|a| foo(a));
|
|
| ^^^^^^^^^^ help: remove closure as shown: `foo`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:23:27
|
|
|
|
|
LL | let c = Some(1u8).map(|a| {1+2; foo}(a));
|
|
| ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `{1+2; foo}`
|
|
|
|
error: this expression borrows a reference that is immediately dereferenced by the compiler
|
|
--> $DIR/eta.rs:25:21
|
|
|
|
|
LL | all(&[1, 2, 3], &&2, |x, y| below(x, y)); //is adjusted
|
|
| ^^^ help: change this to: `&2`
|
|
|
|
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:32:27
|
|
|
|
|
LL | let e = Some(1u8).map(|a| generic(a));
|
|
| ^^^^^^^^^^^^^^ help: remove closure as shown: `generic`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:75:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.foo());
|
|
| ^^^^^^^^^^^ help: remove closure as shown: `TestStruct::foo`
|
|
|
|
|
= note: `-D clippy::redundant-closures-for-method-calls` implied by `-D warnings`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:77:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.trait_foo());
|
|
| ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TestTrait::trait_foo`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:80:42
|
|
|
|
|
LL | let e = Some(&mut vec![1, 2, 3]).map(|v| v.clear());
|
|
| ^^^^^^^^^^^^^ help: remove closure as shown: `std::vec::Vec::clear`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:85:29
|
|
|
|
|
LL | let e = Some("str").map(|s| s.to_string());
|
|
| ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `std::string::ToString::to_string`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:87:27
|
|
|
|
|
LL | let e = Some('a').map(|s| s.to_uppercase());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `char::to_uppercase`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:90:65
|
|
|
|
|
LL | let e: std::vec::Vec<char> = vec!['a', 'b', 'c'].iter().map(|c| c.to_ascii_uppercase()).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `char::to_ascii_uppercase`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:108:50
|
|
|
|
|
LL | let _: Vec<_> = arr.iter().map(|x| x.map_err(|e| some.take().unwrap()(e))).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `some.take().unwrap()`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:173:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo_ptr(a));
|
|
| ^^^^^^^^^^^^^^ help: remove closure as shown: `foo_ptr`
|
|
|
|
error: redundant closure found
|
|
--> $DIR/eta.rs:178:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| closure(a));
|
|
| ^^^^^^^^^^^^^^ help: remove closure as shown: `closure`
|
|
|
|
error: aborting due to 14 previous errors
|
|
|