a1batross
/
kore
forked from mirrors/kore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove memleak from Python httpclient. 

We grab a reference to the pyhttp_client for the client_op data structure
but never removed it. This caused the pyhttp_client object to never
be released when out of scope.
This commit is contained in:
Joris Vink 2019-06-05 10:27:20 +02:00
parent a4d18ca276
commit 93b1d621d7
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/kore/python_methods.h
View File

@ -675,6 +675,7 @@ struct pyhttp_client_op {
int headers;
struct kore_curl curl;
struct python_coro *coro;
struct pyhttp_client *client;
};
static PyObject *pyhttp_client_op_await(PyObject *);

2
src/python.c
View File

@ -4228,6 +4228,7 @@ pyhttp_client_request(struct pyhttp_client *client, int m, PyObject *kwargs)
op->state = PYHTTP_CLIENT_OP_RUN;
Py_INCREF(client);
op->client = client;
kore_curl_http_setup(&op->curl, m, ptr, length);
kore_curl_bind_callback(&op->curl, python_curl_callback, op);
@ -4302,6 +4303,7 @@ pyhttp_client_request(struct pyhttp_client *client, int m, PyObject *kwargs)
static void
pyhttp_client_op_dealloc(struct pyhttp_client_op *op)
{
Py_DECREF(op->client);
kore_curl_cleanup(&op->curl);
PyObject_Del((PyObject *)op);
}