From 1a6c9e98c98101bb40bcfc62d61b8b2b7818d48f Mon Sep 17 00:00:00 2001 From: PikachuEXE Date: Tue, 29 Aug 2023 13:06:42 +0800 Subject: [PATCH] Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again (#3958) * $ Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again * ~ Add code comment about constant list ordering --- src/renderer/main.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/renderer/main.js b/src/renderer/main.js index c3284766f..e9c1fbb38 100644 --- a/src/renderer/main.js +++ b/src/renderer/main.js @@ -5,6 +5,8 @@ import router from './router/index' import store from './store/index' import i18n from './i18n/index' import { library } from '@fortawesome/fontawesome-svg-core' +// Please keep the list of constants sorted by name +// to avoid code conflict and duplicate entries import { faAngleDown, faArrowDown, @@ -26,6 +28,8 @@ import { faExchangeAlt, faExclamationCircle, faExternalLinkAlt, + faEye, + faEyeSlash, faFileDownload, faFileVideo, faFilter, @@ -57,8 +61,6 @@ import { faTimes, faTimesCircle, faUsers, - faEye, - faEyeSlash, } from '@fortawesome/free-solid-svg-icons' import { faBitcoin, @@ -72,6 +74,8 @@ Vue.config.devtools = process.env.NODE_ENV === 'development' Vue.config.performance = process.env.NODE_ENV === 'development' Vue.config.productionTip = process.env.NODE_ENV === 'development' +// Please keep the list of constants sorted by name +// to avoid code conflict and duplicate entries library.add( // solid icons faAngleDown, @@ -94,6 +98,8 @@ library.add( faExchangeAlt, faExclamationCircle, faExternalLinkAlt, + faEye, + faEyeSlash, faFileDownload, faFileVideo, faFilter, @@ -125,8 +131,6 @@ library.add( faTimes, faTimesCircle, faUsers, - faEye, - faEyeSlash, // brand icons faGithub,