* Implement proposed formatting changes
* Increase font-size of video metrics to 14px
* More closely colocate title and channel to compensate for larger video metrics font size
* Update breakpoint for single column template to 1000px to minimize icon wrapping
* Fix like icon being on a different line from the text on smaller screen widths
* Update all Watch breakpoints to 1050px from 900px
* + Add feature to set a playlist as quick bookmark target
* Add back button to watch page
* focus behavior style update
* * Different button text when video saved
* ! Fix mutation function `removeVideos` (still unused)
* * Make default generated favorites playlist as default quick bookmark target
* ! Add fix for `deleteVideoIdsByPlaylistId`
* * Update button text
* * Update quick bookmark playlist first allow revert later
* * Update single playlist view to hide fav button when viewing the target playlist
* - Remove unused code
* ! Fix add/removing videos from favourite list
* ! Fix playlist type not passed into video list item component
* ! Fix playlist data loading issue on new windows
* ! Fix user playlist data parsing
* * Ensure playlist view rerender on video additonal removal for displayed playlist
* ! Fix icons & moving videos up/down in user playlist
* * Don't show move up/down buttons when cannot be done
* * Make user playlist view filtering function now works for filtering playlists
* ! Fix style of prompt from any button within playlist-info component
* $ Refactor a function to use early return style
* * Disallow empty playlist name when saving in playlist edit mode
* * Update add video to playlist prompt to have simple filtering like user playlist view
* * Update playlist view to only show video reorder/remove buttons in edit mode
With notice message
* ! Fix playlist view for remote playlist unnecessary reload on save
* ! Fix add to playlist prompt behaviour when some playlists are hidden due to filtering
* $ Remove unused watch function arguments
* * Update user playlist view create new playlist button position
* * Update playlist view to add transitions to video reorder/removal
* * Allow playlist with different case to be created
* * Update visibility of user playlist related action components according to hide playlist settings
Only those visible on video, remote playlist are updated
* * Update video items to only show add to playlist buttons on hover
* - Remove add to favorites button from video list item component
* * Update watch-video-info component to add "add to playlist" button
* * Update watch-video-info component to remove "add to favourite" button
* * Ensure video thumbnail image displayed in 16/9 aspect ratio
Mainly due to YT missing video thumbnail image got different aspect ratio 4/3
* * Update new buttons theme
* * Put edit playlist button before copy button
* * Move "remove video from playlist" button to most right
* * Make video reorder & remove button visible on hover in user playlist view, regardless of "edit mode"
* ! Fix video count parsing for user playlist
* * Update user playlist to allow duplicate video entries (per video ID)
* * Remove extra attributes assignment to video object except `timeAdded`
Unintended change
* * Update copy playlist button to like adding multiple videos to playlists
* * Update copy playlist prompt to prefill title if create new playlist prompt shown
* * Ensure all playlists have `playlistName`
* $- Remove unused playlist property `removeOnWatched`
* * Update read all playlist code to ensure existing "default" playlist properties (_id, protected) have same values as those in default
Also fix issue discovered during testing
* *- Remove unnecessary code line
* * Update playlists from default playlists to be deletable
* ! Fix duplicate `timeAdded` value for videos copied from user playlist
* ! Fix playlist import (tested with db file exported from this branch)
* * Update grid view to only display playlist title up to 255 chars
Still can see full title in single playlist view
* * Update add video to playlist prompt to only display playlist title up to 255 chars
* * Update text of new playlist button to be same as new profile button
* * Ignore many extra keys from playlist objectrs
Also make data import check for object keys against required keys not key counts
* * Disallow playlist import from changing internal playlist ID of existing playlists
Existing playlists are matched by playlist name, not by internal playlist ID
* * Ensure playlist name & description trimmed when saved
* * Add missing change for importing playlist to ignore `protected`
* $ Refactor code for "video object has all require keys"
* ! Fix style of prompt from any button within playlist-info component again
z-index war
* * Update some empty message & button text
* * Ensure playlist item action buttons are hidden during animations
* ! Fix other prompt z-index
* * Update `showAddToPlaylistPromptForManyVideos` to throw error when required keys missing from passed in video data
* *- Remove unused video property `paid` from playlist related code
* *- Remove unused video property `type` from playlist related code
* ! Fix duplicate playlist displayed on playlist conversion
* *- Remove unused video property `published` from playlist related code
* * Don't require & generate property `timeAdded` when display a prompt
* *- Remove unused video property `isLive` from playlist related code
* ! Fix text
* ! Revert code change for debugging only
* ! Fix CSS for "Ensure playlist item action buttons are hidden during animations"
* * Update add playlist button to be shown for live videos
* + Add clear all playlists button
* * Update add video to playlist prompt to swap "save" & "create playlist" button
* ! Fix playlist view won't load after default playlist added due to lack of playlist
* * Show toast message when no playlist selected after pressing save button
* * Update add video to playlist prompt to show latest updated playlist first
Easier for copying playlist with new playlist(s)
* ! Fix watch page when visited via history after viewing the video from a deleted user playlist
* ! Fix share buttons emitting user playlist IDs
* * Add toast message after removing all playlists
* ! Fix remote playlist video list rendering with duplicate videos
* ! Fix missing key for some direct child elements under `transition-group`
* ! Fix animation introduced to unnecessary elements
* ! Prevent video link click during animation
* ! Fix playlist creation/removal not reflected in other windows
* * Ensure playlist visual selected state in sync with data in parent
* * Update add video to playlist prompt to auto select playlists created after prompt shown once
* * Update copy playlist button to show warning about not loaded videos when some not loaded yet
For remote playlist
Won't work for Invidious though (coz no way to load more)
* * Update add video prompt to make it easier to access buttons via keyboard
* * Make video reorder & remove button always visible in user playlist view
* * Make plus button can be focused with tab
Side effect is thumbnail link can be focused too (otherwise can't make plus button visible)
* * Update add video to playlist prompt to focus on search input on shown
* * Accept playlist optional property `createdAt` when importing
* * Update playlist view to always show add to playlist button
* $ Refactor `inUserPlaylist`
Only playlist view would supply `playlistType`
* * Improve accessibility for new prompts
* * Make edit playlist inputs focused on entering edit mode
* * Make most prompts focus back to last focused element on close
* $ Use tabindex 0 for prompts
Possible tabindex values unnecessary with elements programatically focused
* * Update add video to playlist prompt to focus back to search input after new playlist created
* * Update ft-list-video to focus back on thumbnail link element after add to playlist prompt closed
* ! Fix unable to import duplicate video entries into an existing playlist
* ! Fix create playlist prompt looks unclosed after playlist created when opened via add video to playlist prompt
* ! Fix duplicate video entry ID when playlist with duplicate videoId entries copied to another playlist
* ! Fix issues caused by last merge in e291cc8b41b2273a0d77c9f35ea760f0e0f7ac10
* $ Remove unused imports
* ! Fix default playlists added when no playlist stored had no required attributes added on 1st run
* ! Fix invalid prop type warning
* * Use v-if instead of v-show
* $ Just assign bool value instead of if-else
* + Update playlists view to add sorting option
* $- Remove unnecessary property assignments
* ! Fix issues caused by "Remove unnecessary property assignments"
* ! Fix issues caused by "Remove unnecessary property assignments"
* * Ensure sort by time also fallbacks to playlist name sorting
* ! Fix add/remove video does not update playlist last created time
* ! Fix multi window playlist sync
* * Show filtering input & sorting element when no. of playlist > 1
* * Update upcoming video to allow saving in playlist
* ! Fix unable to visit previous video when playing first video in a playlist
* * Update sorting options labels
* ! Fix add to play prompt max width
* ! Fix user playlist view incorrectly sorted playlists by latest updated first when filtered
* * Update add to playlist prompt to add sort options
* $ Remove unused classname
* ! Ensure new playlist button focused after add to playlist prompt closed while thumbnail link unselectable
* * Add playlists sort order for last played at, update it on play
* ! Fix bug introduced by last merge
* ! Fix thumbnail not respecting backend preference
* ! Fix empty playlist thumbnail in single playlist view
* * Make adding large no. of videos faster
* $ Remove unused mapActions entries
* $ Remove unused and unusable playlist code for inserting video IDs into a playlist
* * Update single playlist view to only show `Remove watched videos` btn when there is any video
* ! Fix prompt style issue caused by old branch changes
* ! Fix removing video from local playlist remove all entries with same video ID
* ! Fix adding video does not have uniqueID & timeAdded set
Caused by previous add many video performance fix
* ! Fix navigation in user playlist between entries of same video
* * Reflect playlist updates on watch page playlist panel
* $- Remove outdated incorrect prompt style fix
* ! Fix add video to playlist prompt too high when there are too many playlists
* ! Fix watch page play next/prev video in local playlist
* ! Fix error in online playlist playing
* * Keep partial playlist backward compatibility by restoring `type` in persisted playlist videos
* ! Fix grid item for playlist to hide external player button for local playlist
* * Make history rememeber uniqueId (local playlist video entry) when playing video with local playlist
* ! Fix grid item for video in user playlist to hide external player button
* ! Fix grid item for video in history with user playlist to hide external player button
* ! Fix grid item for video in watch page playlist component with user playlist to hide external player button
* * Update watch page to clear `uniqueID` from query when not playing local playlist
* ! Fix watch page about user playlist detection on new window
* * Reflect playlist updates on watch page playlist panel, even for currently playing video
* ! Allow video with local playlist to be played in external player, but without playlist
Also add missing fix for WatchVideoInfo
* ! Fix external player handling for video in local playlist
* ! Fix ft-video having different URLs in links
* yarn run lint-style-fix
* $ Rename uniqueId to playlistItemId
* * Ensure local playlist ID won't conflict with remote playlist ID
* - Remove import video while creating playlist related code
* * Make text translatable
* * Make sort option text translatable
* ! Fix reverse condition
* $ Just use ?.
* Code review changes
* Spaces
* beforeDestroy
* Remove unused methods
* Remove infoData
* filter > find
* avoid importing `crypto` from NodeJS
* Compress CSS ruleset
* $ Remove useless prefix from key
* Use template for element with v-if only
* Make playlist selector look more selectable (cursor: pointer)
* Translate toast messages and fix remove watched videos from playlist
* ! Fix translation
* - Remove unused methods
* $ Remove workaround for issue which cannot be reproduced anymore
* $ Remove remaining useless code following last commit removing workaround
* you have no playlist > you have no playlists
* CSS use var --horizontal-directionality-coefficient
* * Update danger buttons color to primary (like clear search cache button)
* ! Fix playlist icon container size
* ! Fix sorting in add video to playlist prompt when filtered
* $- Update ft-inputs to removed prop input-tabindex
* ! Fix vue warning
* + Add toggle to export playlist for older FT
* * Update tooltip text
* ! Fix vue warning
* * Update text align
* * Remove the extra surrounding spaces
* Backtick > quote
* - Remove useless prop
* Fix tootip in lower width view
* Update default filename
* * Make tooltip auto-wrap
* Revert "* Make tooltip auto-wrap"
This reverts commit 7d932b936c.
* Adjust tooltip styling
* * Wait for local playlist loading only when playing with a user playlist
* * Wait for local playlist loading only when playing with a user playlist requested
Request user playlist can still be absent (but not requested for no playlist or remote playlist)
* ! Fix single playlist view cover image having link when no video
* ! Workaround create playlist prompt won't close when enter pressed in input box
* ! Fix clear text button style
* ! Fix copying playlist twice to the same user playlist produces same playlistItemId
* ! Fix add video to playlist prompt input box style
* ! Fix workaround for "create playlist prompt won't close when enter pressed in input box"
* ! Ensure add video to playlist prompt updated when a playlist deleted (in another window)
* ! Avoid saving and displaying unwanted video attributes into playlists
* ! Fix playlist view for deleted user playlists
* ! Fix copying playlist twice to the same user playlist produces same playlistItemId
Real fix
Cause of issue: updating property of input objects (which is shared across multiple run)
* ! Fix search suggestions being blocked by playlist info component in single playlist view
* ! Fix warning when reversing playlist in watch view
* ! Fix prompt in playlist view (playlistinfo component) not above sidebar
* Remove CSS top comments absent in other CSS files
* Remove not useful comment for CSS
* Float with variable
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Revert "! Fix clear text button style"
This reverts commit 44ed286848.
* Missing change for Revert "! Fix clear text button style"
* $ Remove unused style for ft-playlist-selector
* Apply changes from review
* * Use $tc for translation entries with different value according to count values
* ! Fix playlist link in watch view
---------
Co-authored-by: Jason Henriquez <jasonhenriquez@protonmail.com>
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* update linters, add stylelint, switch from sass to scss
* remove unused babel-eslint module
* fix spacing in scss files
* dont use npm in script calls
* dont error for `:deep` selector in css
* Improve Watch page accessibility
Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* fix title issue, remove unused gotochannel function
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Use named parameters instead of $ and % in localised strings
* Fix URL warning again
* Update placeholders in most locales
* Let the translators fix the problematic RTL strings
* Fix the missing quotes in some of the YAML files
* right click menu for open in a new window
* open video in new window when right click
* router link added to channel images for easier selection in the context of a context menu
* fix security bug user can visit other website via freetube
* simplify context menu entry condition
* createWindow in open new window adapted with the merged function
* Change the open new window selector for the origin of the page no matter the name of the website
* Keypress reintegrate into the code for accesibility
* Keypress reintegrate into the code for accesibility
* Fix style for sidenav subscription links
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Allow webpack to bundle *most* dependencies
* Exclude *most* node_modules from getting packaged by electron-builder
* Import only the required icons instead of bundling the whole icon pack
* Reduce packaging blacklist to only include the few things that still need blacklisting
* start to implement some parental controls
* Hide share + Hide Unsubscribe
* Hide live streams
* fix hide live streams
* Add "parental-control-settings"
* Implement Hide Live Streams & Hide "Age Restricted"
* Hide live streams from Subscriptions + fix hide live streams from search
* enable safe search on showFamilyFriendlyOnly
* Move some settings from parental control to distraction free
* fix channel loading
* make parental control settings collapsible
* fix lint
* dont show age restricted on videos that are loading
* improve hide live videos
* code refactor
* grammar
* nvm im dumb
* use named placeholder for age restricted message
* improve readability
* change Hide Description to Hide Video Description
* update translated strings
* fix age restricted component
Co-authored-by: Preston <freetubeapp@protonmail.com>
Co-authored-by: peepopoggers <72892531+peepopoggers@users.noreply.github.com>
* * Implement divider for video "more dropdown menu"
* * Update API for ft-icon-button
* * Update existing ft-icon-button user to use new API for dropdown options
* * Update ft-icon-button to remove unused old API
* * Update divider to be less visible
* * Update padding of list item
* * Update WebpackDevServer option to avoid app reloading on MacOS .DS_Store file change
* src/renderer/store/modules/utils.js, src/renderer/components/watch-video-info/watch-video-info.vue, src/renderer/components/watch-video-info/watch-video-info.js, src/renderer/components/ft-icon-button/ft-icon-button.js, src/main/index.js
in-app download in hardcoded path
* download into variable folder supported
download can be done into a specify folder defined in the settings or can be done by choosing a folder just before the downloading
* src/renderer/store/modules/utils.js: folder is asked before downloading when appropriate
* src/renderer/store/modules/utils.js: toast added for success and faillure
* src/renderer/store/modules/utils.js: mecanism to show download progress
* src/renderer/store/modules/utils.js: percentage symbol added to toast message when displaying progress
* src/renderer/components/download-settings/download-settings.js: clarification comment about electron
* src/renderer/store/modules/utils.js: typo in comment resolved
* src/renderer/store/modules/utils.js: show a toast when there is a file error
* static/locales/fr-FR.yaml: resolved typo in Choose Path
* src/renderer/store/modules/utils.js: download progress notification toast deleted
* corrections of typos, changes in toast messages, toast messages translatable by modifying the ft-toast component to allow translatable strings
* cleaner code for translatable toast
* downloadMedia argument changed from array to object
* src/renderer/components/download-settings/download-settings.sass: trailling space added
* Apply suggestions from code review
folder changed for folderPath
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* fix forgotten folderPath renaming
* extra space deleted
* starting toast displayed after download folder asks
* audio button deleted
* experimental electron web library deleted because can cause performance issues
* placeholder for web support
* made better condition for web and electon compatibility and small variable renaming
* better error message when user cancel the download
* falling back to asking the user if the download repository doesn't exist
* falling back mode implemented
* console.log for debugging deleted
* useless import deleted
* small renaming
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* feat: add support for opening videos/playlists in external players (like mpv) #418
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: move external player settings into own section
feat: add warnings for when the external player doesn't support the current action (e.g. reversing playlists)
feat: add toggle in settings for ignoring unsupported action warnings
Signed-off-by: Randshot <randshot@norealm.xyz>
* improvement: do not append start offset argument when the watch progress is 0
Signed-off-by: Randshot <randshot@norealm.xyz>
* fix: fix undefined showToast error when clicking on the external player playlist button
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: add icon button for external player to watch-video-info (below video player) component
improvement: refactor the code for opening the external player into a separate function in utils.js
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: add support for ytdl protocol urls (supportsYtdlProtocol)
chore: fix lint error
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: add support for passing default playback rate to external player
improvement: add warning message for when the external player does not support starting playback at
a given offset
chore: rename reverse, shuffle, and loopPlaylist fields for consistency
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: add setting for custom external player command line arguments
Signed-off-by: Randshot <randshot@norealm.xyz>
* chore: fix lint error
Signed-off-by: Randshot <randshot@norealm.xyz>
* improvement(watch-video-info.js): change the default for playlistId back to null (consistent with other occurrences)
improvement(utils.js/openInExternalPlayer): also check for empty playlistId string
fix(watch-video-info.js): fix merge error
Signed-off-by: Randshot <randshot@norealm.xyz>
* improvement(components/ft-list-video): check whether watch history is turned on, before adding a video to it
fix(store/utils): fix playlistReverse typo, causing `undefined` being set as a command line argument
fix(store/utils): check for 'string' type, instead of `null` and `undefined`
fix(views/Watch): fix getPlaylistIndex returning an incorrect index, when reverse was turned on
chore(locales/en-US): fix thumbnail and suppress typo
chore(locales/en_GB): fix thumbnail and suppress typo
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat: pause player when opening video in external player
Signed-off-by: Randshot <randshot@norealm.xyz>
* feat(externalPlayer): refactor externalPlayerCmdArguments into a separate static file `static/external-player-map.json`
chore(components/ft-list-video): fix lint error
Signed-off-by: Randshot <randshot@norealm.xyz>
* Revert "feat: pause player when opening video in external player"
This reverts commit 28b4713334.
* feat: pause the app's player when opening video in external player
* This commit addresses above requested changes.
improvement(components/external-player-settings): move `externalPlayer` check to `ft-flex-box`
improvement(components/external-player-settings): use `update*` methods, instead of `handle*`
improvement(store/utils): move child_process invocation to `main/index.js` via IPC call to renderer
improvement(store/utils): use `dispatch` for calling actions
improvement(store/utils): get external player related settings directly in the action
improvement(renderer/App): move `checkExternalPlayer` call down into `usingElectron` if statement
fix(renderer/App): fix lint error
improvement(components/ft-list-playlist): remove unnecessary payload fields
fix(components/ft-list-playlist): fix typo in component name
improvement(components/ft-list-video): remove unnecessary payload fields
improvement(components/watch-video-info): remove unnecessary payload fields
improvement(views/Settings): add `usingElectron` condition
Signed-off-by: Randshot <randshot@norealm.xyz>
* fix(store/utils): fix toast message error
Signed-off-by: Randshot <randshot@norealm.xyz>
* fix(store/utils): fix a few code mess-ups
Co-authored-by: Svallinn <41585298+Svallinn@users.noreply.github.com>
* ! Fix app unable to load due to missing `getLocale` in `mapActions`
* $ Update a function's name with incorrect name casing
* Update "open youtube link" button to open with playlist when playing a video with an active playlist
The `remote` module is deprecated and `@electron/remote` is unnecessary,
since the `ipcMain` and `ipcRenderer` can replace their functionality,
providing better performance and better security.
All other dangerous calls (mainly pulling main process constructs into
the renderer process) have also been removed.
* Correctly bind theatre mode options
Theatre mode is now bound to both "recommended videos" and "live chat"
distraction settings, rather than just "recommended videos".
The settings switch, the button, and the layout have all been updated
to reflect this.
Most likely closes: https://github.com/FreeTubeApp/FreeTube/issues/910
* Fix watch layout when no sidebar
If there's nothing to display in the sidebar according to the
distraction settings and live status, the watch page will adopt a
single column layout. If the sidebar still exists due to faulty logic,
it will be placed at the very bottom of the page.
Most likely closes: https://github.com/FreeTubeApp/FreeTube/issues/909
* Unlink default theatre mode switch
* Normalise theatre calculation, consider playlists
absidue
Jason
PikachuEXE
ChunkyProgrammer
Bryan-Elliott Tam
Malik
PrestonN
vallode
kuhaku
Svallinn
Cadence Ember
Duane Jaspers
Violet Rose
Cadence Ember