diff --git a/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java b/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java index 75107a7e4..07cdd73da 100644 --- a/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java +++ b/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java @@ -88,7 +88,6 @@ public abstract class ServicePlayerActivity extends AppCompatActivity private TextView seekDisplay; private ImageButton repeatButton; - private ImageButton muteButton; private ImageButton backwardButton; private ImageButton playPauseButton; private ImageButton forwardButton; @@ -319,7 +318,6 @@ public abstract class ServicePlayerActivity extends AppCompatActivity private void buildControls() { repeatButton = rootView.findViewById(R.id.control_repeat); - muteButton = rootView.findViewById(R.id.control_mute); backwardButton = rootView.findViewById(R.id.control_backward); playPauseButton = rootView.findViewById(R.id.control_play_pause); forwardButton = rootView.findViewById(R.id.control_forward); @@ -329,7 +327,6 @@ public abstract class ServicePlayerActivity extends AppCompatActivity progressBar = rootView.findViewById(R.id.control_progress_bar); repeatButton.setOnClickListener(this); - muteButton.setOnClickListener(this); backwardButton.setOnClickListener(this); playPauseButton.setOnClickListener(this); forwardButton.setOnClickListener(this); @@ -462,10 +459,7 @@ public abstract class ServicePlayerActivity extends AppCompatActivity if (view.getId() == repeatButton.getId()) { player.onRepeatClicked(); - } else if (view.getId() == muteButton.getId()) { - player.onMuteUnmuteButtonClicked(); - - } else if (view.getId() == backwardButton.getId()) { + } else if (view.getId() == backwardButton.getId()) { player.onPlayPrevious(); } else if (view.getId() == playPauseButton.getId()) { @@ -698,9 +692,7 @@ public abstract class ServicePlayerActivity extends AppCompatActivity } private void onMaybeMuteChanged() { - muteButton.setColorFilter(ContextCompat.getColor(getApplicationContext(), player.isMuted() ? R.color.white : R.color.gray)); - - if (menu != null) { + if (menu != null && player != null) { MenuItem item = menu.findItem(R.id.action_mute); TypedArray a = getTheme().obtainStyledAttributes(R.style.Theme_AppCompat, new int[]{R.attr.volume_off}); int attributeResourceId = a.getResourceId(0, 0); diff --git a/app/src/main/res/drawable/ic_volume_off_gray_24dp.xml b/app/src/main/res/drawable/ic_volume_off_gray_24dp.xml index 156ee53bb..ade6bfec2 100644 --- a/app/src/main/res/drawable/ic_volume_off_gray_24dp.xml +++ b/app/src/main/res/drawable/ic_volume_off_gray_24dp.xml @@ -1,5 +1,10 @@ - - + + diff --git a/app/src/main/res/layout-land/activity_player_queue_control.xml b/app/src/main/res/layout-land/activity_player_queue_control.xml index 0277c28b5..6468c6784 100644 --- a/app/src/main/res/layout-land/activity_player_queue_control.xml +++ b/app/src/main/res/layout-land/activity_player_queue_control.xml @@ -192,7 +192,7 @@ android:layout_marginLeft="5dp" android:layout_marginRight="5dp" android:layout_centerVertical="true" - android:layout_toLeftOf="@+id/control_mute" + android:layout_toLeftOf="@+id/control_repeat" android:gravity="center" android:minWidth="50dp" android:text="1x" @@ -201,30 +201,13 @@ android:background="?attr/selectableItemBackground" tools:ignore="HardcodedText,RtlHardcoded"/> - - + - -