From 3874e1618715e9f4a3be56220c2d8ed434b613d3 Mon Sep 17 00:00:00 2001 From: Kalle Struik Date: Fri, 23 Jul 2021 17:30:47 +0200 Subject: [PATCH] Added support for showing when a comment has received a heart from the creator of a video. --- .../holder/CommentsMiniInfoItemHolder.java | 7 +++++++ app/src/main/res/drawable-night/ic_heart.xml | 10 ++++++++++ app/src/main/res/drawable/ic_heart.xml | 9 +++++++++ app/src/main/res/layout/list_comments_item.xml | 13 ++++++++++++- app/src/main/res/values/dimens.xml | 3 +++ app/src/main/res/values/strings.xml | 1 + 6 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 app/src/main/res/drawable-night/ic_heart.xml create mode 100644 app/src/main/res/drawable/ic_heart.xml diff --git a/app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java b/app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java index 629240dc6..de6159ba0 100644 --- a/app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java +++ b/app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java @@ -7,6 +7,7 @@ import android.text.style.URLSpan; import android.text.util.Linkify; import android.view.View; import android.view.ViewGroup; +import android.widget.ImageView; import android.widget.RelativeLayout; import android.widget.TextView; @@ -45,6 +46,7 @@ public class CommentsMiniInfoItemHolder extends InfoItemHolder { private final TextView itemContentView; private final TextView itemLikesCountView; private final TextView itemDislikesCountView; + private final ImageView itemHeartView; private final TextView itemPublishedTime; private String commentText; @@ -80,6 +82,7 @@ public class CommentsMiniInfoItemHolder extends InfoItemHolder { itemDislikesCountView = itemView.findViewById(R.id.detail_thumbs_down_count_view); itemPublishedTime = itemView.findViewById(R.id.itemPublishedTime); itemContentView = itemView.findViewById(R.id.itemCommentContentView); + itemHeartView = itemView.findViewById(R.id.detail_heart_img_view); downloadThumbnailKey = infoItemBuilder.getContext(). getString(R.string.download_thumbnail_key); @@ -152,6 +155,10 @@ public class CommentsMiniInfoItemHolder extends InfoItemHolder { itemPublishedTime.setText(item.getTextualUploadDate()); } + if (item.isHeartedByUploader()) { + itemHeartView.setVisibility(View.VISIBLE); + } + itemView.setOnClickListener(view -> { toggleEllipsize(); if (itemBuilder.getOnCommentsSelectedListener() != null) { diff --git a/app/src/main/res/drawable-night/ic_heart.xml b/app/src/main/res/drawable-night/ic_heart.xml new file mode 100644 index 000000000..49bf17297 --- /dev/null +++ b/app/src/main/res/drawable-night/ic_heart.xml @@ -0,0 +1,10 @@ + + + diff --git a/app/src/main/res/drawable/ic_heart.xml b/app/src/main/res/drawable/ic_heart.xml new file mode 100644 index 000000000..dbff29441 --- /dev/null +++ b/app/src/main/res/drawable/ic_heart.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/layout/list_comments_item.xml b/app/src/main/res/layout/list_comments_item.xml index 5e6d46c3d..ae468eec2 100644 --- a/app/src/main/res/layout/list_comments_item.xml +++ b/app/src/main/res/layout/list_comments_item.xml @@ -71,6 +71,17 @@ tools:ignore="RtlHardcoded" tools:text="12M" /> + + @@ -105,7 +116,7 @@ android:layout_height="wrap_content" android:layout_below="@id/itemCommentContentView" android:layout_marginLeft="12dp" - android:layout_toRightOf="@id/detail_thumbs_up_count_view" + android:layout_toRightOf="@id/detail_heart_img_view" android:lines="1" android:textAppearance="?android:attr/textAppearanceSmall" android:textSize="@dimen/video_item_search_upload_date_text_size" diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 51da9b299..dd3533035 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -81,11 +81,14 @@ 16dp 18sp 18sp + 18sp + 18sp 70dp 35dp 60dp 5dp + 5dp 50dp 12sp diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index f6d0246dd..5a4df4c70 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -749,6 +749,7 @@ Unlisted Private Internal + Hearted by creator Open website Tablet mode On