diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java index 024874d14..e99a07f56 100644 --- a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java +++ b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java @@ -767,15 +767,15 @@ public class VideoDetailFragment extends BaseStateFragment implement ((HistoryListener) activity).onVideoPlayed(currentInfo, getSelectedVideoStream()); } - Toast.makeText(activity, R.string.popup_playing_toast, Toast.LENGTH_SHORT).show(); - final PlayQueue playQueue = new SinglePlayQueue(currentInfo); final VideoStream candidate = sortedStreamVideosList.get(actionBarHandler.getSelectedVideoStream()); final Intent intent; if (append) { + Toast.makeText(activity, R.string.popup_playing_append, Toast.LENGTH_SHORT).show(); intent = NavigationHelper.getPlayerIntent(activity, PopupVideoPlayer.class, playQueue, true); } else { + Toast.makeText(activity, R.string.popup_playing_toast, Toast.LENGTH_SHORT).show(); intent = NavigationHelper.getPlayerIntent(activity, PopupVideoPlayer.class, playQueue, Localization.resolutionOf(candidate.resolution)); } activity.startService(intent); @@ -799,7 +799,11 @@ public class VideoDetailFragment extends BaseStateFragment implement private void openNormalBackgroundPlayer(final boolean append) { final PlayQueue playQueue = new SinglePlayQueue(currentInfo); activity.startService(NavigationHelper.getPlayerIntent(activity, BackgroundPlayer.class, playQueue, append)); - Toast.makeText(activity, R.string.background_player_playing_toast, Toast.LENGTH_SHORT).show(); + if (append) { + Toast.makeText(activity, R.string.background_player_append, Toast.LENGTH_SHORT).show(); + } else { + Toast.makeText(activity, R.string.background_player_playing_toast, Toast.LENGTH_SHORT).show(); + } } private void openExternalBackgroundPlayer(AudioStream audioStream) { diff --git a/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java b/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java index 3bab31293..d543ef5c4 100644 --- a/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java +++ b/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java @@ -809,9 +809,13 @@ public abstract class BasePlayer implements Player.EventListener, else audioManager.abandonAudioFocus(this); if (getCurrentState() == STATE_COMPLETED) { - if (playQueue.getIndex() == 0) simpleExoPlayer.seekToDefaultPosition(); - else playQueue.setIndex(0); + if (playQueue.getIndex() == 0) { + simpleExoPlayer.seekToDefaultPosition(); + } else { + playQueue.setIndex(0); + } } + simpleExoPlayer.setPlayWhenReady(!isPlaying()); } @@ -846,11 +850,19 @@ public abstract class BasePlayer implements Player.EventListener, playQueue.offsetIndex(+1); } - public void onRestart() { - if (playQueue == null) return; - if (DEBUG) Log.d(TAG, "onRestart() called"); + public void onSelected(final PlayQueueItem item) { + final int index = playQueue.indexOf(item); + if (index == -1) return; - simpleExoPlayer.seekToDefaultPosition(); + if (playQueue.getIndex() == index) { + simpleExoPlayer.seekToDefaultPosition(); + } else { + playQueue.setIndex(index); + } + + if (!isPlaying()) { + onVideoPlayPause(); + } } public void seekBy(int milliSeconds) { @@ -873,7 +885,7 @@ public abstract class BasePlayer implements Player.EventListener, private final StringBuilder stringBuilder = new StringBuilder(); private final Formatter formatter = new Formatter(stringBuilder, Locale.getDefault()); private final NumberFormat speedFormatter = new DecimalFormat("0.##x"); - private final NumberFormat pitchFormatter = new DecimalFormat("##.##%"); + private final NumberFormat pitchFormatter = new DecimalFormat("##%"); // todo: merge this into Localization public String getTimeString(int milliSeconds) { diff --git a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java index 00b14d661..0b5d0c9d3 100644 --- a/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java +++ b/app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java @@ -572,14 +572,7 @@ public final class MainVideoPlayer extends Activity { return new PlayQueueItemBuilder.OnSelectedListener() { @Override public void selected(PlayQueueItem item, View view) { - final int index = playQueue.indexOf(item); - if (index == -1) return; - - if (playQueue.getIndex() == index) { - onRestart(); - } else { - playQueue.setIndex(index); - } + onSelected(item); } @Override diff --git a/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java b/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java index e7ce1d2a4..5de90dbbe 100644 --- a/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java +++ b/app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java @@ -347,14 +347,7 @@ public abstract class ServicePlayerActivity extends AppCompatActivity return new PlayQueueItemBuilder.OnSelectedListener() { @Override public void selected(PlayQueueItem item, View view) { - final int index = player.playQueue.indexOf(item); - if (index == -1) return; - - if (player.playQueue.getIndex() == index) { - player.onRestart(); - } else { - player.playQueue.setIndex(index); - } + player.onSelected(item); } @Override diff --git a/app/src/main/res/drawable-hdpi/ic_drag_handle_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_drag_handle_black_24dp.png new file mode 100644 index 000000000..7ebc39358 Binary files /dev/null and b/app/src/main/res/drawable-hdpi/ic_drag_handle_black_24dp.png differ diff --git a/app/src/main/res/drawable-hdpi/ic_drag_handle_white_24dp.png b/app/src/main/res/drawable-hdpi/ic_drag_handle_white_24dp.png new file mode 100644 index 000000000..8747b9ecb Binary files /dev/null and b/app/src/main/res/drawable-hdpi/ic_drag_handle_white_24dp.png differ diff --git a/app/src/main/res/drawable-hdpi/ic_reorder_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_reorder_black_24dp.png deleted file mode 100644 index 142d71505..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_reorder_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-hdpi/ic_reorder_white_24dp.png b/app/src/main/res/drawable-hdpi/ic_reorder_white_24dp.png deleted file mode 100644 index bacaaef28..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_reorder_white_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_drag_handle_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_drag_handle_black_24dp.png new file mode 100644 index 000000000..e09d492fc Binary files /dev/null and b/app/src/main/res/drawable-mdpi/ic_drag_handle_black_24dp.png differ diff --git a/app/src/main/res/drawable-mdpi/ic_drag_handle_white_24dp.png b/app/src/main/res/drawable-mdpi/ic_drag_handle_white_24dp.png new file mode 100644 index 000000000..e509264d3 Binary files /dev/null and b/app/src/main/res/drawable-mdpi/ic_drag_handle_white_24dp.png differ diff --git a/app/src/main/res/drawable-mdpi/ic_reorder_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_reorder_black_24dp.png deleted file mode 100644 index d18997cd4..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_reorder_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_reorder_white_24dp.png b/app/src/main/res/drawable-mdpi/ic_reorder_white_24dp.png deleted file mode 100644 index a82363318..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_reorder_white_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_drag_handle_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_drag_handle_black_24dp.png new file mode 100644 index 000000000..906f5eee0 Binary files /dev/null and b/app/src/main/res/drawable-xhdpi/ic_drag_handle_black_24dp.png differ diff --git a/app/src/main/res/drawable-xhdpi/ic_drag_handle_white_24dp.png b/app/src/main/res/drawable-xhdpi/ic_drag_handle_white_24dp.png new file mode 100644 index 000000000..aa1547b04 Binary files /dev/null and b/app/src/main/res/drawable-xhdpi/ic_drag_handle_white_24dp.png differ diff --git a/app/src/main/res/drawable-xhdpi/ic_reorder_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_reorder_black_24dp.png deleted file mode 100644 index 0b080a187..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_reorder_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_reorder_white_24dp.png b/app/src/main/res/drawable-xhdpi/ic_reorder_white_24dp.png deleted file mode 100644 index 6b4c52861..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_reorder_white_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_drag_handle_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_drag_handle_black_24dp.png new file mode 100644 index 000000000..71da19a59 Binary files /dev/null and b/app/src/main/res/drawable-xxhdpi/ic_drag_handle_black_24dp.png differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_drag_handle_white_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_drag_handle_white_24dp.png new file mode 100644 index 000000000..e91ef07e9 Binary files /dev/null and b/app/src/main/res/drawable-xxhdpi/ic_drag_handle_white_24dp.png differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_reorder_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_reorder_black_24dp.png deleted file mode 100644 index 0a66529bf..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_reorder_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_reorder_white_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_reorder_white_24dp.png deleted file mode 100644 index a0d2543f2..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_reorder_white_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_black_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_black_24dp.png new file mode 100644 index 000000000..d102adeb2 Binary files /dev/null and b/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_black_24dp.png differ diff --git a/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_white_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_white_24dp.png new file mode 100644 index 000000000..122690738 Binary files /dev/null and b/app/src/main/res/drawable-xxxhdpi/ic_drag_handle_white_24dp.png differ diff --git a/app/src/main/res/drawable-xxxhdpi/ic_reorder_black_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_reorder_black_24dp.png deleted file mode 100644 index 56a5bc8ba..000000000 Binary files a/app/src/main/res/drawable-xxxhdpi/ic_reorder_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxxhdpi/ic_reorder_white_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_reorder_white_24dp.png deleted file mode 100644 index bc4fde512..000000000 Binary files a/app/src/main/res/drawable-xxxhdpi/ic_reorder_white_24dp.png and /dev/null differ diff --git a/app/src/main/res/layout/play_queue_item.xml b/app/src/main/res/layout/play_queue_item.xml index ba6ef3d43..8ae7c4ff3 100644 --- a/app/src/main/res/layout/play_queue_item.xml +++ b/app/src/main/res/layout/play_queue_item.xml @@ -32,7 +32,7 @@ android:layout_marginLeft="10dp" android:layout_marginRight="5dp" android:scaleType="center" - android:src="?attr/reorder" + android:src="?attr/drag_handle" tools:ignore="ContentDescription,RtlHardcoded"/> - + diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 8295fd5a8..c2e4f858d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -91,6 +91,8 @@ Other Playing in background Playing in popup mode + Queued on background player + Queued on popup player https://www.c3s.cc/ Play Content diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 0ec8093bc..6a8efb0c2 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -25,7 +25,7 @@ @drawable/ic_palette_black_24dp @drawable/ic_language_black_24dp @drawable/ic_history_black_24dp - @drawable/ic_reorder_black_24dp + @drawable/ic_drag_handle_black_24dp @color/light_selector @color/light_separator_color @@ -61,7 +61,7 @@ @drawable/ic_palette_white_24dp @drawable/ic_language_white_24dp @drawable/ic_history_white_24dp - @drawable/ic_reorder_white_24dp + @drawable/ic_drag_handle_white_24dp @color/dark_selector @color/dark_separator_color