Merge pull request #4961 from TeamNewPipe/lint

Fix some Lint errors

app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java

@@ -51,10 +51,10 @@ public final class CheckForNewAppVersion {
     private static final String NEWPIPE_API_URL = "https://newpipe.schabi.org/api/data.json";
 
     /**
-     * Method to get the apk's SHA1 key. See https://stackoverflow.com/questions/9293019/#22506133.
+     * Method to get the APK's SHA1 key. See https://stackoverflow.com/questions/9293019/#22506133.
      *
      * @param application The application
-     * @return String with the apk's SHA1 fingeprint in hexadecimal
+     * @return String with the APK's SHA1 fingerprint in hexadecimal
      */
     @NonNull
     private static String getCertificateSHA1Fingerprint(@NonNull final Application application) {

app/src/main/java/org/schabi/newpipe/local/subscription/services/ImportExportEventListener.java

@@ -9,7 +9,7 @@ public interface ImportExportEventListener {
     void onSizeReceived(int size);
 
     /**
-     * Called everytime an item has been parsed/resolved.
+     * Called every time an item has been parsed/resolved.
      *
      * @param itemName the name of the subscription item
      */

app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

@@ -684,7 +684,7 @@ public abstract class BasePlayer implements
 
     public void onMuteUnmuteButtonClicked() {
         if (DEBUG) {
-            Log.d(TAG, "onMuteUnmuteButtonClicled() called");
+            Log.d(TAG, "onMuteUnmuteButtonClicked() called");
         }
         simpleExoPlayer.setVolume(isMuted() ? 1 : 0);
     }

app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java

@@ -618,7 +618,7 @@ public abstract class ServicePlayerActivity extends AppCompatActivity
             progressLiveSync.setClickable(!player.isLiveEdge());
         }
 
-        // this will make shure progressCurrentTime has the same width as progressEndTime
+        // this will make sure progressCurrentTime has the same width as progressEndTime
         final ViewGroup.LayoutParams endTimeParams = progressEndTime.getLayoutParams();
         final ViewGroup.LayoutParams currentTimeParams = progressCurrentTime.getLayoutParams();
         currentTimeParams.width = progressEndTime.getWidth();

app/src/main/java/org/schabi/newpipe/player/helper/LoadController.java

@@ -26,12 +26,12 @@ public class LoadController implements LoadControl {
     }
 
     private LoadController(final int initialPlaybackBufferMs,
-                           final int minimumPlaybackbufferMs,
+                           final int minimumPlaybackBufferMs,
                            final int optimalPlaybackBufferMs) {
         this.initialPlaybackBufferUs = initialPlaybackBufferMs * 1000;
 
         final DefaultLoadControl.Builder builder = new DefaultLoadControl.Builder();
-        builder.setBufferDurationsMs(minimumPlaybackbufferMs, optimalPlaybackBufferMs,
+        builder.setBufferDurationsMs(minimumPlaybackBufferMs, optimalPlaybackBufferMs,
                 initialPlaybackBufferMs, initialPlaybackBufferMs);
         internalLoadControl = builder.createDefaultLoadControl();
     }

app/src/main/java/org/schabi/newpipe/player/playqueue/AbstractInfoPlayQueue.java

@@ -128,9 +128,9 @@ abstract class AbstractInfoPlayQueue<T extends ListInfo, U extends InfoItem> ext
         fetchReactor = null;
     }
 
-    private static List<PlayQueueItem> extractListItems(final List<StreamInfoItem> infos) {
+    private static List<PlayQueueItem> extractListItems(final List<StreamInfoItem> infoItems) {
         final List<PlayQueueItem> result = new ArrayList<>();
-        for (final InfoItem stream : infos) {
+        for (final InfoItem stream : infoItems) {
             if (stream instanceof StreamInfoItem) {
                 result.add(new PlayQueueItem((StreamInfoItem) stream));
             }

app/src/main/java/org/schabi/newpipe/util/KioskTranslator.java

@@ -5,7 +5,7 @@ import android.content.Context;
 import org.schabi.newpipe.R;
 
 /**
- * Created by Chrsitian Schabesberger on 28.09.17.
+ * Created by Christian Schabesberger on 28.09.17.
  * KioskTranslator.java is part of NewPipe.
  * <p>
  * NewPipe is free software: you can redistribute it and/or modify

app/src/main/java/org/schabi/newpipe/util/ListHelper.java

@@ -141,7 +141,7 @@ public final class ListHelper {
         final SharedPreferences preferences
                 = PreferenceManager.getDefaultSharedPreferences(context);
 
-        // Load the prefered resolution otherwise the best available
+        // Load the preferred resolution otherwise the best available
         String resolution = preferences != null
                 ? preferences.getString(context.getString(key), context.getString(value))
                 : context.getString(R.string.best_resolution_key);
@@ -161,7 +161,7 @@ public final class ListHelper {
      *
      * @param defaultResolution the default resolution to look for
      * @param bestResolutionKey key of the best resolution
-     * @param defaultFormat     the default fomat to look for
+     * @param defaultFormat     the default format to look for
      * @param videoStreams      list of the video streams to check
      * @return index of the default resolution&format
      */
@@ -351,7 +351,7 @@ public final class ListHelper {
      * @param targetResolution the resolution to look for
      * @param targetFormat     the format to look for
      * @param videoStreams     the available video streams
-     * @return the index of the prefered video stream
+     * @return the index of the preferred video stream
      */
     static int getVideoStreamIndex(final String targetResolution, final MediaFormat targetFormat,
                                    final List<VideoStream> videoStreams) {
@@ -413,7 +413,7 @@ public final class ListHelper {
      * @param context           Android app context
      * @param defaultResolution the default resolution
      * @param videoStreams      the list of video streams to check
-     * @return the index of the prefered video stream
+     * @return the index of the preferred video stream
      */
     private static int getDefaultResolutionWithDefaultFormat(final Context context,
                                                              final String defaultResolution,

app/src/main/java/us/shandian/giga/get/DownloadRunnableFallback.java

@@ -21,7 +21,7 @@ import static us.shandian.giga.get.DownloadMission.ERROR_HTTP_FORBIDDEN;
  * Single-threaded fallback mode
  */
 public class DownloadRunnableFallback extends Thread {
-    private static final String TAG = "DownloadRunnableFallbac";
+    private static final String TAG = "DownloadRunnableFallback";
 
     private final DownloadMission mMission;
 

app/src/test/java/org/schabi/newpipe/util/ListHelperTest.java

@@ -205,7 +205,7 @@ public class ListHelperTest {
         assertEquals(MediaFormat.M4A, stream.getFormat());
 
         // Adding a new format and bitrate. Adding another stream will have no impact since
-        // it's not a prefered format.
+        // it's not a preferred format.
         testList.add(new AudioStream("", MediaFormat.WEBMA, /**/ 192));
         stream = testList.get(ListHelper.getHighestQualityAudioIndex(MediaFormat.MP3, testList));
         assertEquals(192, stream.average_bitrate);