From fc4dd4524a6fbb35d39157bf0b1d12ddf0fa1e07 Mon Sep 17 00:00:00 2001 From: camo0112 <56369484+camo0112@users.noreply.github.com> Date: Mon, 19 Apr 2021 10:52:52 +0530 Subject: [PATCH] Replaced if/else with switch --- .../org/schabi/newpipe/error/ErrorActivity.java | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java b/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java index 2fcba0e1a..1bcd28d2e 100644 --- a/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java +++ b/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java @@ -190,15 +190,16 @@ public class ErrorActivity extends AppCompatActivity { @Override public boolean onOptionsItemSelected(final MenuItem item) { - final int id = item.getItemId(); - if (id == android.R.id.home) { - onBackPressed(); - } else if (id == R.id.menu_item_share_error) { - ShareUtils.shareText(this, getString(R.string.error_report_title), buildJson()); - } else { - return false; + switch (item.getItemId()) { + case R.id.home: + onBackPressed(); + return true; + case R.id.menu_item_share_error: + ShareUtils.shareText(this, getString(R.string.error_report_title), buildJson()); + return true; + default: + return false; } - return true; } private void openPrivacyPolicyDialog(final Context context, final String action) {