Commit Graph

157 Commits

Author SHA1 Message Date
TacoTheDank 8282b8a6c0 Update Sonarqube to 3.5 2022-11-29 11:20:31 -05:00
yashpalgoyal1304 e9ef9451e5
Minimize not-so-long images too 2022-11-27 03:22:37 +05:30
yashpalgoyal1304 7c1d06e023
Resolve scoping issue to get values of probeResult 2022-11-27 02:06:01 +05:30
yashpalgoyal1304 225f69b75b
Fix value of width 2022-11-27 01:56:53 +05:30
yashpalgoyal1304 44bc6bf069
Set image-minimizer to specify image width ...
Fix https://github.com/TeamNewPipe/NewPipe/issues/9469
for portrait like orientations
2022-11-26 23:29:11 +05:30
Tobi 31b83ba47a
Add info on date + time localization to contribution guidelines (#9229)
Dates and times are localized using PrettyTime. Added a note to guide translators to also localize that library to create a fully localized experience.

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2022-10-28 17:35:56 +02:00
opusforlife2 02deaa0f1a Update label to 'feature request' 2022-10-14 19:40:04 +02:00
litetex 679e81e091
Merge pull request #8755 from mhmdanas/remove-whitespace
Remove extra whitespace from issue and PR templates
2022-08-25 16:26:31 +02:00
opusforlife2 a50b9bd6ff
Add FAQ entry to the template checklists (#8822)
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-08-21 20:39:57 +03:00
mhmdanas 737a331c85 Remove extra whitespace from issue and PR templates 2022-08-11 19:34:23 +03:00
Mohammed Anas 81c4b822e0
Add "needs triage" label to issue templates (#8643)
This label would make it easier for issue triagers to know what they
haven't triaged yet.
2022-07-26 23:29:43 +03:00
Mohammed Anas a1c6f0073e
Rename "waiting-for-author" label to "waiting for author" (#8642) 2022-07-17 20:37:15 +03:00
mhmdanas a1f1acfbf9 Use minimum required permissions for GitHub workflows
This reduces the attack surface if the workflows are ever compromised.
2022-07-03 20:38:51 +03:00
Stypox 45d2492bcb
Run CI on all release branches (#8565)
We don't seem to agree on which character to use as a separator between `release` and `X.X.X` in release branch names (e.g. `release-0.23.1` or `release/0.23.0`). All those names start with `release`, though, so let's use that to identify releases.
2022-07-02 00:08:44 +03:00
litetex 2b8eb7ed66 Also run CI when target is release branch 2022-04-18 14:28:56 +02:00
TacoTheDank c85936bb11 Update action dependencies in workflows 2022-04-14 15:43:56 -04:00
Trust_04zh 91e1d35a10 update to current checkstyle.xml path 2022-04-11 19:59:14 +08:00
litetex 7225199deb
Fixed typo
It was late when I typed this 😆
2022-02-16 20:31:15 +01:00
litetex c08a4e851b
Improved image-minimizer
* Don't minimize images that are too wide -> they will get stretched otherwise
* Don't try to modify the issue/comment when nothing changed
* Fixed typo
2022-02-15 20:09:21 +01:00
litetex e2a7b9ac56
Switch to GitHub issue forms (#7773)
* Switched to GitHub issue forms

See also
* https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
* https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/

* Switched expected and actual behavior

* Improved/Reworked issue template

Credits to @TheAssassin

* CI: Ignore changes to issue-templates

* Improved/Reworked issue template

Credits to @opusforlife2 and @mhmdanas

* Further improved the issue templates

* Next round of review

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2022-02-12 19:34:08 +00:00
litetex f388a1af67
Added image-minimizer (#7772)
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-02-11 19:54:12 +00:00
litetex 1278fc27ae
Merge pull request #7803 from mhmdanas/paths-ignore-doc-dir
Add some stuff to `paths-ignore`
2022-02-09 19:57:47 +01:00
Poussinou 5bf439ad9e
Update FUNDING.yml (#7682)
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-02-04 10:36:00 +00:00
Mohammed Anas 3b1b23ba2a
Add `FUNDING.yml` to `paths-ignore` 2022-02-04 10:32:33 +00:00
Mohammed Anas 9274e6417a
Add files in `doc` to `paths-ignore` 2022-02-04 10:13:10 +00:00
litetex a6515d5450 Moved timeout control from the tests to the CI pipeline
How fast a tests is executed on a shared CI pipeline is not predictable as the build might be throttled because other builds are running.
Therefore adding extremely short timeouts inside the tests - where they can't be changed - is a bad idea.
Removed them for now.
2022-01-21 22:15:34 +01:00
litetex 552734faa5
CI: Upload test-report when an error occurs 2022-01-09 18:09:47 +01:00
XiangRongLin dc67628ba5 Log test-android CI job in stacktrace mode 2021-12-22 09:55:16 +01:00
XiangRongLin e06342eacf Readd sonar CI job 2021-12-19 12:18:37 +01:00
opusforlife2 2e3e7f9bf2
Drastically simplify Feature Request template (#7165)
Making the experience of filling it out as hassle-free as possible would ensure fewer users ignore/misread the template.
2021-10-02 12:17:14 +03:00
litetex fc52a6e871
Merge branch 'dev' into update-android-build-tools-gradle 2021-09-03 23:18:16 +02:00
Stypox 15691ba41a
Merge pull request #7002 from litetex/gh-actions-use-integrated-cache-setup-java
Using integrated cache in ``actions/setup-java``
2021-08-31 12:01:26 +02:00
Stypox 5ffba55b4a
Merge pull request #6990 from CBSkarmory/dev
fix typo / reword part of bug report template
2021-08-30 15:51:47 +02:00
litetex a825253b7f
Using integrated cache in ``actions/setup-java``
https://github.com/actions/setup-java#caching-gradle-dependencies
2021-08-28 15:22:04 +02:00
litetex 05f6ea6401
Using Eclipse ``temurin``
as AdoptOpenJDK is getting deprecated.

Eclipse ``temurin`` is a defacto renamed AdoptOpenJDK.

Ref:
* https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
* https://github.com/actions/setup-java#supported-distributions
2021-08-27 15:21:48 +02:00
George T 4cd7c42b9e
fix typo / reword part of bug report template 2021-08-26 19:02:50 -05:00
litetex 36e72d5a41
Update ci.yml
Using Java 11
2021-08-25 17:05:10 +02:00
Mohammed Anas 71610a365f
Make workflow run daily instead of hourly 2021-08-19 21:08:23 +00:00
mhmdanas 44860f2ea7 Add no-response workflow 2021-08-19 00:46:31 +03:00
XiangRongLin 52cc3f10c1 Add gradle parameter to skip formatKtLint and use in CI 2021-08-06 18:11:22 +02:00
litetex 12e46e0a36
Allow manual execution of ci workflow (#6809) 2021-08-04 17:00:15 +00:00
Mohammed Anas c7f75bf7d1
Ignore paths unrelated to builds in CI (#6789) 2021-08-02 13:29:39 +00:00
litetex 903296014a
Check formatting of kotlin files in CI 2021-07-28 21:03:51 +02:00
XiangRongLin c422f65935
Readd api level 29 to android CI tests
The action got fixed and released https://github.com/ReactiveCircus/android-emulator-runner/releases/tag/v2.19.1
2021-07-20 18:28:46 +02:00
Stypox bec8512c7b
Merge pull request #6659 from TeamNewPipe/Redirion-kotlin-section
Added a Kotlin section in CONTRIBUTING.md
2021-07-19 11:54:48 +02:00
XiangRongLin d3375a921d
Remove api level 29 from android ci tests 2021-07-16 10:19:58 +02:00
Robin a2eb810df0
removed Extractor line 2021-07-14 13:23:01 +02:00
Robin 6e576a165c
Added a Kotlin section in CONTRIBUTING.md
Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language.

This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decides that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.
2021-07-14 13:08:07 +02:00
Tobi 4d5b68792b
Merge pull request #6560 from TeamNewPipe/fix_ci_emulator
Specify emulator-build version in CI job
2021-07-12 16:16:06 +02:00
Tobi a73a4afcad
Fix APK testing section (#6623)
* Fix APK testing section

Correct the instructions to download a test APK

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
2021-07-09 14:47:44 +00:00