Commit Graph

30 Commits

Author SHA1 Message Date
Tobi 31b83ba47a
Add info on date + time localization to contribution guidelines (#9229)
Dates and times are localized using PrettyTime. Added a note to guide translators to also localize that library to create a fully localized experience.

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2022-10-28 17:35:56 +02:00
Trust_04zh 91e1d35a10 update to current checkstyle.xml path 2022-04-11 19:59:14 +08:00
Robin a2eb810df0
removed Extractor line 2021-07-14 13:23:01 +02:00
Robin 6e576a165c
Added a Kotlin section in CONTRIBUTING.md
Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language.

This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decides that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.
2021-07-14 13:08:07 +02:00
Stypox 25914b0263
Third round of review 2021-06-24 10:46:53 +02:00
Stypox 0db3406ad8
Fix SonarLint references and explanation 2021-06-18 12:26:50 +02:00
Stypox 8b3e32b6eb
First round of review 2021-06-17 20:47:22 +02:00
Stypox 6063ff063b
CONTRIBUTING.md: add "Build instructions" section and improve ordering 2021-06-13 21:06:59 +02:00
TiA4f8R fe7536e374
Change NewPipe IRC links in the contribution guidelines (#6415)
* Change NewPipe IRC links in the contribution guidelines

* Remove redundant line break

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2021-06-02 16:27:08 +00:00
Allan Nordhøy 3ad14e4adf
Contributing guidelines reworked (#4318)
* Contributing guidelines reworked

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: bopol <bopol@e.email>
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2020-11-28 12:00:00 +01:00
Keegan fb9905a89e
Add need for contributors to discuss possible changes
This was discussed in IRC, and should help prevent the occurrence of problems where people spend hours on a feature only for it to be rejected for miscellaneous reasons.
2020-08-14 11:27:06 -05:00
B0pol 8d6965713c Update .github/CONTRIBUTING.md
Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-04-04 12:37:51 +02:00
bopol fe2858bc75 update contributing.md 2020-04-04 12:14:32 +02:00
Brian fab5f26e09
Correct 'description' spelling 2019-01-12 04:41:16 +13:00
Christian Schabesberger 22b20c15de update contribution guidelines 2018-12-01 09:21:57 +01:00
Christian Schabesberger f96bc95053
Update CONTRIBUTING.md 2018-06-05 11:03:48 +02:00
Christian Schabesberger 23c1b66f6c
add note to contribution description 2018-05-14 13:24:35 +02:00
Schabi c8a91fbb25 add note to check if bugs exist in latest version 2018-03-28 09:58:09 +02:00
Arjen Singels 1c20a4d9eb
Update CONTRIBUTING.md
fixed typo.
2017-11-08 13:58:01 +02:00
Christian Schabesberger 3ac3cedc19 add fdroid build server node to contribution.md 2017-10-23 15:16:34 +02:00
Christian Schabesberger 894a63ed82 Merge branch 'dev' into master 2017-10-18 11:56:11 +02:00
TheAssassin 35b4110a7a Fix half finished paragraph 2017-10-15 18:42:49 +02:00
Christian Schabesberger d564199e88 add sigle issue signle thread rule 2017-09-19 20:41:45 -03:00
TheAssassin 9e2ed10144 Fix bugs in CONTRIBUTING.md
Spelling and grammar bugs, a few additions here and there, make it sound like a team project instead of a one-man show.
2017-08-02 23:34:46 +02:00
Christian Schabesberger 27e5ce7f9b update sentry linkg 2017-08-02 23:19:34 +02:00
Coffeemakr b03723c3fb Code improvements
* Replace unchecked casts with checked casts
 * remove Utility.finViewById
 * Fix return activity checking
 * Create UserAction enum
 * Fix typos
 * Add instrumented test for error info
 * ErrorInfo make fields final
 * Log exception using logger
 * Add inherited annotations
 * Resolve deprecation warnings
 * Remove unused methods from utility
 * Reformat code
 * Remove unused methods from Utility and improve getFileExt
 * Create OnScrollBelowItemsListener
2017-06-28 18:56:05 +02:00
Christian Schabesberger 7f73612b9f add use english into contribution notes 2017-05-23 11:11:12 +02:00
Christian Schabesberger 130757ee99 Update CONTRIBUTING.md 2017-02-12 00:16:41 +01:00
Christian Schabesberger 5020a4f9dc add mailinglist to contributing 2017-02-11 22:26:00 +01:00
Christian Schabesberger cac360d37b add .github folder 2016-09-27 14:30:03 +02:00