lasers
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
9,103 Commits 6 Branches 132 Tags 124 MiB
Commit Graph

2666 Commits

Author SHA1 Message Date
Stypox 360f5ac6f7
Save playback state even if stream is finished and add isFinished() 2021-06-09 15:53:51 +02:00
Mauricio Colli e846f69e38
Add ability to hide played items in a feed 
- Use components from the new Groupie list library for displaying the
feed list.
 2021-06-09 15:53:51 +02:00
Tobi 56cd84c1fe
Merge pull request #6444 from TeamNewPipe/increasebufferafterdepletion 
Increase buffer for playback after rebuffer
 2021-06-08 17:02:18 +02:00
Stypox a2eead521f
Merge pull request #6346 from Imericxu/tabs-style-check 
Resolve Tabs style checks
 2021-06-08 14:49:14 +02:00
Stypox a2fd5ae20c
Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java 2021-06-08 14:45:00 +02:00
Stypox 543440e38d
Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java 2021-06-08 14:44:54 +02:00
Stypox bede758507
Use url at current time for long click on player share button 2021-06-08 14:34:51 +02:00
Abanoub Sameh 5532666ad5
Long press on player share button to copy url to clipboard 2021-06-08 14:23:33 +02:00
Stypox 63cff25616
Merge pull request #6314 from Peyman-hme/Add-Open-website-button-to-webview-in-license-fragment-issue-#6296 
Add "Open website" button to WebView in license fragment
 2021-06-08 11:37:06 +02:00
Stypox 5e2735aaa2
Merge pull request #5462 from Isira-Seneviratne/Convert_abstract_classes_to_interfaces 
Convert the abstract class DAOs to interfaces.
 2021-06-08 11:32:10 +02:00
Peyman-hme 6fc0d8fce4
Add Open website string resources 2021-06-08 11:29:25 +02:00
Peyman-hme e0c1ca1209
Change "Ok" Button to "Dismiss" and also change "Open Website" button to neutral button 2021-06-08 11:29:00 +02:00
Peyman-hme 3dc4ed1764
Add "Open website" button in webview in license fragment, issue #6296 2021-06-08 11:29:00 +02:00
Tobi f63a4ee2ae
Merge pull request #5876 from TeamNewPipe/terminated-channels 
Better error handling of terminated channels
 2021-06-08 10:57:24 +02:00
Stypox 2a99e0e435
Reimplement storing backup import/export path 
#6319 and #6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
 2021-06-08 10:41:24 +02:00
Stypox 5ffc667bea
Remove misplaced comment 2021-06-08 10:40:45 +02:00
Stypox 21b8df0375
Check if file really exists before asking user to overwrite it 2021-06-08 10:40:45 +02:00
Stypox b78ac7d2e9
Fix strange behaviour when app loses access to saf download folder 2021-06-08 10:40:45 +02:00
Stypox 114dc8ffa0
Pass mime type so that SAF treats file extension correctly 2021-06-08 10:40:45 +02:00
Stypox eea43d5a73
Add comments to SharpStreams 2021-06-08 10:40:45 +02:00
Stypox bcb1cf6603
Improve SAF switch descriptions in settings 2021-06-08 10:40:45 +02:00
Stypox 1e8b3826dc
Add setting migration to promote using SAF 2021-06-08 10:40:45 +02:00
wb9688 7efe62ee80
Only ask for storage permissions when not using SAF 2021-06-08 10:40:45 +02:00
wb9688 febb21a01d
Fix non-SAF actions 2021-06-08 10:40:44 +02:00
wb9688 cb4e6159c4
Use file picker for export DB 2021-06-08 10:40:44 +02:00
wb9688 1164ea52f9
Move Stored(File|Directory)Helper into NewPipe 2021-06-08 10:40:44 +02:00
wb9688 0f75024e03
Support SAF properly 2021-06-08 10:40:44 +02:00
Stypox 1e09a1768e
Revert all commits related to ContentSettingsFragment 
Revert "Annotate methode parameters as NonNull"
This reverts commit 004907d306.

Revert "Commit path immediately when import backup"
This reverts commit 05eb0d0fbe.

Revert "Set ImportExportDataPath only on successful import"
This reverts commit f13a1b04e6.

Revert "Set ImportExportDataPath only on successful export"
This reverts commit fd4408e572.

Revert "Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability"
This reverts commit 92ab9cae27.

Revert "Move ContentSettingsFragment.isValidPath to helpers and add unit test for it."
This reverts commit fa2b11b768.

Revert "Save backup import/export location for feature import/exports"
This reverts commit 82f43ac6a6.

Remove FilePathHelperTest file
 2021-06-08 10:40:44 +02:00
TobiGr b57ecae565 Fix getting error cause 
Fix error dialog not shown when getting elemets from first subscription failed.
 2021-06-08 10:12:36 +02:00
Stypox 89317d4abc Fix feed loading and show a dialog for each invalid subscription 2021-06-08 10:12:36 +02:00
TobiGr c5dd3dc7a9 Improve error message when loading feed 
Add name of unavailable channel
 2021-06-08 10:12:36 +02:00
TobiGr ccc46971b4 Show detailed error message when an account has been terminated by the service 2021-06-08 10:12:36 +02:00
TobiGr 6ad4b425e4 Better error handling of terminated channels when loading feed 2021-06-08 10:12:36 +02:00
Robin 3b0045917c
Increase buffer for playback after rebuffer 2021-06-07 09:25:49 +02:00
Stypox a102fc9cad
Use constraint layout for play queue item 
Also remove invalid ic_selected attribute
 2021-06-07 08:07:27 +02:00
Douile d921e2e61b
Hide queue duration when displaying segment panel 
Fixes #6441
 2021-06-07 02:10:44 +01:00
TobiGr 7e3b3453c0 Suppress a warning 2021-06-05 16:13:12 +02:00
TobiGr abc354f516 Use reqireContext(), requireActivity() instead of getters 2021-06-05 16:13:12 +02:00
Tobi 932eb94f9d
Merge pull request #6429 from TiA4f8R/fix-play-with-kodi-player-button 
Fix Play with Kodi button in Player always prompts to install Kore
 2021-06-05 14:32:09 +02:00
TiA4f8R 9fc3ddeab7
Fix Play with Kodi button in Player always prompts to install Kore 2021-06-05 12:48:34 +02:00
TobiGr 98fdbec442 Fix playback speed not being updated in PlayQueuAcitvity 
Fixes #6419
 2021-06-05 12:24:59 +02:00
bopol 332b90d6c1
Merge pull request #6337 from litetex/fix-broken-yt-liked-comments 
[YouTube] Fix broken likes in comments
 2021-06-04 22:32:48 +02:00
Tobi db2e03eb14
Merge pull request #6402 from XiangRongLin/save_backup_bug 
Fix and improve setting import and export paths
 2021-06-04 22:22:09 +02:00
Tobi 63c9308f59
Merge pull request #5946 from Stypox/metadata 
Show content metadata below the description
 2021-06-03 20:51:33 +02:00
litetex 1306a777fc Using Localization.shortCount() and old likeCount 2021-06-03 14:40:00 +02:00
TiA4f8R b4d6015464
Add the Open in browser option when long-pressing a stream for local and online playlists and for history 2021-06-03 13:21:31 +02:00
TiA4f8R b9aaafdb30
Add Open in browser option to long-press menu 
Add Open in browser option to long-press menu when long pressing a stream and a subscription
 2021-06-03 13:15:08 +02:00
Tobi 71aa6c6e92
Merge pull request #6309 from mhmdanas/fix-channel-details-long-press-menu-on-feeds 
Add "Show channel details" option in remote (non-local) playlists
 2021-06-03 12:25:50 +02:00
Tobi f98d2631e5
Merge pull request #6242 from evermind-zz/fixes-for-upstream 
fix Rotation crash on „Video not available“ page (#5941)
 2021-06-03 12:22:23 +02:00
Stypox d025ef11f8
Sort tags in metadata section 2021-06-02 21:23:42 +02:00
Stypox 14256137e8
Use chips to show tags in metadata section 
Clicking on chips opens the search fragment
Long clicking copies to clipboard
 2021-06-02 16:15:02 +02:00
Stypox bc3e43ac58
Add button to allow selecting text in the description 
Since now selection is disabled by default, this fixes #5453
 2021-06-02 14:36:34 +02:00
Stypox d0d5373be9
Allow copying metadata to clipboard 2021-06-02 14:19:25 +02:00
Stypox 997267bad1
Show video metadata below the decription 2021-06-02 14:19:25 +02:00
XiangRongLin 004907d306 Annotate methode parameters as NonNull 2021-05-31 15:09:57 +02:00
XiangRongLin 05eb0d0fbe Commit path immediately when import backup 2021-05-31 12:40:14 +02:00
XiangRongLin f13a1b04e6 Set ImportExportDataPath only on successful import 
Also set the folder instead of the file itself as path
 2021-05-31 12:38:21 +02:00
XiangRongLin fd4408e572 Set ImportExportDataPath only on successful export 2021-05-31 12:36:21 +02:00
Tobi 62b593da08
Merge pull request #6118 from sauravrao637/errorHandlingInSubcribe 
Error handling in subscribe() in DownloadDialog
 2021-05-29 11:30:36 +02:00
Tobi 0eb69b6659
Merge pull request #6353 from Imericxu/fix-pasting-rich-text-in-search 
Fix unwanted rich text formatting when pasting
 2021-05-29 09:12:07 +02:00
Tobi f134e2d02a
Merge pull request #6385 from sauravrao637/6371 
Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST
 2021-05-28 14:23:04 +02:00
camo0112 b564433ff6 Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST 2021-05-28 03:38:53 +05:30
Zhiheng Xu ea1b910d7e Simplify code 2021-05-26 12:01:58 -04:00
Zhiheng Xu 8f4c6fb6ac Add comment 2021-05-26 12:01:58 -04:00
Zhiheng Xu 9b1861417c Add formatting removal on paste for search 
Closes #5912
 2021-05-26 12:01:58 -04:00
Eric Xu 448989f32f Add PlaylistTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu 2fc26bc154 Refactor PlaylistTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu 1812249d37 Add ChannelTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu 14bbaccb9f Refactor ChannelTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu d2b03afcf4 Add KioskTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu 1cac3895dc Refactor KioskTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu 01aab25889 Add Tab.hashCode() to go with equals 2021-05-26 12:01:30 -04:00
Eric Xu 96d731dfc7 Refactor equals method 2021-05-26 12:01:30 -04:00
Zhiheng Xu 2e161a1f45 Change shuffle() guard to check for size <= 2 
After testing the app, I realized that shuffling a queue with size 2
does nothing
 2021-05-24 12:20:19 -04:00
Zhiheng Xu 5ab6e84044 Remove redundant clearing of list 2021-05-24 12:20:19 -04:00
Zhiheng Xu e1a6347c4e Refactor shuffle and update documentation 
- Add early return for invalid sizes to shuffle

 - Rename variables to be more descriptive

 - Refactor moving list element, removing unnecessary operations

 - Unwrap if clause for adding to history because the condition is
   guaranteed by the guard clause

 - Inline the value 0 for the ReorderEvent

 - Update documentation to reflect new changes
 2021-05-24 12:20:19 -04:00
Eric Xu 92a67bb8cb Rearrange fields 
Final fields should be arranged first
 2021-05-24 12:20:19 -04:00
Eric Xu e8eeac6735 Resolve TODO in indexOf(...) 
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
 2021-05-24 12:20:19 -04:00
Eric Xu 775fbc9a75 Rewrite setIndex(int) to pass unit tests 
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.

There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
 2021-05-24 12:20:19 -04:00
Eric Xu 8efe2859b8 Refactor assignments to field declaration 
Assignments that don't require the constructor can be moved out.
 2021-05-24 12:20:19 -04:00
Eric Xu 441c68ead2 Add hashCode() to match equals(other) 2021-05-24 12:20:19 -04:00
Eric Xu 4cd1f201f5 Refactor streams to initialize with values 2021-05-24 12:20:19 -04:00
Eric Xu 013c59f904 Refactor ArrayList fields to List 2021-05-24 12:20:19 -04:00
Eric Xu 57474e2dab Refactor and optimize equals 
- Remove multiple casts of obj

 - Simply use object equals on the streams because PlayQueueItem’s
   equals already compares urls
 2021-05-24 12:20:19 -04:00
TobiGr 87d2f33e55 Add support for PeerTube HLS streams 2021-05-23 11:53:35 +02:00
XiangRongLin fc7944d287
Merge pull request #6319 from ATofighi/feat-6039-store-backup-location 
Save backup import/export location for future import/exports
 2021-05-21 21:08:33 +02:00
Alireza Tofighi 92ab9cae27 Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability 2021-05-21 20:24:57 +04:30
Alireza Tofighi fa2b11b768 Move ContentSettingsFragment.isValidPath to helpers and add unit test for it. 2021-05-21 20:21:58 +04:30
Alireza Tofighi 82f43ac6a6 Save backup import/export location for feature import/exports 2021-05-17 21:57:27 +04:30
XiangRongLin 847831c195
Merge pull request #6308 from mhmdanas/make-minor-changes 
Make some minor changes
 2021-05-17 12:14:00 +02:00
XiangRongLin e0b246431f
Merge pull request #6312 from ATofighi/fix-6298-report-page-back-not-working 
Fix ErrorActivity actionbar back button not working
 2021-05-17 12:12:12 +02:00
Isira Seneviratne 3b1c4b043d Convert Converters to a Kotlin object. 2021-05-16 11:14:15 +05:30
Isira Seneviratne e8b8391868 Rename .java to .kt 2021-05-16 11:14:15 +05:30
Alireza Tofighi c808beec30 Fix ErrorActivity actionbar back button not working 
The issue is because of R.id.home != android.R.id.home
 2021-05-16 02:19:52 +04:30
mhmdanas b2b9938484 Put show channel details option in more long-press menus 2021-05-15 19:20:27 +03:00
mhmdanas eb1cefe2fa Make some minor changes 2021-05-15 18:48:16 +03:00
Robin 95f61542b5 TEST: Downgrade ExoPlayer to 2.12 2021-05-14 14:47:53 +02:00
Robin 98ccd577d6 Fixed checkstyle 2021-05-14 12:15:48 +02:00
Robin 1d43a2362c Add debug option to disable media tunneling 2021-05-14 12:05:52 +02:00
Saurav Rao 5b4fbe32b1
Fix trying to delete object not in list (#6127) 
* fix trying to delete object by index -1

* correction in checkstyle-supressions.xml

Co-authored-by: camo0112 <56369484+camo0112@users.noreply.github.com>
 2021-05-12 14:33:00 +02:00
litetex 31ea44ccf1
Fixed player not automatically playing (#6266) 
* Fixed player not automatically playing

Should also fix https://github.com/TeamNewPipe/NewPipe/issues/6179

* Added comment
 2021-05-12 10:20:39 +02:00
evermind a012e26d63 fix Rotation crash on „Video not available“ page (#5941) 
The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
 2021-05-05 08:55:54 +02:00
Tobi 72ee4be495
Merge pull request #6152 from Isira-Seneviratne/Use_Animator_addListener 
Use Animator.addListener() extension.
 2021-05-04 19:37:03 +02:00
Robin c85b97a484
Fix: fragmentSize is below the minimum (#6238) 
noticed logs " CacheDataSink: fragmentSize is below the minimum recommended value of 2097152. This may cause poor cache performance.

this fixes the issue by using ExoPlayers MIN_RECOMMENDED_FRAGMENT_SIZE. Unfortunately that field is private:
aeb306a164/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSink.java (L123)
 2021-05-04 19:08:25 +02:00
Tobi c7510c628f
Merge pull request #6189 from mhmdanas/fix-some-warnings 
Fix some warnings
 2021-05-04 18:54:17 +02:00
Tobi 3ca1e550fe
Merge pull request #5997 from TeamNewPipe/reChaptcha 
Do not set reCaptcha cookie when there is no cookie stored
 2021-05-04 18:53:12 +02:00
mhmdanas 2c1df5f875 Actually fix the parentFile warning 2021-04-30 01:02:46 +03:00
mhmdanas e7ae215ab0 Fix some warnings 2021-04-28 00:28:36 +03:00
TobiGr 4a9c790652 Merge branch 'master' into dev 2021-04-26 19:13:17 +02:00
Tobi bacb35fb1c
Merge pull request #6151 from TeamNewPipe/share-dialog-color 
Fix black drawables in night themes in share dialog (RouterActivity)
 2021-04-26 11:51:50 +02:00
TobiGr e70c153cd3 Fix black drawables in night themes in share dialog (RouterActivity) 2021-04-25 11:36:40 +02:00
TobiGr b54c2b7f57 Fix invisible buffering / loading indicator in player 2021-04-25 11:36:00 +02:00
Isira Seneviratne 3fe80ec5ac Use Animator.addListener() extension. 2021-04-24 07:45:12 +05:30
Sub Raizada e775037366
Only show 'download has started' toast when a download has started 2021-04-22 02:45:04 +00:00
camo0112 4357e02c58 user can report the error 2021-04-20 16:21:20 +05:30
camo0112 67c0ceedc9 Error handling in subscribe() in DownloadDialog 2021-04-20 13:06:40 +05:30
Robin 0039312a64
Merge pull request #6109 from sauravrao637/codeImrovement 
Replaced if/else with switch in ErrorActivity, supress false lint warning
 2021-04-19 16:45:45 +02:00
camo0112 fc4dd4524a Replaced if/else with switch 2021-04-19 10:52:52 +05:30
TobiGr e5457e5029 [Bandcamp] Add Radio stream segments 
Display channel / creator / artist name when given
 2021-04-11 23:14:23 +02:00
XiangRongLin c9e0bf4f02
Merge pull request #5963 from sauravrao637/IssueFix#5959 
Fix display of channel details when it has no videos
 2021-04-09 11:15:51 +02:00
camo0112 8f9eaa22e6 Fix display of channel details when it has no videos 2021-04-09 12:45:43 +05:30
Tom 3fcd580491
Add queue time (#6023) 
* Add queue time
 2021-04-08 10:41:41 +02:00
Davide Beatrici cf3cc2e984
Disable media tunneling on cvt_mt5886_eu_1g (#6024) 
* Disable media tunneling on cvt_mt5886_eu_1g

Follow-up to 4a9d21062a.
 2021-04-08 05:21:57 +02:00
Robin 9e29d8d692
Merge pull request #6001 from TacoTheDank/appcompat-alertdialog 
Migrate rest of AlertDialogs to AppCompat
 2021-04-07 05:07:24 +02:00
wangear 5d5f8b4d51
Fix NullPointerException: Attempt to get length of null array in MainActivity (#5999) 
* Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array #5996
issue : #5996
changed :
- Checked null
 2021-04-06 14:13:13 +02:00
TacoTheDank e75d0de135 Migrate rest of AlertDialogs to AppCompat 2021-04-04 10:26:38 -04:00
TobiGr c0c78ae9bb Do not set reChaptache cookie when there is no cookie stored 
In DownloaderImpl#getCookies(String url) the reChaptcha cookie is set if it is not null. For this reason, the cookie was set in every request.
 2021-04-04 12:27:12 +02:00
krlvm e484339cca
Merge branch 'dev' into daynight 2021-04-03 00:08:26 +03:00
Stypox 2af20d5c40
Merge pull request #5974 from fynngodau/related-items 
Rename related streams to related items
 2021-04-02 20:34:39 +02:00
PulkitGarg67 e1a6b69f9a
Functionality to rename playlist name from playlist interface 2021-04-01 21:30:15 +02:00
Saurav Rao 8df935f5fe
NullPointerException on screen rotation during exit fix (#5976) 2021-04-01 15:07:21 +02:00
Fynn Godau c9766d25ef Rename related streams to related items 2021-03-31 22:33:22 +02:00
krlvm 7061859112
Fix subscription picker colors on API 19 2021-03-31 20:17:58 +03:00
Tobi 66c24af3d2
Merge pull request #5969 from Redirion/tnnlwrkarnd 
Disable media tunneling on Hi3798MV200
 2021-03-31 19:02:00 +02:00
camo0112 856a39855e IssueFixed#5968 2021-03-31 20:48:02 +05:30
Robin 4a9d21062a Disabled tunneling on Hi3798MV200 2021-03-31 16:38:50 +02:00
Stypox 43f85408be
Merge pull request #5944 from Stypox/fix-search-menu 
Fix some random NullPointerExceptions
 2021-03-31 15:21:13 +02:00
Stypox 5739caaa5a
Merge pull request #5856 from Redirion/exo213 
Update to ExoPlayer 2.13.2
 2021-03-31 14:29:16 +02:00
wangear 73cfa5499d
Fix overlapping fonts and crash on tapping anywhere on video after long-pressing 'Popup' button (#5813) 
* Overlapping fonts #5096
issue : #5096

* Overlapping fonts #5096
issue : #5096
changed :
- If additional textView is overlapped, only title view shows.

* Overlapping fonts #5096
issue : #5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.

* Overlapping fonts #5096
issue : #5096
changed :
- remove unusable variable

* Crash on tapping anywhere on video after long-pressing 'Popup' button #5804
issue : #5804
changed :
- checked null
- fixed NullPointerException.
 2021-03-31 10:10:14 +02:00
Robin 83d16932a4 Update to ExoPlayer 2.13.2 2021-03-31 10:05:44 +02:00
Stypox 84e3f6ca18
Merge pull request #5881 from TacoTheDank/about_revamp 
About package internal revamp
 2021-03-31 09:56:12 +02:00
Stypox 5d6a568308
Fix random NullPointerException in NotificationActionsPreference 2021-03-31 09:12:47 +02:00
Stypox 3e8cba745a
Fix random NullPointerException in PlaylistFragment 2021-03-31 09:12:47 +02:00
Stypox be4d12789d
Fix random NullPointerException in SearchFragment 2021-03-31 09:12:45 +02:00
TacoTheDank 27d0f7f277 Convert AboutFragment clickListeners to a function extension 2021-03-29 19:07:12 -04:00
TacoTheDank fb1aab2a49 Converted the about package to Kotlin 2021-03-29 19:06:32 -04:00
TacoTheDank cc72fa4793 Renamed things pertaining to the about package 2021-03-29 19:05:57 -04:00
krlvm e9c60eff85
Cleanup 2021-03-30 00:03:30 +03:00
krlvm c8b4685fc9
Fix ErrorActivity colors 2021-03-29 22:48:28 +03:00
krlvm c906cb57ee
Fix colors in setting fragments, cleanup 2021-03-29 21:19:17 +03:00
Tom 84de865daf
Allow the user to pause while a video is buffering (#5929) 
Fix pause while buffering
Use getPlayWhenReady wrapper everywhere playWhenReady is checked
Remove duplicate `playPause()` code
 2021-03-29 18:00:00 +02:00
krlvm 80d1c5b9f5
Fix Repeat Button color in Player 2021-03-28 22:04:54 +03:00
krlvm 67942a906a
Fix colors in PeerTube Settings Fragment 2021-03-28 19:36:07 +03:00
Mohammed Anas 6a9cae3de8
Add channel details option to long-press menu (#5851) 
Add dialog item to open channel details
Use `List` as type of `entries`
Put channel details item last
Only show channel option when channel is present
 2021-03-28 18:32:40 +02:00
krlvm 0afdac5683
Fix Light Player Popups in Dark Theme, make Player Controls Overlay always Dark 2021-03-28 18:48:51 +03:00
krlvm 609d09a8e2
Remove unused SuggestionListAdapter.resolveResourceIdFromAttr 2021-03-28 15:12:59 +03:00
krlvm 01e8654fbd
Fix Search colors on KitKat 2021-03-28 14:55:54 +03:00
krlvm f477ab84d5
Fix tab highlight opacity on KitKat 2021-03-28 14:43:11 +03:00
krlvm a9e8b3e06b
Remove ThemeHelper.resolveResourceIdFromAttr 2021-03-28 12:23:52 +03:00
Stypox daa5b7827a
Merge pull request #5879 from TacoTheDank/clean-oncreatepreferences 
Clean up unnecessary onCreate in settings fragments
 2021-03-28 10:48:10 +02:00
krlvm df52a6ea6b
Update app/src/main/java/org/schabi/newpipe/local/subscription/item/FeedImportExportItem.kt 
Co-authored-by: Stypox <stypox@pm.me>
 2021-03-28 00:15:22 +03:00
krlvm fd14c8cdce
Fix Dark elements in Light Theme 2021-03-27 17:46:05 +03:00
Stypox 08d8f2564a
Merge pull request #5882 from TacoTheDank/fragmentcontainerview 
Replace FrameLayout with FragmentContainerView where applicable
 2021-03-27 08:31:32 +01:00
krlvm b3e2418b93
Migrate to DayNight Theme 2021-03-26 23:08:25 +03:00
Tobi 80d6fff0ca
Merge pull request #5649 from FireMasterK/ff-ua 
Change UA to privacy.resistFingerprinting.
 2021-03-24 17:59:17 +01:00
Tobi fe43b4da39
Merge pull request #5896 from Stypox/fix-error-panel 
Fix error panel created in onViewCreated() but disposed in onDestroy()
 2021-03-24 11:32:07 +01:00
Stypox 0fcaf20221
Fix settings switches are not red anymore 
Reverts part of 731c65cd59
 2021-03-24 10:16:24 +01:00
Stypox 0277b94b37
Fix error panel created in onViewCreated() but disposed in onDestroy() 2021-03-24 09:27:17 +01:00
TacoTheDank 6a9d5fd4cc Replace FrameLayout with FragmentContainerView where applicable 2021-03-22 17:46:06 -04:00
TacoTheDank a83106f717 Clean up unnecessary onCreate in settings fragments 2021-03-22 16:38:36 -04:00
Matskidis Giannis bf6645e829
Show Toast when download starts 
Add toast to inform the user that download started and add the right string in values.
 2021-03-20 22:18:01 +01:00
Stypox 86381696f4
Merge pull request #5457 from Redirion/exo123 
Update to ExoPlayer 2.12.3
 2021-03-18 18:59:56 +01:00
Stypox 731c65cd59
Refactor ThemeHelper 2021-03-18 12:39:29 +01:00
bopol a85e8a29ff
Use a list for night themes 
Also remove unused strings
 2021-03-18 12:12:04 +01:00
bopol 22b2f52f8c
Use a switch preference to follow device theme 2021-03-18 11:23:55 +01:00
bopol a713ce2126
Add settings for device theme (dark & black) 
fix bugs related to isLightThemeSelected not handling device themes
such as license having dark background when it should be white
 2021-03-18 11:17:06 +01:00
Stypox 4fac3cf304
Merge pull request #5230 from Isira-Seneviratne/Update_prettytime 
Update prettytime.
 2021-03-18 08:59:40 +01:00
Isira Seneviratne 74e20a8c52 Use PrettyTime's new formatUnrounded(OffsetDateTime) method. 
Also change the types of the relevant variables from Calendar to OffsetDateTime.
 2021-03-18 06:38:12 +05:30
Stypox feb65cf8f3
Merge pull request #5792 from TeamNewPipe/resize_mode 
Fix last resize mode not being restored correctly
 2021-03-17 09:07:44 +01:00
Stypox 93592d23f4
Merge pull request #5820 from TeamNewPipe/mini_player_title 
Fix empty stream title in minimized player
 2021-03-17 08:56:50 +01:00
TobiGr 71d3227791 Fix bottom controls being out of the screen 
This was caused by too large end screen thumbnails enlarging the whole palyer. Fixed by scaling the thumbnail.

Ensure that the player does not use the whole screen height in detail fragment to keep the additional content like title, comments, etc. available.
 2021-03-14 17:52:15 +01:00
TobiGr 292e103073 Ignore ContentNotSupportedException caused by Bandcamp fan pages 2021-03-14 17:52:15 +01:00
Fynn Godau 39a3f03e79 Bandcamp support 2021-03-14 17:52:15 +01:00
Tobi 404a6c12a6
Merge pull request #5148 from Stypox/error-panel 
Show improved error panel instead of annoying snackbar or crashing
 2021-03-14 17:41:27 +01:00
Tobi 8271409afe
Merge pull request #5562 from mbarashkov/hardware_keyboard_space_shortcut_v2 
Implement "pause/play" toggle on hardware keyboard space button.
 2021-03-14 13:08:44 +01:00
TobiGr 985f659026 Fix empty stream title in minimized player 2021-03-13 20:12:57 +01:00
Stypox 285ea4e3fd
Better handle url not supported in RouterActivity 
Make sure the url not supported dialog is only shown when the url is really not supported, not on any ExtractionException
 2021-03-12 23:21:54 +01:00
Stypox 8ce18647f1
Improve email subject for error reporting 2021-03-12 23:21:54 +01:00
Stypox aee0478235
FeedFragment: fix view binding and show loading indicator correctly 2021-03-12 23:21:54 +01:00
Stypox c3cf1d81c2
Fix error panel and search fragment state saving 2021-03-12 23:21:54 +01:00
Stypox c2b6cec37d
Hide meta info panel in search when starting a new search 2021-03-12 23:21:54 +01:00
Stypox b265cabc22
Fix views not scrollable when showing error panel 2021-03-12 23:21:54 +01:00
Stypox 463dd8ea74
Completely remove return activity, now outdated 2021-03-12 23:21:54 +01:00
Stypox 1fc8e4c148
Optimize imports and solve checkstyle issues 2021-03-12 23:21:53 +01:00
Stypox c43bca6007
Add report/solve-recaptcha button in error panel 
It will be shown even when nothing could be loaded not due to a network error, and the user can choose to ignore or report it.

Also improve error reporting arguments
Also completely refactor error activity
Also improve some code here and there
 2021-03-12 23:21:49 +01:00
TobiGr 86fa629591 Fix last resize mode not being restored correctly 
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone thought while working on the resize mode switcher, that the old (to be replaced) resize mode should be stored. 
Fixes #5613
 2021-03-08 09:46:33 +01:00
Stypox 553b80164b
Move all error-related classes into error package 2021-03-07 17:49:28 +01:00
TiA4f8R 37a96d063f
Add different error messages for SoundCloud and YouTube unavailable contents 
Add new error strings for the six new exceptions created in the extractor and catch these exceptions. Extractor is, of course, updated with this PR.
 2021-03-07 15:33:25 +01:00
Isira Seneviratne d09070b61d Fix crash when reordering channel groups. 2021-02-28 14:48:06 +05:30
FireMasterK b236bb407b
Change UA to privacy.resistFingerprinting. 2021-02-20 16:49:37 +05:30
Stypox 8978187c64
Improve code style and fix some warnings 
Removed a textTrack null check on a now- NonNull method
Added a error type switch case (TIMEOUT)
 2021-02-16 16:54:44 +01:00
Robin eba0b07782
Update to ExoPlayer 2.12.3 2021-02-16 16:42:51 +01:00
XiangRongLin 5bc0a8fba1
Merge pull request #5554 from karkaminski/enhancement/remove_resizing_text 
removed resizing text from popup player
 2021-02-15 16:15:27 +01:00
Tobi 687020e595
Merge pull request #5543 from mhmdanas/remove-empty-string-concat 
Remove unnecessary concat with empty string
 2021-02-14 23:50:08 +01:00
Tobi 8c75b96c38
Merge pull request #5544 from mhmdanas/remove-content-uri 
Remove License#contentUri
 2021-02-14 23:49:07 +01:00
Tobi a26baa3061
Merge pull request #5563 from Stypox/fix-tablayout-visibility 
Fix tab layout visibility with age restricted videos
 2021-02-14 21:32:10 +01:00
Stypox 138513d790
Hide tab layout view pager on error 2021-02-14 13:40:17 +01:00
Stypox 1e5dc01825
Fix tab layout visibility with age restricted videos 
Add comments
 2021-02-14 13:25:39 +01:00
Mikhail Barashkov aea912f499 Implement "pause/play" toggle on hardware keyboard space button. 2021-02-12 11:58:15 +03:00
karol 156d7139fa removed resizig text from popup player, as requested in #5514 2021-02-11 11:20:27 +01:00
mhmdanas 092f9170cc Remove License#contentUri 
It seems to not be used anywhere.
 2021-02-08 19:54:30 +03:00
mhmdanas b820e9a888 Remove unnecessary concat with empty string 2021-02-08 19:40:20 +03:00
Tobi 40195b2d98
Merge pull request #5464 from Stypox/fix-channel-subscribe-button 
Fix channel subscribe button causing crash on closing
 2021-02-03 09:24:26 +01:00
Tobi 0b0305eaed
Merge pull request #5474 from XiangRongLin/expires_header 
Respect expires header when checking for new versions
 2021-01-31 10:51:50 +01:00
TiA4f8R c55f87c962
Fix some things in ShareUtils.java and do little improvements 
Fix a bug in which NewPipe doesn't fall back to Google Play Store web url in InstallApp
Fusion getDefaultBrowserPackageName and getDefaultAppPackageName, rename openInDefaultApp to openAppChooser
Update some JavaDocs
 2021-01-30 15:55:44 +01:00
XiangRongLin bdc85b435c
Add comments explaining the expiry field 
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
 2021-01-30 14:24:25 +01:00
XiangRongLin e98838ad7e
Invert usage of manager.isExpired() 
When it's expired it means, that the app should get the data. Meaning it should not abort prematurely by returning null.

Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
 2021-01-30 09:32:17 +01:00
Stypox 02db971b7c
Set all default settings at the beginning 2021-01-28 18:28:29 +01:00
Stypox fdb0f01b38
Add Objects.requireNotNull to warning which is surely not null 2021-01-28 14:35:47 +01:00
Stypox 376cba696e
Remove useless getString for default setting value 2021-01-28 14:35:00 +01:00
Stypox cade272501
Use PlayerHelper.retrieveResizeModeFromPrefs in Player 2021-01-28 14:33:50 +01:00
Stypox 4f828fbe00
Fix always minimizing to popup player 2021-01-28 14:33:12 +01:00
XiangRongLin 2926cb7682 Respect expires header when checking for new version 
It was called to many times and acted similar to a DOS attack.
 2021-01-23 09:02:11 +01:00
Tobias Groza cafc64534b
Merge pull request #5458 from Stypox/fix-popup-x 
Fix popup closing x button animation
 2021-01-22 10:01:12 +01:00
Stypox 327fc742d3
Fix channel subscribe button causing crash in main page tab 
The binding was being set to null on onDestroyView() instead of in onDestroy()
 2021-01-21 15:31:50 +01:00
Stypox 10ec67854e
Fix number being shown instead of corresponding string resorce in feed 2021-01-20 10:44:44 +01:00
Isira Seneviratne a3c4a10721 Convert the abstract class DAOs to interfaces. 2021-01-20 06:29:50 +05:30
Stypox e327f7ba2c
Fix popup closing x button animation 2021-01-19 09:34:21 +01:00
TiA4f8R 9a65f02d5b
Fix crash when no browser is present and use an ACTION_CHOOSER intent in the app update notification (#5429) 
Fix crash when no browser is present and use an ACTION_CHOOSER intent for app update notification
Show a Toast when no app is present on user's device to open a content in an app and in a browser and use an ACTION_CHOOSER intent with the ACTION_VIEW intent put as an extra intent in the update notification.
 2021-01-18 21:45:36 +01:00
XiangRongLin 5814743d59
Merge pull request #5430 from Stypox/fix-feed 
Fix reload feed button does nothing
 2021-01-18 12:59:58 +01:00
Stypox fa7613b8d1
Refactor feed fragment 2021-01-18 11:43:05 +01:00
Stypox d3d05d613d
Fix reload feed button does nothing 
initListeners was being called before the bindings were assigned, and therefore the click listener was never setup
 2021-01-18 11:42:25 +01:00
XiangRongLin 23b5cd5b72
Merge pull request #5442 from Stypox/fix-close-popup 
Prevent IllegalArgumentException when closing popup
 2021-01-18 09:39:02 +01:00
Stypox d4a33603ab
Prevent IllegalArgumentException when closing popup 2021-01-18 08:27:49 +01:00
Stypox 3868243c2a
Animate secondary controls toggle 2021-01-17 15:59:29 +01:00
Stypox 243f539439
Use KoreUtil function 2021-01-17 15:46:00 +01:00
Stypox 71d92c8d1b
Hide tab layout in detail fragment when there is no space 2021-01-17 15:42:54 +01:00
Stypox e840d42fb9
Add content description to detail fragment tabs 2021-01-17 15:38:12 +01:00
Stypox 750c4ffbd3
Add preference to hide description tab in video details 2021-01-17 15:36:42 +01:00
Stypox 4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility 2021-01-17 15:34:24 +01:00
Stypox a314f55a17
Move description to a tab alongside related streams and comments 2021-01-17 15:26:25 +01:00
Stypox 78a9811fe3
Add a secondary control panel to video detail fragment 
It is shown when the user expands the description
It contains share, open in browser and play in kodi
 2021-01-17 15:12:29 +01:00
Isira Seneviratne fe92abde0e Use view binding in VideoDetailFragment. 2021-01-17 09:57:40 +05:30
Isira Seneviratne 01396923f1 Use the base Groupie library in ChannelItem. 2021-01-16 18:59:49 +05:30
Isira Seneviratne e0de66b1be Fix some issues. 2021-01-16 18:59:48 +05:30
Isira Seneviratne 77675b361f Use BindableItem in PickerSubscriptionItem. 2021-01-16 18:59:45 +05:30
Isira Seneviratne e2dd058430 Use BindableItem in PickerIconItem. 2021-01-16 18:55:42 +05:30
Isira Seneviratne a188125982 Use BindableItem in HeaderWithMenuItem. 2021-01-16 18:55:42 +05:30
Isira Seneviratne 9e5f079cf2 Use BindableItem in HeaderItem. 2021-01-16 18:55:41 +05:30
Isira Seneviratne 51a948bfcf Use BindableItem in FeedImportExportItem. 2021-01-16 18:55:41 +05:30