Stypox
abe6dfb99c
Merge pull request #9671 from Stypox/fix-toast-crash-api33
...
Fix popup enablement toast crash on API 33
2023-01-15 21:05:05 +01:00
Stypox
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
Isira Seneviratne
f766ef2033
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
Stypox
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
Isira Seneviratne
9514316be3
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
Stypox
b6e6d39985
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
Stypox
ad605e2c5a
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
Stypox
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
Isira Seneviratne
e8216b2e80
Apply code review suggestions.
2023-01-04 06:10:14 +05:30
Isira Seneviratne
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
Isira Seneviratne
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
Stypox
1bb166a9e8
Merge pull request #9553 from Redirion/exo182
...
Update ExoPlayer to 2.18.2
2023-01-02 18:21:53 +01:00
Stypox
7454b31788
Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback
...
Support audio only background for services only supporting video streams
2023-01-02 17:51:10 +01:00
Robin
f17155bb3f
Merge branch 'TeamNewPipe:dev' into exo182
2023-01-02 10:35:20 +01:00
Stypox
367ece8ffa
Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking
...
Seeking no longer pauses the played video
2022-12-31 19:19:21 +01:00
Stypox
661cd4c182
Merge pull request #9159 from Isira-Seneviratne/Refactor_VideoPlayerUi
...
Refactor VideoPlayerUi.
2022-12-31 19:01:19 +01:00
Stypox
69e8e4d63e
Merge pull request #9306 from Stypox/target-api-33
...
Set compileSdk and targetSdk to 33 (Android 13)
2022-12-31 14:49:30 +01:00
Stypox
231e677b16
Merge pull request #8895 from Isira-Seneviratne/SparseArrayCompat
...
Use SparseArrayCompat.
2022-12-28 20:37:05 +01:00
evermind
dfc46c3b6c
Support audio only background for services only supporting video streams
...
Some services may only have video streams and no separate audio streams available.
This commit will add audio background playback support for those services.
It uses the video source as audio source for background playback.
2022-12-17 21:17:42 +01:00
Robin
eea4f0f41c
Update ExoPlayer to 2.18.2
2022-12-16 17:53:56 +01:00
Jared Fantaye
12796920a3
Removed the wasPlaying variable
2022-12-10 21:56:04 +01:00
Isira Seneviratne
161007fe92
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-12-06 20:21:08 +05:30
Douile
e5f30a07bf
Only show "Enqueue next" when in the middle of the queue
...
Add a check that the queue position is not the last in the queue before
showing "Enqueue next".
Previously the "Enqueue next" action would always be shown if the queue
length was greater than one, this meant even if you were at the end of
the queue (when "Enqueue" would have the same effect as "Enqueue next")
the action would still be shown.
2022-12-04 18:20:50 +01:00
Isira Seneviratne
b0516fbf1d
Use BitmapCompat.createScaledBitmap().
2022-11-29 15:56:19 +01:00
Jared Fantaye
e5af1c93ae
Seeking no longer pauses the played video
2022-11-26 15:35:13 +01:00
Isira Seneviratne
8db90ba449
Use SparseArrayCompat for thumbnails.
2022-11-22 17:51:54 +05:30
Stypox
048b0972de
Set compileSdk and targetSdk to 33 (Android 13)
...
android:exported in now required in the manifest on all activities/services/receivers/providers. It was set to true for those that need to interact with outside apps or the OS, while others have exported=false.
This also required updating LeakCanary to the latest version as the older version being used was not using android:exported in AndroidManifest.xml.
2022-11-18 08:33:13 +01:00
Isira Seneviratne
a7989795e8
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-11-14 08:59:03 +05:30
Isira Seneviratne
3dc1adb69e
Add helper methods for adding PendingIntent mutability.
2022-11-07 17:12:22 +05:30
Isira Seneviratne
e333197ed5
Use OnClickListener and OnLongClickListener lambdas in the player UIs.
2022-11-03 05:09:35 +05:30
Stypox
9d2ab61993
Merge pull request #9203 from Callisto404/add-chapter-timestamp-share
...
Added timestamped link sharing from the start of a chapter with a long hold press
2022-10-30 22:31:09 +01:00
Daniel M
7f3da04fee
Added an "isYouTube" check to start of long click handler
2022-10-30 13:48:03 +11:00
Stypox
9524c6245d
Merge pull request #8747 from Isira-Seneviratne/Range_limit
...
Use range-limiting methods in more places.
2022-10-28 10:34:04 +02:00
Daniel M
83357ca67e
Added sharing a link with timestamp from a chapter into the long click for each chapter
2022-10-24 14:14:41 +11:00
Tobi
8bc8355b68
Merge pull request #8946 from HybridAU/add_play_queue_button_to_video_details_fragment
...
Add play queue button to video details fragment
2022-10-06 18:55:50 +02:00
HybridAU
9db0133a5b
Add play queue button to video details fragment
...
* Add play queue button to video details fragment
* Use existing ic_list icon
* Still open play queue even when queue is empty
* Change app:srcCompat to android:src
2022-09-14 21:00:44 +08:00
Stypox
ed87465565
Only update notification large icon when it changes
2022-08-28 23:14:02 +02:00
Stypox
f9109ebc81
Use player.getThumbnail() instead of field in VideoPlayerUi
2022-08-28 18:35:21 +02:00
Stypox
4a7af6f9ac
Remove thumbnail before sync, if outdated
...
Also refactor onPlaybackSynchronize and add comments
2022-08-28 18:32:27 +02:00
Stypox
7fbef35daa
Unify onThumbnailLoaded calls to ensure UIs always updated
2022-08-28 17:24:51 +02:00
litetex
59d1ded94e
Fixed sonar detected problems
...
+ Automatically fixed code style (imports)
2022-08-25 17:02:53 +02:00
Stypox
973a966011
Review suggestions
2022-08-25 17:02:53 +02:00
Stypox
510efaae97
Keep strong reference to Picasso thumbnail loading target
...
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
2022-08-25 17:02:52 +02:00
Stypox
11bd2369e5
Merge MediaSessionManager into MediaSessionPlayerUi
2022-08-25 17:02:52 +02:00
Stypox
f80d1dc48d
Let exoplayer decide when to update metadata
...
Though still make sure metadata is updated after the thumbnail is loaded.
This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
2022-08-25 17:02:52 +02:00
Stypox
8bff445ec3
Remove useless checks before updating metadata
...
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
2022-08-25 17:02:51 +02:00
Stypox
d73ca41cfe
Even when thumbnails should not be shown, set it to null in notification
...
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
2022-08-25 17:02:51 +02:00
Stypox
f3a9b81b67
Fix sometimes seeing outdated thumbnail in notification
...
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
2022-08-25 17:02:51 +02:00
Stypox
3cc43e9fb9
Fix thumbnail sometimes not set to media session metadata
...
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
2022-08-25 17:00:41 +02:00
Stypox
bc33322d4b
Remove useless MediaSessionCallback
...
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
2022-08-25 17:00:41 +02:00