lasers
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
10,976 Commits 6 Branches 132 Tags 124 MiB
Commit Graph

3835 Commits

Author SHA1 Message Date
AudricV 84d50da009
Restore player service start handling before player UI separation 
This behavior was present before 0.24.0 and the player UI separation and
avoided crashes for which their exception contained
"Context.startForegroundService() did not then call Service.startForeground()".

Some player nullability checks have been also added, and the player service is
now stopped when it has been started from a media button and there is nothing
to play.
 2023-11-15 23:21:20 +01:00
TobiGr 3d5a8af52b Fix inconsistency when LocalPlaylist is used as MainFragment tab 2023-10-02 02:56:30 +02:00
Yingwei Zheng 1cf670dad9 Fix inconsistency between user interaction and database commit order when re-adding videos to the playlist 2023-10-02 02:56:30 +02:00
Siddhesh Naik e80b6b3057
Add playlist name and video name to playlist sharing content (#10427) 
- Currently, only a list of videos separated by newline are added in
  the share content.
- This makes it difficult to identify a specific video in a list of
  Urls.
- Used string resources for the sharing content formats.
- Added a confirmation dialog for users to choose between sharing
  playlist formats.
- Added Playlist name as the header and corresponding video name for
  each video url in following format.

Playlist
- Music1: https://media-url1
- Music2: https://media-url2
- Music3: https://media-url3


Co-authored-by: TobiGr <tobigr@users.noreply.github.com>
 2023-09-26 11:11:33 +02:00
Tobi 1630e309fb
Merge pull request #9987 from Edwardsoen/add_high_resolution_to_default_option 
Include a high-resolution option in the default resolution settings.
 2023-09-24 17:54:18 +02:00
TobiGr 94c1438913 Use "done" button to close license dialogs. 
Rename string res "recaptcha_done_button" to "done".
 2023-09-23 13:56:49 +02:00
TobiGr e206a26a85 Restore license dialog buttons to open the SoftwareComponent's website 
Do not keep the active License but the active SoftwareComponent.
 2023-09-23 13:49:09 +02:00
TobiGr 242e20316b [AboutFragment / LicenseFragment] Fix license restore after rotation 
Do not restore last opened license after a rotation change when the license was closed earlier.

This commit adds onCancelListener and onDismissListener to the AlertDialogs which are used to display the licenses.
 2023-09-23 13:49:09 +02:00
Stypox bdc2aa2b39
Update extractor and remove DeobfuscateException 
In ErrorInfo it was treated separately from other ParsingExceptions, including by showing a customized message, which has now been removed.
 2023-09-22 10:43:37 +02:00
Stypox f8b756c8bc
Make question mark localizable 2023-09-22 10:14:45 +02:00
Stypox 027b829c38
Use @DrawableRes in PicassoHelper 2023-09-22 10:14:45 +02:00
Stypox 0085ca6416
Fix loading images from db even if disabled 2023-09-22 10:14:44 +02:00
Stypox 87dca0f7ec
Separate imageListToDbUrl from choosePreferredImage 
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
 2023-09-22 10:14:44 +02:00
Stypox 37af2c87e8
Fix possible NPE in PlayQueueNavigator 2023-09-22 10:14:44 +02:00
Stypox bf908f0b7d
Add documentation and fix SonarCloud issue 2023-09-22 10:14:44 +02:00
Stypox 8d463b9577
Further improve image resolution strategy 
Now using multiple comparison steps instead of magic values
 2023-09-22 10:14:44 +02:00
Stypox 4f7d206736
Display all thumbnails in description tab 2023-09-22 10:14:44 +02:00
Stypox 35073c780d
Implement better image selection strategy 2023-09-22 10:14:44 +02:00
Stypox 0a8f28b1c6
Add image quality preference 2023-09-22 10:14:43 +02:00
Stypox af2375948d
Support obtaining multiple images from the extractor 2023-09-22 09:57:33 +02:00
TobiGr 2a1b506d98 Improved accessibility of player interfaces 2023-09-21 12:20:00 +02:00
Stypox b798ff5c92
Merge pull request #10435 from TeamNewPipe/imp/codequality 
Improve codequality
 2023-09-20 21:24:44 +02:00
TobiGr 779ea19222 Fix doc formatting 2023-09-20 19:44:23 +02:00
Isira Seneviratne a1f2b7f8e8 Switch to Files.createDirectories() 2023-09-20 19:44:23 +02:00
TobiGr 0acc3532c9 Remove useless override 2023-09-20 15:42:09 +02:00
TobiGr 8bf2d996ea Reorder the modifiers to comply with the Java Language Specification. 2023-09-20 15:41:57 +02:00
TobiGr 748c2babe9 Add comments and annotations 2023-09-20 15:41:21 +02:00
TacoTheDank b1faed586d Replace MathUtils.clamp with Kotlin coerceIn 2023-09-19 16:32:37 -04:00
Stypox 725c18eada
Merge pull request #10165 from TeamNewPipe/fix/media-format 
Fix downloads of streams with missing MediaFormat
 2023-09-19 15:54:12 +02:00
Stypox 992bb5d7be
Simplify retrieveMediaFormatFromContentTypeHeader 
Also check for nullity
 2023-09-19 15:33:49 +02:00
TobiGr 8f83e39970 Fix three memory leaks 
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
 2023-09-19 00:13:16 +02:00
TobiGr 64da7a06c0
Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment 2023-09-18 23:22:32 +02:00
TobiGr 57eaa1bbe1
Apply review 
Co-Authored-By:  Audric V <74829229+AudricV@users.noreply.github.com>
 2023-09-18 23:22:32 +02:00
TobiGr 109d06b4bb
Deduplicate code to initialize ClickListeners on playlist controls 
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.

The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
 2023-09-18 23:22:32 +02:00
AudricV f2ee3859ab
Hide the upload date element on the About tab 
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
 2023-09-18 23:22:32 +02:00
AudricV 89dc44be61
Always show the About tab and support having no description 2023-09-18 23:22:32 +02:00
TobiGr 6ab8716e69
Extract actual feed loading code into separate method 
Increase readability
 2023-09-18 23:22:32 +02:00
TobiGr 5c7c382323
Add missing `@Override` annotations to setupMetadata() implementations 2023-09-18 23:22:32 +02:00
Stypox 78b4b9441e
Update NewPipeExtractor and adapt imports 2023-09-18 23:22:32 +02:00
Stypox 1519527356
Fix loading feed when a channel tab is empty 2023-09-18 23:22:32 +02:00
Stypox 6b3a178f2a
Show snackbar with feed loading errors 2023-09-18 23:22:32 +02:00
Stypox c48e702a50
Improve placeholder channel banner handling 
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
 2023-09-18 23:22:32 +02:00
Stypox 1061bce4f3
Add avatar and bannner URLs to channel About tab 2023-09-18 23:22:32 +02:00
Stypox 013d513450
Add space above channel description (About tab) 2023-09-18 23:22:32 +02:00
ThetaDev 28d952a643
feat: filter fetched channel tabs 2023-09-18 23:22:32 +02:00
ThetaDev 753a92055c
feat: add playlist controls to channel tab 2023-09-18 23:22:32 +02:00
Stypox 371f986773
Fix some code smells 2023-09-18 23:22:32 +02:00
Stypox a1e8b9be4e
Fix channel tabs in main page setting title themselves 2023-09-18 23:22:32 +02:00
Stypox c076a0f771
Channels are now an Info 
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
 2023-09-18 23:22:32 +02:00
ThetaDev b5893f3fa3
fix: notification menu option disappears when switching tabs 2023-09-18 23:22:32 +02:00