NewPipe/app/src/main/java/org/schabi/newpipe
Stypox 8d59812827
Fix channel avatar not loading correctly sometimes
The fix just involves removing some really outdated code (6 years ago) added in 33e29be7db (diff-38bd2cf1b92659b499c08e1cf6ac9ef384c7e13381b906f2f98c57cbb758756dR778) (blame: 9318bb5306/app/src/main/java/org/schabi/newpipe/detail/VideoItemDetailActivity.java (L778)).
What that code did was setting the 'buddy' image to the uploader avatar as a placeholder, and then setting the actual image if it existed and after it had loaded.
That code remained there up until now, but now it doesn't make sense anymore, since Picasso already takes care of setting placeholders.
The problem is, starting from #10066 the actual uploader image is set before (not after) those lines of code, making them do the wrong thing, i.e. always overwrite the currently set image.
But then why did the channel avatar image work normally sometimes?
My guess is that since Picasso loads images in the background, when opening a video from scratch setting the placeholder still happened before Picasso finished loading the image.
However when the image is already cached it's loaded much faster and therefore setting the placeholder happens after, effectively hiding the loaded image.
2023-12-10 15:12:38 +01:00
..
about Use "done" button to close license dialogs. 2023-09-23 13:56:49 +02:00
database Update app/src/main/java/org/schabi/newpipe/database/feed/dao/FeedDAO.kt 2023-11-23 17:12:16 +01:00
download Use ListHelper to get secondary audio streams for video-only streams 2023-09-24 18:23:45 +02:00
error Update extractor and remove DeobfuscateException 2023-09-22 10:43:37 +02:00
fragments Fix channel avatar not loading correctly sometimes 2023-12-10 15:12:38 +01:00
info_list Implement better image selection strategy 2023-09-22 10:14:44 +02:00
ktx Add reusable classes extending AnimatorListenerAdapter. 2022-08-05 06:08:13 +05:30
local Fix crash when setting the masking of the new feed items button if the context is null 2023-11-15 19:04:45 +01:00
player Fix crash with disabled thumbnails when trying to play a stream 2023-12-10 15:12:38 +01:00
settings Merge pull request #9987 from Edwardsoen/add_high_resolution_to_default_option 2023-09-24 17:54:18 +02:00
streams Fix doc formatting 2023-09-20 19:44:23 +02:00
util Merge pull request #10446 from AudricV/dl_improve_video_audio_stream_selection 2023-12-07 16:48:57 +01:00
views Fixed some Sonar warnings 2023-08-03 12:02:08 +02:00
App.java Implement better image selection strategy 2023-09-22 10:14:44 +02:00
BaseFragment.java Fix three memory leaks 2023-09-19 00:13:16 +02:00
DownloaderImpl.java Use Collectors.joining(). 2022-08-06 06:54:21 +05:30
ExitActivity.java Clean up pre-Lollipop checks 2022-07-13 19:02:24 +02:00
MainActivity.java Simplify MainActivity.tabSelected(MenuItem) 2023-08-19 21:58:44 +02:00
NewPipeDatabase.java Fixed the bug by replacing the thumbnail_url with the thumbnail_stream_id 2023-02-05 20:32:34 +01:00
NewVersionWorker.kt Update new version check to match new API structure 2023-12-10 15:12:38 +01:00
PanicResponderActivity.java Clean up pre-Lollipop checks 2022-07-13 19:02:24 +02:00
QueueItemMenuUtil.java Support obtaining multiple images from the extractor 2023-09-22 09:57:33 +02:00
RouterActivity.java Channels are now an Info 2023-09-18 23:22:32 +02:00