From 0ba03c552c6db9be25ebb9860d9e601eb3eae10a Mon Sep 17 00:00:00 2001 From: FireMasterK <20838718+FireMasterK@users.noreply.github.com> Date: Thu, 2 Sep 2021 00:35:56 +0530 Subject: [PATCH] Improve based on review/feedback. --- .../youtube/extractors/YoutubeStreamInfoItemExtractor.java | 3 ++- .../org/schabi/newpipe/extractor/stream/StreamInfoItem.java | 2 +- .../services/youtube/search/YoutubeSearchExtractorTest.java | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java index 344a01a4f..051aa2788 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java @@ -168,7 +168,8 @@ public class YoutubeStreamInfoItemExtractor implements StreamInfoItemExtractor { public String getUploaderAvatarUrl() throws ParsingException { if(videoInfo.has("channelThumbnailSupportedRenderers")) { - return JsonUtils.getArray(videoInfo, "channelThumbnailSupportedRenderers.channelThumbnailWithLinkRenderer.thumbnail.thumbnails").getObject(0).getString("url"); + return JsonUtils.getArray(videoInfo, "channelThumbnailSupportedRenderers.channelThumbnailWithLinkRenderer.thumbnail.thumbnails") + .getObject(0).getString("url"); } return null; diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java b/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java index 67431884c..8f2d42437 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java @@ -88,7 +88,7 @@ public class StreamInfoItem extends InfoItem { return uploaderAvatarUrl; } - public void setUploaderAvatarUrl(String uploaderAvatarUrl) { + public void setUploaderAvatarUrl(final String uploaderAvatarUrl) { this.uploaderAvatarUrl = uploaderAvatarUrl; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java index e5210c2ed..0ae7f88da 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java @@ -338,7 +338,7 @@ public class YoutubeSearchExtractorTest { @Test public void testUploaderAvatar() throws IOException, ExtractionException { final List items = extractor.getInitialPage().getItems(); - for (InfoItem item : items) { + for (final InfoItem item : items) { assertNotNull(((StreamInfoItem) item).getUploaderAvatarUrl()); } }