From 18846baba700b43b2072391d46c476f70925b785 Mon Sep 17 00:00:00 2001 From: AudricV <74829229+AudricV@users.noreply.github.com> Date: Sat, 15 Jul 2023 00:16:58 +0200 Subject: [PATCH] Add tabs and tags methods in tests interfaces and annotate all methods with the Test JUnit annotation These changes should help to detect tests as tests, when running a subset of tests or all tests. They should be also implemented in these interfaces' implementations (new and existing ones). Co-authored-by: ThetaDev --- .../services/BaseChannelExtractorTest.java | 15 ++++++-- .../extractor/services/BaseExtractorTest.java | 8 ++++- .../services/BaseListExtractorTest.java | 5 ++- .../services/BasePlaylistExtractorTest.java | 9 ++++- .../services/BaseSearchExtractorTest.java | 6 +++- .../services/BaseStreamExtractorTest.java | 34 +++++++++++++++++++ 6 files changed, 71 insertions(+), 6 deletions(-) diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseChannelExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseChannelExtractorTest.java index cb81dd137..c776ee514 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseChannelExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseChannelExtractorTest.java @@ -1,11 +1,22 @@ package org.schabi.newpipe.extractor.services; -@SuppressWarnings("unused") -public interface BaseChannelExtractorTest extends BaseListExtractorTest { +import org.junit.jupiter.api.Test; + +public interface BaseChannelExtractorTest extends BaseExtractorTest { + @Test void testDescription() throws Exception; + @Test void testAvatarUrl() throws Exception; + @Test void testBannerUrl() throws Exception; + @Test void testFeedUrl() throws Exception; + @Test void testSubscriberCount() throws Exception; + @Test void testVerified() throws Exception; + @Test + void testTabs() throws Exception; + @Test + void testTags() throws Exception; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java index 4ff51295b..071684ab5 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java @@ -1,10 +1,16 @@ package org.schabi.newpipe.extractor.services; -@SuppressWarnings("unused") +import org.junit.jupiter.api.Test; + public interface BaseExtractorTest { + @Test void testServiceId() throws Exception; + @Test void testName() throws Exception; + @Test void testId() throws Exception; + @Test void testUrl() throws Exception; + @Test void testOriginalUrl() throws Exception; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseListExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseListExtractorTest.java index fd119ac20..087e2e6ad 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseListExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseListExtractorTest.java @@ -1,7 +1,10 @@ package org.schabi.newpipe.extractor.services; -@SuppressWarnings("unused") +import org.junit.jupiter.api.Test; + public interface BaseListExtractorTest extends BaseExtractorTest { + @Test void testRelatedItems() throws Exception; + @Test void testMoreRelatedItems() throws Exception; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BasePlaylistExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BasePlaylistExtractorTest.java index cb092df4f..241bbbee5 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BasePlaylistExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BasePlaylistExtractorTest.java @@ -1,11 +1,18 @@ package org.schabi.newpipe.extractor.services; -@SuppressWarnings("unused") +import org.junit.jupiter.api.Test; + public interface BasePlaylistExtractorTest extends BaseListExtractorTest { + @Test void testThumbnailUrl() throws Exception; + @Test void testBannerUrl() throws Exception; + @Test void testUploaderName() throws Exception; + @Test void testUploaderAvatarUrl() throws Exception; + @Test void testStreamCount() throws Exception; + @Test void testUploaderVerified() throws Exception; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseSearchExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseSearchExtractorTest.java index ddfa27fb0..5c6c36ea2 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseSearchExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseSearchExtractorTest.java @@ -1,8 +1,12 @@ package org.schabi.newpipe.extractor.services; -@SuppressWarnings("unused") +import org.junit.jupiter.api.Test; + public interface BaseSearchExtractorTest extends BaseListExtractorTest { + @Test void testSearchString() throws Exception; + @Test void testSearchSuggestion() throws Exception; + @Test void testSearchCorrected() throws Exception; } diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseStreamExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseStreamExtractorTest.java index da418660a..a224a347d 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseStreamExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseStreamExtractorTest.java @@ -1,36 +1,70 @@ package org.schabi.newpipe.extractor.services; +import org.junit.jupiter.api.Test; + public interface BaseStreamExtractorTest extends BaseExtractorTest { + @Test void testStreamType() throws Exception; + @Test void testUploaderName() throws Exception; + @Test void testUploaderUrl() throws Exception; + @Test void testUploaderAvatarUrl() throws Exception; + @Test void testSubscriberCount() throws Exception; + @Test void testSubChannelName() throws Exception; + @Test void testSubChannelUrl() throws Exception; + @Test void testSubChannelAvatarUrl() throws Exception; + @Test void testThumbnailUrl() throws Exception; + @Test void testDescription() throws Exception; + @Test void testLength() throws Exception; + @Test void testTimestamp() throws Exception; + @Test void testViewCount() throws Exception; + @Test void testUploadDate() throws Exception; + @Test void testTextualUploadDate() throws Exception; + @Test void testLikeCount() throws Exception; + @Test void testDislikeCount() throws Exception; + @Test void testRelatedItems() throws Exception; + @Test void testAgeLimit() throws Exception; + @Test void testErrorMessage() throws Exception; + @Test void testAudioStreams() throws Exception; + @Test void testVideoStreams() throws Exception; + @Test void testSubtitles() throws Exception; + @Test void testGetDashMpdUrl() throws Exception; + @Test void testFrames() throws Exception; + @Test void testHost() throws Exception; + @Test void testPrivacy() throws Exception; + @Test void testCategory() throws Exception; + @Test void testLicence() throws Exception; + @Test void testLanguageInfo() throws Exception; + @Test void testTags() throws Exception; + @Test void testSupportInfo() throws Exception; }