Browse Source

Remove Checkstyle suppressions file and fix Checkstyle issues introduced in 24e8399 and 8c1041d

The Checkstyle suppressions file is now replaced by // CHECKSTYLE:OFF and // CHECKSTYLE:ON comments.
pull/843/head
TiA4f8R 3 months ago
parent
commit
3c3cd78676
No known key found for this signature in database GPG Key ID: E6D3E7F5949450DD
  1. 8
      checkstyle/checkstyle.xml
  2. 15
      checkstyle/suppressions.xml
  3. 3
      extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java
  4. 2
      extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java

8
checkstyle/checkstyle.xml

@ -20,12 +20,6 @@
<property name="fileNamePattern" value="module\-info\.java$"/>
</module>
<!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
<module name="SuppressionFilter">
<property name="file" value="${config_loc}/suppressions.xml" />
<property name="optional" value="true"/>
</module>
<!-- Checks that a package-info.java file exists for each package. -->
<!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
<!--<module name="JavadocPackage"/>-->
@ -68,6 +62,8 @@
<module name="SuppressWarningsFilter" />
<module name="SuppressWithPlainTextCommentFilter"/>
<module name="TreeWalker">
<!-- Checks for Javadoc comments. -->
<!-- See https://checkstyle.org/config_javadoc.html -->

15
checkstyle/suppressions.xml

@ -1,15 +0,0 @@
<?xml version="1.0"?>
<!DOCTYPE suppressions PUBLIC
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
<suppressions>
<!-- Use @SuppressWarnings("...") if it is possible, only use this file if it is not -->
<suppress checks="LineLength"
files="BandcampExtractorHelper.java"
lines="54"/>
<suppress checks="LineLength"
files="ItagItem.java"
lines="19"/>
</suppressions>

3
extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java

@ -54,7 +54,8 @@ public final class BandcampExtractorHelper {
/**
* Fetch artist details from mobile endpoint.
* <a href=https://notabug.org/fynngodau/bandcampDirect/wiki/rewindBandcamp+%E2%80%93+Fetching+artist+details>
* <a href="https://notabug.org/fynngodau/bandcampDirect/wiki/
* rewindBandcamp+%E2%80%93+Fetching+artist+details">
* More technical info.</a>
*/
public static JsonObject getArtistDetails(final String id) throws ParsingException {

2
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java

@ -18,7 +18,7 @@ import javax.annotation.Nonnull;
public class ItagItem {
/**
* List can be found here
* https://github.com/ytdl-org/youtube-dl/blob/9fc5eafb8e384453a49f7cfe73147be491f0b19d/youtube_dl/extractor/youtube.py#L1071
* https://github.com/ytdl-org/youtube-dl/blob/9fc5eaf/youtube_dl/extractor/youtube.py#L1071
*/
private static final ItagItem[] ITAG_LIST = {
/////////////////////////////////////////////////////

Loading…
Cancel
Save