From 3c3cd786760cc891816c5f80122956691bb8a326 Mon Sep 17 00:00:00 2001 From: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com> Date: Mon, 2 May 2022 21:37:49 +0200 Subject: [PATCH] Remove Checkstyle suppressions file and fix Checkstyle issues introduced in 24e8399 and 8c1041d The Checkstyle suppressions file is now replaced by // CHECKSTYLE:OFF and // CHECKSTYLE:ON comments. --- checkstyle/checkstyle.xml | 8 ++------ checkstyle/suppressions.xml | 15 --------------- .../extractors/BandcampExtractorHelper.java | 3 ++- .../extractor/services/youtube/ItagItem.java | 2 +- 4 files changed, 5 insertions(+), 23 deletions(-) delete mode 100644 checkstyle/suppressions.xml diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml index 4a82f6be3..ff0f91a94 100644 --- a/checkstyle/checkstyle.xml +++ b/checkstyle/checkstyle.xml @@ -20,12 +20,6 @@ - - - - - - @@ -68,6 +62,8 @@ + + diff --git a/checkstyle/suppressions.xml b/checkstyle/suppressions.xml deleted file mode 100644 index e51dee8f4..000000000 --- a/checkstyle/suppressions.xml +++ /dev/null @@ -1,15 +0,0 @@ - - - - - - - - - diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java index 54c1a68eb..1ce6ac0d0 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java @@ -54,7 +54,8 @@ public final class BandcampExtractorHelper { /** * Fetch artist details from mobile endpoint. - * + * * More technical info. */ public static JsonObject getArtistDetails(final String id) throws ParsingException { diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java index 428f96433..55d3082a2 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java @@ -18,7 +18,7 @@ import javax.annotation.Nonnull; public class ItagItem { /** * List can be found here - * https://github.com/ytdl-org/youtube-dl/blob/9fc5eafb8e384453a49f7cfe73147be491f0b19d/youtube_dl/extractor/youtube.py#L1071 + * https://github.com/ytdl-org/youtube-dl/blob/9fc5eaf/youtube_dl/extractor/youtube.py#L1071 */ private static final ItagItem[] ITAG_LIST = { /////////////////////////////////////////////////////