From 593122342fe9dbce1bf6dac081b81dd271a2871a Mon Sep 17 00:00:00 2001 From: AudricV <74829229+AudricV@users.noreply.github.com> Date: Mon, 3 Oct 2022 18:31:50 +0200 Subject: [PATCH] [YouTube] Improve YoutubeSuggestionExtractorTest - Remove useless concatenation on the downloader path; - Remove unneeded public test modifier; - Update license header; - Specify the service class tested instead of the generic class. --- .../YoutubeSuggestionExtractorTest.java | 21 ++++++++++--------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeSuggestionExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeSuggestionExtractorTest.java index 38c925371..b0fa95005 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeSuggestionExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeSuggestionExtractorTest.java @@ -1,25 +1,25 @@ -package org.schabi.newpipe.extractor.services.youtube; - /* * Created by Christian Schabesberger on 18.11.16. * * Copyright (C) Christian Schabesberger 2016 - * YoutubeSuggestionExtractorTest.java is part of NewPipe. + * YoutubeSuggestionExtractorTest.java is part of NewPipe Extractor. * - * NewPipe is free software: you can redistribute it and/or modify + * NewPipe Extractor is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * - * NewPipe is distributed in the hope that it will be useful, + * NewPipe Extractor is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with NewPipe. If not, see . + * along with NewPipe Extractor. If not, see . */ +package org.schabi.newpipe.extractor.services.youtube; + import static org.junit.jupiter.api.Assertions.assertFalse; import static org.schabi.newpipe.extractor.ServiceList.YouTube; @@ -29,14 +29,15 @@ import org.schabi.newpipe.downloader.DownloaderFactory; import org.schabi.newpipe.extractor.NewPipe; import org.schabi.newpipe.extractor.exceptions.ExtractionException; import org.schabi.newpipe.extractor.localization.Localization; +import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSuggestionExtractor; import org.schabi.newpipe.extractor.suggestion.SuggestionExtractor; import java.io.IOException; /** - * Test for {@link SuggestionExtractor} + * Test for {@link YoutubeSuggestionExtractor} */ -public class YoutubeSuggestionExtractorTest { +class YoutubeSuggestionExtractorTest { private static final String RESOURCE_PATH = DownloaderFactory.RESOURCE_PATH + "services/youtube/extractor/suggestions/"; @@ -45,12 +46,12 @@ public class YoutubeSuggestionExtractorTest { @BeforeAll public static void setUp() throws Exception { YoutubeTestsUtils.ensureStateless(); - NewPipe.init(DownloaderFactory.getDownloader(RESOURCE_PATH + ""), new Localization("de", "DE")); + NewPipe.init(DownloaderFactory.getDownloader(RESOURCE_PATH), new Localization("de", "DE")); suggestionExtractor = YouTube.getSuggestionExtractor(); } @Test - public void testIfSuggestions() throws IOException, ExtractionException { + void testIfSuggestions() throws IOException, ExtractionException { assertFalse(suggestionExtractor.suggestionList("hello").isEmpty()); } }