Legitimately suppress remaining checkstyle warnings

pull/817/head
Stypox 9 months ago committed by litetex
parent 740a37a2de
commit bdadcfa1f7
  1. 15
      checkstyle/suppressions.xml
  2. 1
      extractor/src/main/java/org/schabi/newpipe/extractor/MediaFormat.java
  3. 1
      extractor/src/main/java/org/schabi/newpipe/extractor/ServiceList.java
  4. 4
      extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypter.java
  5. 1
      extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java
  6. 1
      extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
  7. 1
      extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java

@ -0,0 +1,15 @@
<?xml version="1.0"?>
<!DOCTYPE suppressions PUBLIC
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
<suppressions>
<!-- Use @SuppressWarnings("...") if it is possible, only use this file if it is not -->
<suppress checks="LineLength"
files="BandcampExtractorHelper.java"
lines="54"/>
<suppress checks="LineLength"
files="ItagItem.java"
lines="19"/>
</suppressions>

@ -29,6 +29,7 @@ import java.util.function.Function;
* Static data about various media formats support by NewPipe, eg mime type, extension
*/
@SuppressWarnings("MethodParamPad") // we want the media format table below to be aligned
public enum MediaFormat {
// @formatter:off
//video and audio combined formats

@ -31,6 +31,7 @@ import java.util.List;
/**
* A list of supported services.
*/
@SuppressWarnings({"ConstantName", "InnerAssignment"}) // keep unusual names and inner assignments
public final class ServiceList {
private ServiceList() {
//no instance

@ -39,8 +39,8 @@ public class YoutubeThrottlingDecrypter {
"b=a\\.get\\(\"n\"\\)\\)&&\\(b=(\\S+)\\(b\\),a\\.set\\(\"n\",b\\)");
private static final Map<String, String> N_PARAMS_CACHE = new HashMap<>();
private static String FUNCTION;
private static String FUNCTION_NAME;
@SuppressWarnings("StaticVariableName") private static String FUNCTION;
@SuppressWarnings("StaticVariableName") private static String FUNCTION_NAME;
private final String functionName;
private final String function;

@ -279,6 +279,7 @@ public class YoutubeMusicSearchExtractor extends SearchExtractor {
return new InfoItemsPage<>(collector, getNextPageFrom(continuations));
}
@SuppressWarnings("MethodLength")
private void collectMusicStreamsFrom(final MultiInfoItemsCollector collector,
@Nonnull final JsonArray videos) {
final TimeAgoParser timeAgoParser = getTimeAgoParser();

@ -81,6 +81,7 @@ public final class YoutubeStreamLinkHandlerFactory extends LinkHandlerFactory {
return "https://www.youtube.com/watch?v=" + id;
}
@SuppressWarnings("AvoidNestedBlocks")
@Override
public String getId(final String theUrlString)
throws ParsingException, IllegalArgumentException {

@ -211,6 +211,7 @@ public class StreamInfo extends Info {
}
}
@SuppressWarnings("MethodLength")
private static void extractOptionalData(final StreamInfo streamInfo,
final StreamExtractor extractor) {
/* ---- optional data goes here: ---- */

Loading…
Cancel
Save