From c57016b79bbc2fac0e6920e1cc2de7e1fe15f6f1 Mon Sep 17 00:00:00 2001 From: Stypox Date: Wed, 27 Mar 2024 15:26:06 +0100 Subject: [PATCH] Make getCommentText @Nonnull --- .../schabi/newpipe/extractor/comments/CommentsInfoItem.java | 6 ++++-- .../extractor/comments/CommentsInfoItemExtractor.java | 1 + .../extractors/BandcampCommentsInfoItemExtractor.java | 1 + .../extractors/PeertubeCommentsInfoItemExtractor.java | 1 + .../extractors/SoundcloudCommentsInfoItemExtractor.java | 1 + .../extractors/YoutubeCommentsInfoItemExtractor.java | 1 + 6 files changed, 9 insertions(+), 2 deletions(-) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java b/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java index f45c8f0d4..1b4379f80 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java @@ -13,7 +13,8 @@ import java.util.List; public class CommentsInfoItem extends InfoItem { private String commentId; - private Description commentText; + @Nonnull + private Description commentText = Description.EMPTY_DESCRIPTION; private String uploaderName; @Nonnull private List uploaderAvatars = List.of(); @@ -50,11 +51,12 @@ public class CommentsInfoItem extends InfoItem { this.commentId = commentId; } + @Nonnull public Description getCommentText() { return commentText; } - public void setCommentText(final Description commentText) { + public void setCommentText(@Nonnull final Description commentText) { this.commentText = commentText; } diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java index e78c61daf..7bae95c2c 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java @@ -45,6 +45,7 @@ public interface CommentsInfoItemExtractor extends InfoItemExtractor { /** * The text of the comment */ + @Nonnull default Description getCommentText() throws ParsingException { return Description.EMPTY_DESCRIPTION; } diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampCommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampCommentsInfoItemExtractor.java index 1a9f691c3..4c23c1e01 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampCommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampCommentsInfoItemExtractor.java @@ -38,6 +38,7 @@ public class BandcampCommentsInfoItemExtractor implements CommentsInfoItemExtrac return getUploaderAvatars(); } + @Nonnull @Override public Description getCommentText() throws ParsingException { return new Description(review.getString("why"), Description.PLAIN_TEXT); diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeCommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeCommentsInfoItemExtractor.java index 0c9145af0..57a044490 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeCommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeCommentsInfoItemExtractor.java @@ -77,6 +77,7 @@ public class PeertubeCommentsInfoItemExtractor implements CommentsInfoItemExtrac return new DateWrapper(parseDateFrom(textualUploadDate)); } + @Nonnull @Override public Description getCommentText() throws ParsingException { final String htmlText = JsonUtils.getString(item, "text"); diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudCommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudCommentsInfoItemExtractor.java index 46194a3b6..5ff6d29db 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudCommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudCommentsInfoItemExtractor.java @@ -29,6 +29,7 @@ public class SoundcloudCommentsInfoItemExtractor implements CommentsInfoItemExtr return Objects.toString(json.getLong("id"), null); } + @Nonnull @Override public Description getCommentText() { return new Description(json.getString("body"), Description.PLAIN_TEXT); diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java index 16740407d..06b68fe5e 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java @@ -184,6 +184,7 @@ public class YoutubeCommentsInfoItemExtractor implements CommentsInfoItemExtract } } + @Nonnull @Override public Description getCommentText() throws ParsingException { try {