lasers
/
NewPipeExtractor
mirror of https://github.com/TeamNewPipe/NewPipeExtractor
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[MediaCCC] Fix comments about containsSimilarStream

This commit is contained in:
Stypox 2022-05-20 11:06:58 +02:00 committed by TiA4f8R
parent 044639c32b
commit d652e05874
No known key found for this signature in database
GPG Key ID: E6D3E7F5949450DD
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java
View File

@ -114,9 +114,9 @@ public class MediaCCCStreamExtractor extends StreamExtractor {
mediaFormat = null;
}
// Don't use the containsSimilarStream method because it will always return
// false. So if there are multiple audio streams available, only the first one will
// be extracted in this case.
// Not checking containsSimilarStream here, since MediaCCC does not provide enough
// information to decide whether two streams are similar. Hence that method would
// always return false, e.g. even for different language variations.
audioStreams.add(new AudioStream.Builder()
.setId(recording.getString("filename", ID_UNKNOWN))
.setContent(recording.getString("recording_url"), true)
@ -137,7 +137,6 @@ public class MediaCCCStreamExtractor extends StreamExtractor {
final String mimeType = recording.getString("mime_type");
if (mimeType.startsWith("video")) {
// First we need to resolve the actual video data from the CDN
final MediaFormat mediaFormat;
if (mimeType.endsWith("webm")) {
mediaFormat = MediaFormat.WEBM;
@ -147,9 +146,9 @@ public class MediaCCCStreamExtractor extends StreamExtractor {
mediaFormat = null;
}
// Don't use the containsSimilarStream method because it will prevent the
// extraction of some video variations (mostly languages). So if there are multiple
// video streams available, only the first one will be extracted in this case.
// Not checking containsSimilarStream here, since MediaCCC does not provide enough
// information to decide whether two streams are similar. Hence that method would
// always return false, e.g. even for different language variations.
videoStreams.add(new VideoStream.Builder()
.setId(recording.getString("filename", ID_UNKNOWN))
.setContent(recording.getString("recording_url"), true)