mirrors
/
kore
mirror of https://git.kore.io/kore.git
1
0
Fork 1
Code Issues Projects Releases Wiki Activity

Python: Improve the kore.socket interface. 

- Make sure PyBuffer_Release() is called for y* arguments.
- Make sure buffer is cleaned up for SENDTO socket ops as well.
This commit is contained in:
Joris Vink 2020-08-11 15:24:59 +02:00
parent 68d078766e
commit 7613a4a135
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/python.c
View File

@ -2804,11 +2804,15 @@ static PyObject *
pysocket_send(struct pysocket *sock, PyObject *args)
{
Py_buffer buf;
PyObject *ret;
if (!PyArg_ParseTuple(args, "y*", &buf))
return (NULL);
return (pysocket_op_create(sock, PYSOCKET_TYPE_SEND, buf.buf, buf.len));
ret = pysocket_op_create(sock, PYSOCKET_TYPE_SEND, buf.buf, buf.len);
PyBuffer_Release(&buf);
return (ret);
}
static PyObject *
@ -2839,6 +2843,7 @@ pysocket_sendto(struct pysocket *sock, PyObject *args)
}
ret = pysocket_op_create(sock, PYSOCKET_TYPE_SENDTO, buf.buf, buf.len);
PyBuffer_Release(&buf);
op = (struct pysocket_op *)ret;
@ -2990,7 +2995,8 @@ pysocket_op_dealloc(struct pysocket_op *op)
{
if (op->type == PYSOCKET_TYPE_RECV ||
op->type == PYSOCKET_TYPE_RECVFROM ||
op->type == PYSOCKET_TYPE_SEND)
op->type == PYSOCKET_TYPE_SEND ||
op->type == PYSOCKET_TYPE_SENDTO)
kore_buf_cleanup(&op->buffer);
switch (op->type) {
@ -3941,6 +3947,8 @@ pyproc_send(struct pyproc *proc, PyObject *args)
ret = pysocket_op_create(proc->in,
PYSOCKET_TYPE_SEND, buf.buf, buf.len);
PyBuffer_Release(&buf);
return (ret);
}