From 7b99d98c553f40ec4d633d0d4fdf65f275c80e77 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Tue, 24 Nov 2020 12:32:42 +0200 Subject: [PATCH] Replace all use of + href='#' with proper buttons --- src/App.scss | 32 +++++++++-- .../account_actions/account_actions.vue | 14 ++--- .../async_component_error.vue | 2 +- src/components/attachment/attachment.js | 6 ++- src/components/attachment/attachment.vue | 28 ++++++---- src/components/block_card/block_card.vue | 4 +- src/components/chat_list/chat_list.vue | 5 +- src/components/chat_message/chat_message.scss | 3 -- src/components/chat_message/chat_message.vue | 4 +- src/components/conversation/conversation.vue | 13 ++--- src/components/desktop_nav/desktop_nav.scss | 10 ++-- src/components/desktop_nav/desktop_nav.vue | 40 +++++++------- .../domain_mute_card/domain_mute_card.vue | 4 +- .../emoji_reactions/emoji_reactions.vue | 2 +- .../export_import/export_import.vue | 4 +- src/components/exporter/exporter.vue | 2 +- .../extra_buttons/extra_buttons.vue | 28 +++++----- .../favorite_button/favorite_button.js | 5 -- .../favorite_button/favorite_button.vue | 38 ++++++------- .../follow_button/follow_button.vue | 2 +- .../follow_request_card.vue | 4 +- .../image_cropper/image_cropper.vue | 6 +-- src/components/importer/importer.vue | 2 +- src/components/login_form/login_form.vue | 2 +- src/components/media_upload/media_upload.vue | 54 ++++++++----------- src/components/mfa_form/recovery_form.vue | 14 ++--- src/components/mfa_form/totp_form.vue | 14 ++--- src/components/mobile_nav/mobile_nav.vue | 14 +++-- .../mobile_post_status_button.vue | 2 +- .../moderation_tools/moderation_tools.vue | 6 +-- src/components/mute_card/mute_card.vue | 4 +- src/components/notification/notification.vue | 13 +++-- .../notifications/notifications.vue | 8 +-- .../password_reset/password_reset.vue | 2 +- src/components/poll/poll.vue | 2 +- .../post_status_form/post_status_form.vue | 34 ++++++------ src/components/react_button/react_button.vue | 13 +++-- src/components/registration/registration.vue | 2 +- src/components/reply_button/reply_button.vue | 19 ++++--- .../retweet_button/retweet_button.js | 5 -- .../retweet_button/retweet_button.vue | 48 ++++++++--------- src/components/search_bar/search_bar.vue | 32 ++++++----- .../settings_modal/settings_modal.vue | 4 +- .../tabs/mutes_and_blocks_tab.vue | 10 ++-- .../settings_modal/tabs/notifications_tab.vue | 2 +- .../settings_modal/tabs/profile_tab.vue | 8 +-- .../tabs/security_tab/confirm.vue | 4 +- .../settings_modal/tabs/security_tab/mfa.vue | 10 ++-- .../tabs/security_tab/mfa_totp.vue | 4 +- .../tabs/security_tab/security_tab.vue | 10 ++-- .../settings_modal/tabs/theme_tab/preview.vue | 4 +- .../tabs/theme_tab/theme_tab.vue | 28 +++++----- .../shadow_control/shadow_control.vue | 8 +-- src/components/side_drawer/side_drawer.vue | 15 +++--- src/components/status/status.vue | 35 ++++++------ .../status_content/status_content.vue | 37 ++++++------- src/components/tab_switcher/tab_switcher.js | 2 +- src/components/timeline/timeline.vue | 8 +-- src/components/user_card/user_card.vue | 10 ++-- .../user_reporting_modal.vue | 2 +- 60 files changed, 384 insertions(+), 363 deletions(-) diff --git a/src/App.scss b/src/App.scss index ca7d33cd93..ef2a13b1ba 100644 --- a/src/App.scss +++ b/src/App.scss @@ -33,6 +33,7 @@ h4 { max-width: 980px; align-content: flex-start; } + .underlay { background-color: rgba(0,0,0,0.15); background-color: var(--underlay, rgba(0,0,0,0.15)); @@ -69,7 +70,7 @@ a { color: var(--link, $fallback--link); } -button { +.button-default { user-select: none; color: $fallback--text; color: var(--btnText, $fallback--text); @@ -85,7 +86,9 @@ button { font-family: sans-serif; font-family: var(--interfaceFont, sans-serif); - i[class*=icon-], .svg-inline--fa { + i[class*=icon-], + :not(&.-icon), + .svg-inline--fa { color: $fallback--text; color: var(--btnText, $fallback--text); } @@ -149,6 +152,29 @@ button { } } +.button-unstyled { + background: none; + border: none; + outline: none; + display: inline; + text-align: initial; + font-size: 100%; + font-family: inherit; + padding: 0; + line-height: unset; + cursor: pointer; + + &.-link { + color: $fallback--link; + color: var(--link, $fallback--link); + } + + &.-padded { + padding: 5px; + margin: -5px; + } +} + input, textarea, .select, .input { &.unstyled { @@ -797,7 +823,7 @@ nav { } } -.btn.btn-default { +.btn.button-default { min-height: 28px; } diff --git a/src/components/account_actions/account_actions.vue b/src/components/account_actions/account_actions.vue index e3ae376e26..c10b09b8aa 100644 --- a/src/components/account_actions/account_actions.vue +++ b/src/components/account_actions/account_actions.vue @@ -13,14 +13,14 @@ diff --git a/src/components/chat_message/chat_message.scss b/src/components/chat_message/chat_message.scss index 5af744a358..e4351d3b80 100644 --- a/src/components/chat_message/chat_message.scss +++ b/src/components/chat_message/chat_message.scss @@ -31,9 +31,6 @@ color: $fallback--text; color: var(--text, $fallback--text); } - - border-radius: $fallback--chatMessageRadius; - border-radius: var(--chatMessageRadius, $fallback--chatMessageRadius); } .popover { diff --git a/src/components/chat_message/chat_message.vue b/src/components/chat_message/chat_message.vue index 3849ab6e7a..0777f8809f 100644 --- a/src/components/chat_message/chat_message.vue +++ b/src/components/chat_message/chat_message.vue @@ -53,7 +53,7 @@
- - + - + + + diff --git a/src/components/domain_mute_card/domain_mute_card.vue b/src/components/domain_mute_card/domain_mute_card.vue index 97aee2431a..3b5aec141b 100644 --- a/src/components/domain_mute_card/domain_mute_card.vue +++ b/src/components/domain_mute_card/domain_mute_card.vue @@ -6,7 +6,7 @@ {{ $t('domain_mute_card.unmute') }}