From f01dce99df94e5ccf94a1ff3287d347b71d676b4 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Mon, 28 Dec 2020 11:32:52 +0200 Subject: [PATCH 1/3] update changelog with latest release --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 83bcee6ebf..243435f185 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] + +## [2.2.2] - 2020-12-22 ### Added - Mouseover titles for emojis in reaction picker - Support to input emoji into the search box in reaction picker From 243383852ba59d5787eaccdca157c6e809f49449 Mon Sep 17 00:00:00 2001 From: Shpuld Shpuldson Date: Mon, 28 Dec 2020 17:08:15 +0200 Subject: [PATCH 2/3] make with-load-more not use computeds when they don't work for it --- CHANGELOG.md | 2 ++ src/hocs/with_load_more/with_load_more.js | 16 ++++++++++------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 243435f185..9f516b8e18 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] +### Fixed +- Follows/Followers tabs on user profiles now display the content properly. ## [2.2.2] - 2020-12-22 ### Added diff --git a/src/hocs/with_load_more/with_load_more.js b/src/hocs/with_load_more/with_load_more.js index 7df9dbb2f2..671b2b6f70 100644 --- a/src/hocs/with_load_more/with_load_more.js +++ b/src/hocs/with_load_more/with_load_more.js @@ -29,12 +29,8 @@ const withLoadMore = ({ return { loading: false, bottomedOut: false, - error: false - } - }, - computed: { - entries () { - return select(this.$props, this.$store) || [] + error: false, + entries: [] } }, created () { @@ -48,6 +44,11 @@ const withLoadMore = ({ destroy && destroy(this.$props, this.$store) }, methods: { + // Entries is not a computed because computed can't track the dynamic + // selector for changes and won't trigger after fetch. + updateEntries () { + this.entries = select(this.$props, this.$store) || [] + }, fetchEntries () { if (!this.loading) { this.loading = true @@ -61,6 +62,9 @@ const withLoadMore = ({ this.loading = false this.error = true }) + .finally(() => { + this.updateEntries() + }) } }, scrollLoad (e) { From a36922ae1b349670112287977a171bfa0c60c690 Mon Sep 17 00:00:00 2001 From: Mark Felder Date: Mon, 28 Dec 2020 13:27:13 -0600 Subject: [PATCH 3/3] Newer chromedriver works on MacOS aarch64 https://github.com/giggio/node-chromedriver/commit/469dd0a6ee23540bfa832b5f09b4cbde3e152010 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 14738c3eb3..ea1d9a9b6f 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "babel-plugin-lodash": "^3.3.4", "chai": "^3.5.0", "chalk": "^1.1.3", - "chromedriver": "^2.21.2", + "chromedriver": "^87.0.1", "connect-history-api-fallback": "^1.1.0", "cross-spawn": "^4.0.2", "css-loader": "^0.28.0",