improve test readability

test/web/activity_pub/activity_pub_test.exs

@@ -610,14 +610,14 @@ defmodule Pleroma.Web.ActivityPub.ActivityPubTest do
     {:ok, activity_three} = CommonAPI.post(user, %{"status" => "HI!!!"})
 
     CommonAPI.pin(activity_one.id, user)
+    user = refresh_record(user)
 
-    user = User.get_by_ap_id(user.ap_id)
     CommonAPI.pin(activity_two.id, user)
+    user = refresh_record(user)
 
-    user = User.get_by_ap_id(user.ap_id)
     CommonAPI.pin(activity_three.id, user)
+    user = refresh_record(user)
 
-    user = User.get_by_ap_id(user.ap_id)
     activities = ActivityPub.fetch_user_activities(user, nil, %{"pinned" => "true"})
 
     assert 3 = length(activities)

test/web/common_api/common_api_test.exs

@@ -116,7 +116,7 @@ defmodule Pleroma.Web.CommonAPI.Test do
 
       assert {:ok, ^activity_one} = CommonAPI.pin(activity_one.id, user)
 
-      user = User.get_by_ap_id(user.ap_id)
+      user = refresh_record(user)
 
       assert {:error, "You have already pinned the maximum number of statuses"} =
                CommonAPI.pin(activity_two.id, user)

test/web/mastodon_api/mastodon_api_controller_test.exs

@@ -1522,7 +1522,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do
       {:ok, _} = CommonAPI.pin(activity.id, user)
 
       id_str = Integer.to_string(activity.id)
-      user = User.get_by_ap_id(user.ap_id)
+      user = refresh_record(user)
 
       assert %{"id" => ^id_str, "pinned" => false} =
                conn
@@ -1556,7 +1556,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do
                |> Map.get(:resp_body)
                |> Jason.decode!()
 
-      user = User.get_by_ap_id(user.ap_id)
+      user = refresh_record(user)
 
       assert %{"error" => "You have already pinned the maximum number of statuses"} =
                conn