FWGS/Paranoia2
2
0
Fork 2
forked from a1batross/Paranoia2_original
Code Issues Pull Requests 1 Releases Wiki Activity

master #1

Closed
nillerusr wants to merge 3 commits from nillerusr/Paranoia2:master into master
pull from: nillerusr/Paranoia2:master
merge into: FWGS:master
Conversation 0 Commits 3 Files Changed 16 +163 -63
nillerusr commented 2020-11-16 10:29:02 +01:00
First-time contributor
Copy Link

port bsp31migrate to linux

port bsp31migrate to linux
a1batross reviewed 2020-11-16 13:24:11 +01:00
utils/bsp31migrate/bspfile.cpp
@ -1186,2 +1186,4 @@
if( !COM_GetParmExt( "-file", source, sizeof( source )))
{
printf("%s\n", source);
a1batross commented 2020-11-16 13:24:11 +01:00
Owner
Copy Link

Please remove unnecessary logging.

Please remove unnecessary logging.
a1batross reviewed 2020-11-16 13:24:43 +01:00
utils/bsp31migrate/build.sh
@ -0,0 +1,2 @@
#!/bin/sh
a1batross commented 2020-11-16 13:24:43 +01:00
Owner
Copy Link

Use waf.

Use waf.
nillerusr commented 2020-11-16 14:27:32 +01:00
Author
First-time contributor
Copy Link

why use waf for utilities?

why use waf for utilities?
a1batross commented 2020-11-16 14:35:07 +01:00
Owner
Copy Link

Because we decided to not use everything else than waf as it increases efforts on maintaining.

Well, mdldec in engine repo uses Makefile. Probably for utilities it can be fine but it also have copypasted code, like checking if we are compiling for Windows, the same compiler rules and so on.

Because we decided to not use everything else than waf as it increases efforts on maintaining. Well, mdldec in engine repo uses Makefile. Probably for utilities it can be fine but it also have copypasted code, like checking if we are compiling for Windows, the same compiler rules and so on.
a1batross reviewed 2020-11-16 13:27:30 +01:00
utils/common/filesystem.cpp
@ -213,3 +237,3 @@
}
if( !GetCurrentDirectory( sizeof( root ), root ))
if( !getcwd(root, sizeof( root ) ) )
a1batross commented 2020-11-16 13:27:30 +01:00
Owner
Copy Link

You already have Q_getwd. Why not to use it?

You already have Q_getwd. Why not to use it?
nillerusr commented 2020-11-16 14:25:26 +01:00
Author
First-time contributor
Copy Link

There is no Q_getcwd

There is no Q_getcwd
nillerusr marked this conversation as resolved
a1batross reviewed 2020-11-16 13:28:46 +01:00
utils/common/mathlib.cpp
@ -193,6 +193,7 @@ SinCos
*/
void SinCos( float radians, float *sine, float *cosine )
{
#ifdef _MSC_VER
a1batross commented 2020-11-16 13:28:46 +01:00
Owner
Copy Link

_MSC_VER and x86.

_MSC_VER and x86.
nillerusr closed this pull request 2020-11-16 14:30:12 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FWGS/Paranoia2#1
No description provided.
Delete Branch "nillerusr/Paranoia2:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?