2018-01-01 05:43:02 +01:00
|
|
|
# Copyright 1999-2018 Free Software Foundation, Inc.
|
1999-11-02 05:44:47 +01:00
|
|
|
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
2007-08-23 20:14:19 +02:00
|
|
|
# the Free Software Foundation; either version 3 of the License, or
|
1999-11-02 05:44:47 +01:00
|
|
|
# (at your option) any later version.
|
2007-08-23 20:14:19 +02:00
|
|
|
#
|
1999-11-02 05:44:47 +01:00
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
2007-08-23 20:14:19 +02:00
|
|
|
#
|
1999-11-02 05:44:47 +01:00
|
|
|
# You should have received a copy of the GNU General Public License
|
2007-08-23 20:14:19 +02:00
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
1999-11-02 05:44:47 +01:00
|
|
|
|
2017-10-13 11:48:42 +02:00
|
|
|
# Test only on boards that actually use the remote protocol.
|
|
|
|
if {[target_info gdb_protocol] != "remote"
|
|
|
|
&& [target_info gdb_protocol] != "extended-remote"} {
|
1999-11-02 05:44:47 +01:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
test suite update - gdb.base/[n-r]
Convert files gdb.base/[n-r]*.exp to use standard_output_file et al.
* gdb.base/nextoverexit.exp, gdb.base/nextoverexit.exp,
gdb.base/nodebug.exp, gdb.base/nofield.exp, gdb.base/nostdlib.exp,
gdb.base/opaque.exp, gdb.base/overlays.exp, gdb.base/pc-fp.exp,
gdb.base/pending.exp, gdb.base/permissions.exp,
gdb.base/pie-execl.exp, gdb.base/pointers.exp,
gdb.base/pr11022.exp, gdb.base/print-file-var.exp,
gdb.base/printcmds.exp, gdb.base/prologue.exp,
gdb.base/psymtab.exp, gdb.base/ptr-typedef.exp,
gdb.base/ptype.exp, gdb.base/randomize.exp,
gdb.base/readline-ask.exp, gdb.base/recpar.exp,
gdb.base/recurse.exp, gdb.base/relativedebug.exp,
gdb.base/relocate.exp, gdb.base/remote.exp, gdb.base/reread.exp,
gdb.base/return-nodebug.exp, gdb.base/return2.exp: Use
standard_testfile, standard_output_file, prepare_for_testing,
clean_restart.
2013-06-27 20:53:49 +02:00
|
|
|
standard_testfile .c
|
1999-11-02 05:44:47 +01:00
|
|
|
|
1999-11-09 02:23:30 +01:00
|
|
|
set result [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}]
|
|
|
|
if {$result != "" } then {
|
2016-12-01 21:47:50 +01:00
|
|
|
untested "failed to compile"
|
2006-08-10 07:27:22 +02:00
|
|
|
return -1
|
1999-11-09 02:23:30 +01:00
|
|
|
}
|
|
|
|
|
2018-05-23 00:26:46 +02:00
|
|
|
gdb_start
|
|
|
|
|
|
|
|
# Make sure we're disconnected, in case we're testing with an
|
|
|
|
# extended-remote board, therefore already connected.
|
|
|
|
gdb_test "disconnect" ".*"
|
1999-11-09 02:23:30 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# Part ONE: Check the down load commands
|
|
|
|
#
|
|
|
|
|
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
Handle "show remote memory-write-packet-size" when not connected
Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.
When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.
Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.
The text is taken from the command's online help, which says:
"The actual limit is further reduced dependent on the target."
Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":
~~~
Specify the number of bytes in a packet or 0 (zero) for the
default packet size.
~~~
I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.
While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0. [...]
^^
(gdb) set remote memory-write-packet-size 0
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 16384. [...]
^^^^^
The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.
This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:
/* So that the query shows the correct value. */
if (size <= 0)
size = DEFAULT_MAX_MEMORY_PACKET_SIZE;
to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.
Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
(get_fixed_memory_packet_size): New.
(get_memory_packet_size): Use it.
(set_memory_packet_size): Don't override the config size with
DEFAULT_MAX_MEMORY_PACKET_SIZE.
(show_memory_packet_size): Use get_fixed_memory_packet_size.
Don't refer to get_memory_packet_size if not connected to a remote
target. Show "(default)" if configured size is 0.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Adjust expected output of "show remote
memory-write-packet-size". Add tests for "set remote
memory-write-packet-size 0" and "set remote
memory-write-packet-size fixed/limit".
2018-05-22 19:22:10 +02:00
|
|
|
"The memory-write-packet-size is 0 \\(default\\). The actual limit will be further reduced dependent on the target\." \
|
1999-11-09 02:23:30 +01:00
|
|
|
"write-packet default"
|
|
|
|
|
|
|
|
gdb_test "set remote memory-write-packet-size" \
|
|
|
|
"Argument required .integer, `fixed' or `limited'.\." \
|
|
|
|
"set write-packet - NULL"
|
1999-11-02 05:44:47 +01:00
|
|
|
|
2010-06-01 23:29:21 +02:00
|
|
|
gdb_test_no_output "set remote memory-write-packet-size 20"
|
1999-11-09 02:23:30 +01:00
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
Handle "show remote memory-write-packet-size" when not connected
Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.
When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.
Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.
The text is taken from the command's online help, which says:
"The actual limit is further reduced dependent on the target."
Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":
~~~
Specify the number of bytes in a packet or 0 (zero) for the
default packet size.
~~~
I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.
While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0. [...]
^^
(gdb) set remote memory-write-packet-size 0
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 16384. [...]
^^^^^
The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.
This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:
/* So that the query shows the correct value. */
if (size <= 0)
size = DEFAULT_MAX_MEMORY_PACKET_SIZE;
to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.
Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
(get_fixed_memory_packet_size): New.
(get_memory_packet_size): Use it.
(set_memory_packet_size): Don't override the config size with
DEFAULT_MAX_MEMORY_PACKET_SIZE.
(show_memory_packet_size): Use get_fixed_memory_packet_size.
Don't refer to get_memory_packet_size if not connected to a remote
target. Show "(default)" if configured size is 0.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Adjust expected output of "show remote
memory-write-packet-size". Add tests for "set remote
memory-write-packet-size 0" and "set remote
memory-write-packet-size fixed/limit".
2018-05-22 19:22:10 +02:00
|
|
|
"The memory-write-packet-size is 20. The actual limit will be further reduced dependent on the target\." \
|
1999-11-09 02:23:30 +01:00
|
|
|
"set write-packet - small"
|
|
|
|
|
2010-06-01 23:29:21 +02:00
|
|
|
gdb_test_no_output "set remote memory-write-packet-size 1"
|
1999-11-09 02:23:30 +01:00
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
Handle "show remote memory-write-packet-size" when not connected
Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.
When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.
Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.
The text is taken from the command's online help, which says:
"The actual limit is further reduced dependent on the target."
Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":
~~~
Specify the number of bytes in a packet or 0 (zero) for the
default packet size.
~~~
I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.
While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0. [...]
^^
(gdb) set remote memory-write-packet-size 0
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 16384. [...]
^^^^^
The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.
This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:
/* So that the query shows the correct value. */
if (size <= 0)
size = DEFAULT_MAX_MEMORY_PACKET_SIZE;
to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.
Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
(get_fixed_memory_packet_size): New.
(get_memory_packet_size): Use it.
(set_memory_packet_size): Don't override the config size with
DEFAULT_MAX_MEMORY_PACKET_SIZE.
(show_memory_packet_size): Use get_fixed_memory_packet_size.
Don't refer to get_memory_packet_size if not connected to a remote
target. Show "(default)" if configured size is 0.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Adjust expected output of "show remote
memory-write-packet-size". Add tests for "set remote
memory-write-packet-size 0" and "set remote
memory-write-packet-size fixed/limit".
2018-05-22 19:22:10 +02:00
|
|
|
"The memory-write-packet-size is 1. The actual limit will be further reduced dependent on the target\." \
|
1999-11-09 02:23:30 +01:00
|
|
|
"set write-packet - very-small"
|
|
|
|
|
Handle "show remote memory-write-packet-size" when not connected
Currently "show remote memory-write-packet-size" says that the packet
size is limited to whatever is stored in the remote_state global, even
if not connected to a target.
When we get to support multiple instances of remote targets, there
won't be a remote_state global anymore, so that must be replaced by
something else.
Since it doesn't make sense to print the limit of the packet size of a
non-existing connection, this patch makes us say that the limit will
be further reduced when we connect.
The text is taken from the command's online help, which says:
"The actual limit is further reduced dependent on the target."
Note that a value of "0" is special, as per "help set remote
memory-write-packet-size":
~~~
Specify the number of bytes in a packet or 0 (zero) for the
default packet size.
~~~
I've tweaked "show remote memory-write-packet-size" to include
"(default)" in the output in that case, like this:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0 (default). The actual limit will be further reduced dependent on the target.
While working on this, I noticed that an explicit "set remote
write-packet-size 0" does not makes GDB go back to the exact same
state as the default state when GDB starts up:
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 0. [...]
^^
(gdb) set remote memory-write-packet-size 0
(gdb) show remote memory-write-packet-size
The memory-write-packet-size is 16384. [...]
^^^^^
The "16384" number comes from DEFAULT_MAX_MEMORY_PACKET_SIZE.
This happens because git commit a5c0808e221c ("gdb: remove packet size
limit") at
<https://sourceware.org/ml/gdb-patches/2015-08/msg00743.html>, added
this:
/* So that the query shows the correct value. */
if (size <= 0)
size = DEFAULT_MAX_MEMORY_PACKET_SIZE;
to set_memory_packet_size, but despite what the comment suggests, that
also has the side-effect of recording DEFAULT_MAX_MEMORY_PACKET_SIZE
in config->size.
Finally, DEFAULT_MAX_MEMORY_PACKET_SIZE only makes sense for "set
remote memory-write-packet-size fixed", so I've renamed it
accordingly, to make it a little bit clearer.
gdb/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
(DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
(get_fixed_memory_packet_size): New.
(get_memory_packet_size): Use it.
(set_memory_packet_size): Don't override the config size with
DEFAULT_MAX_MEMORY_PACKET_SIZE.
(show_memory_packet_size): Use get_fixed_memory_packet_size.
Don't refer to get_memory_packet_size if not connected to a remote
target. Show "(default)" if configured size is 0.
gdb/testsuite/ChangeLog:
2018-05-22 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Adjust expected output of "show remote
memory-write-packet-size". Add tests for "set remote
memory-write-packet-size 0" and "set remote
memory-write-packet-size fixed/limit".
2018-05-22 19:22:10 +02:00
|
|
|
gdb_test_no_output "set remote memory-write-packet-size 0"
|
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
|
|
|
"The memory-write-packet-size is 0 \\(default\\). The actual limit will be further reduced dependent on the target\." \
|
|
|
|
"write-packet default again"
|
|
|
|
|
|
|
|
set test "set remote memory-write-packet-size fixed"
|
|
|
|
gdb_test_multiple $test $test {
|
|
|
|
-re "Change the packet size. .y or n. " {
|
|
|
|
gdb_test_multiple "y" $test {
|
|
|
|
-re "$gdb_prompt $" {
|
|
|
|
pass $test
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
|
|
|
"The memory-write-packet-size is 0 \\(default\\). Packets are fixed at 16384 bytes\." \
|
|
|
|
"write-packet default fixed"
|
|
|
|
|
|
|
|
gdb_test_no_output "set remote memory-write-packet-size limit"
|
|
|
|
gdb_test "show remote memory-write-packet-size" \
|
|
|
|
"The memory-write-packet-size is 0 \\(default\\). The actual limit will be further reduced dependent on the target\." \
|
|
|
|
"write-packet default limit again"
|
|
|
|
|
1999-11-09 02:23:30 +01:00
|
|
|
#
|
2017-10-13 12:14:06 +02:00
|
|
|
# Part TWO: Check the download behavior.
|
1999-11-09 02:23:30 +01:00
|
|
|
#
|
|
|
|
|
2006-08-08 17:48:08 +02:00
|
|
|
proc gdb_load_timed {executable class writesize} {
|
1999-11-02 05:44:47 +01:00
|
|
|
global test gdb_prompt
|
2006-08-08 17:48:08 +02:00
|
|
|
set test "timed download `[file tail $executable]' - $class, $writesize"
|
1999-11-02 05:44:47 +01:00
|
|
|
|
|
|
|
if {$writesize != ""} then {
|
2010-06-01 23:29:21 +02:00
|
|
|
gdb_test_no_output "set remote memory-write-packet-size $writesize" \
|
|
|
|
"$test - set packet size"
|
1999-11-09 02:23:30 +01:00
|
|
|
|
|
|
|
send_gdb "set remote memory-write-packet-size $class\n"
|
1999-11-02 05:44:47 +01:00
|
|
|
gdb_expect 5 {
|
1999-11-09 02:23:30 +01:00
|
|
|
-re ".*Change the packet size.*$" {
|
|
|
|
send_gdb "y\n"
|
|
|
|
gdb_expect 5 {
|
|
|
|
-re ".*$gdb_prompt $" {
|
|
|
|
pass "$test - set write size class"
|
|
|
|
}
|
|
|
|
timeout {
|
|
|
|
fail "$test - set write size class"
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
1999-11-02 05:44:47 +01:00
|
|
|
-re ".*$gdb_prompt $" { }
|
1999-11-09 02:23:30 +01:00
|
|
|
timeout {
|
|
|
|
fail "$test - set write size class"
|
|
|
|
return
|
|
|
|
}
|
1999-11-02 05:44:47 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-11-13 23:33:50 +01:00
|
|
|
# Do not try to load using fixed sizes; we may overflow the remote target.
|
|
|
|
if { $class == "fixed" } {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
1999-11-02 05:44:47 +01:00
|
|
|
set load_begin_time [clock clicks]
|
|
|
|
set result [gdb_load $executable]
|
|
|
|
set load_end_time [clock clicks]
|
2004-09-10 03:04:59 +02:00
|
|
|
if { $result != 0 } then {
|
2004-08-29 01:55:48 +02:00
|
|
|
fail "$test - loading executable"
|
|
|
|
return
|
|
|
|
}
|
1999-11-02 05:44:47 +01:00
|
|
|
verbose "$test - time [expr ($load_end_time - $load_begin_time) / 1000] ms"
|
|
|
|
pass $test
|
|
|
|
}
|
|
|
|
|
2018-05-23 00:26:46 +02:00
|
|
|
clean_restart $binfile
|
|
|
|
|
2017-10-13 11:48:42 +02:00
|
|
|
# These download tests won't actually download anything on !is_remote
|
|
|
|
# target boards, but we run them anyway because it's simpler, and
|
|
|
|
# harmless.
|
|
|
|
|
1999-12-07 04:56:43 +01:00
|
|
|
# Typically about 400-1 bytes can be downloaded
|
2006-08-08 17:48:08 +02:00
|
|
|
gdb_load_timed $binfile "limit" 398
|
|
|
|
gdb_load_timed $binfile "limit" 400
|
1999-11-02 05:44:47 +01:00
|
|
|
|
1999-11-09 02:23:30 +01:00
|
|
|
# Absolute max is 16384
|
2006-08-08 17:48:08 +02:00
|
|
|
gdb_load_timed $binfile "fixed" 0
|
|
|
|
gdb_load_timed $binfile "fixed" 16385
|
1999-11-02 05:44:47 +01:00
|
|
|
|
1999-12-07 04:56:43 +01:00
|
|
|
# fall back to the default
|
2006-08-08 17:48:08 +02:00
|
|
|
gdb_load_timed $binfile "limit" 0
|
1999-12-07 04:56:43 +01:00
|
|
|
|
2001-07-17 23:47:19 +02:00
|
|
|
# Get size of data uploaded
|
|
|
|
|
|
|
|
#
|
|
|
|
# Query GDB for the size of various types
|
|
|
|
#
|
|
|
|
|
|
|
|
# Get the size of random_data table (defaults to 48K).
|
|
|
|
set sizeof_random_data [get_sizeof "random_data" 48*1024]
|
1999-12-07 04:56:43 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# Part THREE: Check the upload behavour
|
|
|
|
#
|
2001-07-17 23:47:19 +02:00
|
|
|
if ![runto_main] then {
|
2016-12-01 21:40:05 +01:00
|
|
|
fail "cannot run to main"
|
2017-10-13 12:14:06 +02:00
|
|
|
return
|
2001-07-17 23:47:19 +02:00
|
|
|
}
|
1999-12-07 04:56:43 +01:00
|
|
|
|
|
|
|
# Carefully check memory around each of the most common packet edge
|
|
|
|
# conditions
|
|
|
|
|
|
|
|
gdb_test "x/8ub random_data" \
|
|
|
|
"<random_data>:\[ \t\]+60\[ \t\]+74\[ \t\]+216\[ \t\]+38\[ \t\]+149\[ \t\]+49\[ \t\]+207\[ \t\]+44"
|
|
|
|
|
|
|
|
gdb_test "x/8ub random_data + 400 - 4" \
|
|
|
|
"<random_data\\+396>:\[ \t\]+185\[ \t\]+255\[ \t\]+50\[ \t\]+140\[ \t\]+237\[ \t\]+172\[ \t\]+143\[ \t\]+93"
|
|
|
|
|
2001-07-17 23:47:19 +02:00
|
|
|
if {$sizeof_random_data > 16380 } then {
|
|
|
|
gdb_test "x/8ub random_data + 16384 - 4" \
|
1999-12-07 04:56:43 +01:00
|
|
|
"<random_data\\+16380>:\[ \t\]+178\[ \t\]+180\[ \t\]+135\[ \t\]+93\[ \t\]+70\[ \t\]+62\[ \t\]+205\[ \t\]+76"
|
2001-07-17 23:47:19 +02:00
|
|
|
}
|
1999-12-07 04:56:43 +01:00
|
|
|
|
|
|
|
# Read a chunk just larger than the packet size (reduce the packet
|
|
|
|
# size to make life easier)
|
2010-06-01 23:29:21 +02:00
|
|
|
gdb_test_no_output "set remote memory-read-packet-size 16"
|
|
|
|
|
1999-12-07 04:56:43 +01:00
|
|
|
gdb_test "show remote memory-read-packet-size" \
|
2006-07-04 11:40:28 +02:00
|
|
|
"The memory-read-packet-size is 16. Packets are limited to 20 bytes."
|
1999-12-07 04:56:43 +01:00
|
|
|
gdb_test "x/17ub random_data" \
|
|
|
|
"<random_data>:\[ \t\]+60\[ \t\]+74\[ \t\]+216\[ \t\]+38\[ \t\]+149\[ \t\]+49\[ \t\]+207\[ \t\]+44.*<random_data\\+8>:\[ \t\]+124\[ \t\]+38\[ \t\]+93\[ \t\]+125\[ \t\]+232\[ \t\]+67\[ \t\]+228\[ \t\]+56.*<random_data\\+16>:\[ \t\]+161"
|
|
|
|
|
Fix PR gdb/15289 - "set remote hardware-watchpoint-limit" broken (zinteger commands)
This is a regression from 7.5, introduced/exposed by:
http://sourceware.org/ml/gdb-patches/2012-07/msg00259.html
There are a series of issues with this code.
It does:
unsigned int val = parse_and_eval_long (arg);
^^^^^^^^^^^^
(unsigned, usually 32-bit) while parse_and_eval_long returns a LONGEST
(usually 64-bit), so we lose precision without noticing:
(gdb) set remote hardware-watchpoint-limit 0x100000000
(gdb) show remote hardware-watchpoint-limit 0x100000000
The maximum number of target hardware watchpoints is 0.
While at it, print the invalid number with plongest, so the user sees
what GDB thought the number was:
(gdb) set remote hardware-watchpoint-limit 0x100000000
integer 4294967296 out of range
So with "set remote hardware-watchpoint-limit -1", val ends converted
to 0xffffffff, which then fails the
else if (val >= INT_MAX)
error (_("integer %u out of range"), val);
test.
Looking at that INT_MAX check, we forbid INT_MAX itself, but we
shouldn't, as that does fit in 'int' -- we want to forbid values
_greater_ than INT_MAX (and less than INT_MIN, while at it):
(gdb) set remote hardware-watchpoint-limit 2147483647
integer 2147483647 out of range
The same problem is in the new var_zuinteger_unlimited code, which
also uses "int" for variable.
Also, when printing a 'signed int', we should use %d, not %u.
This adds a couple regression tests. Not completely thorough in checking
all kinds of invalid input; I'm saving more exaustive testing around
zXXinteger commands for something like new test-assisting commands
like "maint test cmd-zinteger -1", where testing would focus on the
command types, and thus be independent of particular user commands of
particular GDB features.
Tested on x86_64 Fedora 17.
gdb/
2013-03-20 Pedro Alves <palves@redhat.com>
PR gdb/15289
* cli/cli-setshow.c (do_set_command)
<var_uinteger, var_zuinteger>: Use LONGEST for variable holding
the result of parsing the command argument. Throw error if the
value is greater than UINT_MAX. Print the invalid value with
plongest.
<var_integer, var_zinteger>: Use LONGEST for variable holding the
result of parsing the command argument. Throw error if the value
is greater than INT_MAX, not greater or equal. Also throw error
if the value is less than INT_MIN. Print the invalid value with
plongest.
<var_zuinteger_unlimited>: Throw error if the value is greater
than INT_MAX, not greater or equal.
(do_show_command) <var_integer, var_zinteger,
var_zuinteger_unlimited>: Use %d for printing int, not %u.
gdb/testsuite/
2013-03-20 Pedro Alves <palves@redhat.com>
PR gdb/15289
* gdb.base/remote.exp: Test
"set remote hardware-watchpoint-limit -1",
"set remote hardware-breakpoint-limit -1",
"set remote hardware-watchpoint-limit 2147483647" and
"set remote hardware-breakpoint-limit 2147483647".
2013-03-20 19:58:16 +01:00
|
|
|
# Regression test for gdb/15289. Make sure -1 is accepted and handled
|
|
|
|
# as "unlimited".
|
|
|
|
gdb_test_no_output "set remote hardware-watchpoint-limit -1"
|
|
|
|
gdb_test_no_output "set remote hardware-breakpoint-limit -1"
|
|
|
|
|
|
|
|
# This is just being thorough. Assume (at least) a 32-bit host int,
|
|
|
|
# and make sure 32-bit INT_MAX is accepted by a zinteger command.
|
|
|
|
gdb_test_no_output "set remote hardware-watchpoint-limit 2147483647"
|
|
|
|
gdb_test_no_output "set remote hardware-breakpoint-limit 2147483647"
|
|
|
|
|
1999-11-02 05:44:47 +01:00
|
|
|
gdb_exit
|