OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix gdb.tui/completion.exp test 

When I run it locally, the test gdb.tui/completion.exp test fails
because of a timeout:

Running /home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.tui/completion.exp ...
FAIL: gdb.tui/completion.exp: completion of layout names: tab completion (timeout)

The problem seems to be this regex, which confirms that after doing
layout<TAB>, "layout" is printed again after the gdb prompt:

  -re "^$input_line$"

The problem is that there's a trailing space in the output after
"layout".  Since the regex has an anchored end (the $), it doesn't
match.  Adding a space fixes the test.

gdb/testsuite/ChangeLog:

	* gdb.tui/completionn.exp (test_tab_completion): Add space in
	regex.
This commit is contained in:
Simon Marchi 2017-11-15 11:07:02 -05:00
parent 01f4802036
commit 71774bc994
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2017-11-15 Simon Marchi <simon.marchi@ericsson.com>
* gdb.tui/completionn.exp (test_tab_completion): Add space in
regex.
2017-11-13 Simon Marchi <simon.marchi@polymtl.ca>
* gdb.opt/inline-locals.exp: Remove trailing parentheses from

2
gdb/testsuite/gdb.tui/completion.exp
View File

@ -32,7 +32,7 @@ proc test_tab_completion {input_line expected_re} {
gdb_test_multiple "" "$test" {
-re "$expected_re\r\n$gdb_prompt " {
gdb_test_multiple "" "$test" {
-re "^$input_line$" {
-re "^$input_line $" {
pass "$test"
}
}