OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix racy test in gdb.base/new-ui.exp 

I noticed gdb.base/new-ui.exp failing once here with:

 FAIL: gdb.base/new-ui.exp: do_test: delete all breakpoints on extra console (got interactive prompt)
 FAIL: gdb.base/new-ui.exp: do_test: main console: next causes no spurious output on other console
 FAIL: gdb.base/new-ui.exp: do_test: main console: breakpoint hit reported on other console

The problem is 100% reproducible with check-read1:
  $ make check-read1 TESTS="gdb.*/new-ui.exp"

testsuite/gdb.log shows:
  delete
  Delete all breakpoints? (y or n) [answered Y; input not from terminal]
  (gdb) FAIL: gdb.base/new-ui.exp: do_test: delete all breakpoints on extra console (got interactive prompt)

This commit fixes the problem.

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.base/new-ui.exp (do_test): Split "delete all breakpoints on
	extra console" test in two stages.
This commit is contained in:
Pedro Alves 2017-10-24 23:22:56 +01:00
parent 63a25ea0de
commit 792ccf005f
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.base/new-ui.exp (do_test): Split "delete all breakpoints on
extra console" test in two stages.
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.threads/attach-into-signal.exp (corefunc): Reindent.

15
gdb/testsuite/gdb.base/new-ui.exp
View File

@ -135,9 +135,18 @@ proc_with_prefix do_test {} {
"Delete all breakpoints. .y or n. $" "n"
}
with_spawn_id $extra_spawn_id {
gdb_test "delete" \
"Delete all breakpoints. .y or n. .answered Y; input not from terminal." \
"delete all breakpoints on extra console"
# Check output in two stages in order to override
# gdb_test_multiple's internal "got interactive prompt" fail
# that would otherwise match if the expect buffer happens to
# fill with partial output that ends in "(y or n) ".
set test "delete all breakpoints on extra console"
gdb_test_multiple "delete" $test {
-re "Delete all breakpoints. .y or n. " {
gdb_test "" \
".answered Y; input not from terminal." \
$test
}
}
}
# Run a few execution tests with the main console as the driver