binutils-gdb/ld
H.J. Lu 1622ff3b43 Check regular reference without non-GOT reference
non_got_ref may not be set when building shared library. We need to set
non_got_ref if there are any non-PIC relocations.  But we only did this
when there were no PLT/GOT relocations.  It failed when there is a PLT
relocation.  This checkin moves the non_got_ref check out.

bfd/

2013-04-15  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/15371
	* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Check
	regular reference without non-GOT reference when building
	shared library.

ld/testsuite/

2013-04-15  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/15371
	* ld-ifunc/ifunc-20-i386.d: New file.
	* ld-ifunc/ifunc-20-x86-64.d: Likewise.
	* ld-ifunc/ifunc-20.s: Likewise.
diff --git a/bfd/elf-ifunc.c b/bfd/elf-ifunc.c
index e56427d..7e7ec36 100644
--- a/bfd/elf-ifunc.c
+++ b/bfd/elf-ifunc.c
@@ -187,23 +187,20 @@ _bfd_elf_allocate_ifunc_dyn_relocs (struct bfd_link_info *info,

   htab = elf_hash_table (info);

+  /* When building shared library, we need to handle the case where it is
+     marked with regular reference, but not non-GOT reference since the
+     non-GOT reference bit may not be set here.  */
+  if (info->shared && !h->non_got_ref && h->ref_regular)
+    for (p = *head; p != NULL; p = p->next)
+      if (p->count)
+	{
+	  h->non_got_ref = 1;
+	  goto keep;
+	}
+
   /* Support garbage collection against STT_GNU_IFUNC symbols.  */
   if (h->plt.refcount <= 0 && h->got.refcount <= 0)
     {
-      /* When building shared library, we need to handle the case
-         where it is marked with regular reference, but not non-GOT
-	 reference.  It may happen if we didn't see STT_GNU_IFUNC
-	 symbol at the time when checking relocations.  */
-      if (info->shared
-	  && !h->non_got_ref
-	  && h->ref_regular)
-	for (p = *head; p != NULL; p = p->next)
-	  if (p->count)
-	    {
-	      h->non_got_ref = 1;
-	      goto keep;
-	    }
-
       h->got = htab->init_got_offset;
       h->plt = htab->init_plt_offset;
       *head = NULL;
diff --git a/ld/testsuite/ld-ifunc/ifunc-20-i386.d b/ld/testsuite/ld-ifunc/ifunc-20-i386.d
new file mode 100644
index 0000000..9373fcf
--- /dev/null
+++ b/ld/testsuite/ld-ifunc/ifunc-20-i386.d
@@ -0,0 +1,13 @@
+#source: ifunc-20.s
+#ld: -shared -m elf_i386 -z nocombreloc
+#as: --32
+#readelf: -r --wide
+#target: x86_64-*-* i?86-*-*
+
+Relocation section '.rel.ifunc' at offset 0x[0-9a-f]+ contains 1 entries:
+[ ]+Offset[ ]+Info[ ]+Type[ ]+.*
+[0-9a-f]+[ ]+[0-9a-f]+[ ]+R_386_32[ ]+ifunc\(\)[ ]+ifunc
+
+Relocation section '.rel.plt' at offset 0x[0-9a-f]+ contains 1 entries:
+[ ]+Offset[ ]+Info[ ]+Type[ ]+.*
+[0-9a-f]+[ ]+[0-9a-f]+[ ]+R_386_JUMP_SLOT[ ]+ifunc\(\)[ ]+ifunc
diff --git a/ld/testsuite/ld-ifunc/ifunc-20-x86-64.d b/ld/testsuite/ld-ifunc/ifunc-20-x86-64.d
new file mode 100644
index 0000000..39492d4
--- /dev/null
+++ b/ld/testsuite/ld-ifunc/ifunc-20-x86-64.d
@@ -0,0 +1,13 @@
+#source: ifunc-20.s
+#ld: -shared -m elf_x86_64 -z nocombreloc
+#as: --64
+#readelf: -r --wide
+#target: x86_64-*-*
+
+Relocation section '.rela.ifunc' at offset 0x[0-9a-f]+ contains 1 entries:
+[ ]+Offset[ ]+Info[ ]+Type[ ]+.*
+[0-9a-f]+[ ]+[0-9a-f]+[ ]+R_X86_64_64[ ]+ifunc\(\)[ ]+ifunc \+ 0
+
+Relocation section '.rela.plt' at offset 0x[0-9a-f]+ contains 1 entries:
+[ ]+Offset[ ]+Info[ ]+Type[ ]+.*
+[0-9a-f]+[ ]+[0-9a-f]+[ ]+R_X86_64_JUMP_SLOT[ ]+ifunc\(\)[ ]+ifunc \+ 0
diff --git a/ld/testsuite/ld-ifunc/ifunc-20.s b/ld/testsuite/ld-ifunc/ifunc-20.s
new file mode 100644
index 0000000..9d45455
--- /dev/null
+++ b/ld/testsuite/ld-ifunc/ifunc-20.s
@@ -0,0 +1,16 @@
+	.section .data.rel,"aw",@progbits
+	.globl ifunc_ptrt
+	.type	ifunc_ptr, @object
+ifunc_ptr:
+	.dc.a ifunc
+	.text
+	.type ifunc, @gnu_indirect_function
+	.globl ifunc
+ifunc:
+	ret
+	.size	ifunc, .-ifunc
+	.type bar, @function
+	.globl bar
+bar:
+	call	ifunc@PLT
+	.size	bar, .-bar
2013-04-15 21:16:18 +00:00
..
emulparams * emulparams/aarch64linux.sh (LIBPATH_SUFFIX): Set to 64 for 2013-03-14 08:56:05 +00:00
emultempl * ldlang.c (load_symbols): Report "error adding symbols" on 2013-04-04 14:38:47 +00:00
po Updated Ukranian translations. 2012-08-14 11:59:05 +00:00
scripttempl * scripttempl/armbpabi.sc: Replace DWARF sections with an 2013-04-15 08:51:58 +00:00
testsuite Check regular reference without non-GOT reference 2013-04-15 21:16:18 +00:00
.gitignore
aclocal.m4 * configure.in (AC_CHECK_FUNCS): Add setlocale. 2012-04-05 08:43:41 +00:00
ChangeLog * Makefile.am (ELF_DEPS): Add a dependency upon 2013-04-15 12:04:48 +00:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004 Add copyright notices 2012-12-10 12:48:03 +00:00
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-9197
ChangeLog-9899
config.in
configure
configure.host * configure.host: Add x86_64-*-cygwin* as valid host. 2013-03-05 11:54:29 +00:00
configure.in
configure.tgt * configure.host: Add x86_64-*-cygwin* as valid host. 2013-03-05 11:54:29 +00:00
deffile.h
deffilep.y * deffilep.y (def_image_name): Adjust type of base-address 2013-01-25 11:39:42 +00:00
dep-in.sed
elf-hints-local.h Remove trailing white spaces in ld 2013-01-10 20:08:03 +00:00
fdl.texi
gen-doc.texi Add copyright notices 2012-12-17 16:56:12 +00:00
genscrba.sh
genscripts.sh
h8-doc.texi
ld.h
ld.texinfo * ld.texinfo (--disable-runtime-pseudo-reloc): Adjust default. 2013-03-25 18:09:04 +00:00
ldcref.c
ldctor.c
ldctor.h
ldemul.c
ldemul.h
ldexp.c
ldexp.h
ldfile.c * ldfile.c (ldfile_open_command_file_1): Return after einfo 2013-03-06 13:48:46 +00:00
ldfile.h
ldgram.y
ldint.texinfo Add directory section for info document. 2010-10-28 11:40:26 +00:00
ldlang.c * ldlang.c (load_symbols): Report "error adding symbols" on 2013-04-04 14:38:47 +00:00
ldlang.h
ldlex-wrapper.c Add copyright notices 2012-12-17 16:56:12 +00:00
ldlex.h
ldlex.l
ldmain.c
ldmain.h
ldmisc.c
ldmisc.h
ldver.c
ldver.h
ldwrite.c Remove trailing white spaces in ld 2013-01-10 20:08:03 +00:00
ldwrite.h
lexsup.c
MAINTAINERS Add copyright notices 2012-12-17 16:56:12 +00:00
Makefile.am * Makefile.am (ELF_DEPS): Add a dependency upon 2013-04-15 12:04:48 +00:00
Makefile.in * Makefile.am (ELF_DEPS): Add a dependency upon 2013-04-15 12:04:48 +00:00
mri.c
mri.h
NEWS
pe-dll.c * pe-dll.c (process_def_file_and_drectve): Don't handle VC 2013-03-21 14:05:29 +00:00
pe-dll.h
pep-dll.c 2010-04-05 Kai Tietz <kai.tietz@onevision.com> 2010-04-05 09:04:09 +00:00
pep-dll.h
plugin.c 2013-02-19 Sandra Loosemore <sandra@codesourcery.com> 2013-02-19 03:59:08 +00:00
plugin.h
README
stamp-h.in
sysdep.h
testplug.c Remove trailing redundant `;' 2012-11-09 08:29:34 +00:00
TODO 19990502 sourceware import 1999-05-03 07:29:11 +00:00

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texinfo), as well as the
  beginnings of an internals manual (ldint.texinfo).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texinfo manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.